pop-os / shell-shortcuts Goto Github PK

View Code? Open in Web Editor NEW

53.0 10.0 15.0 136 KB

Application for displaying and demoing Pop Shell shortcuts

License: GNU General Public License v3.0

Rust 93.17% Makefile 6.83%

shell-shortcuts's Introduction

Pop Shell Keyboard Shortcuts

Application for displaying and demoing Pop Shell shortcuts.

Dependencies

The following dependencies are required to build shell-extensions.

On a debian-derived distribution, the required dependencies are easily installed with apt.

apt install cargo libgtk-3-dev rustc

Build

First, get the project's source code.

git clone https://github.com/pop-os/shell-shortcuts.git

The following make commands are run from the top-level of the source directory, so move to that directory.

cd shell-shortcuts

The project's sources are built with make.

make

Assuming nothing goes wrong, this will generate the pop-shell-shortcuts executable in the target/release directory.

By default, the application is built for release. To build the binary with debug symbols, provide DEBUG=1 with the make command.

make DEBUG=1

This will generate the pop-shell-shortcuts executable in the target/debug directory.

Install

Install with make.

sudo make install

Alternatively, the debug version can be installed.

sudo make install DEBUG=1

An uninstall target is also provided to remove the installed application.

sudo make uninstall

Run

Execute the pop-shell-shortcuts binary. Assuming the binary has been installed in your path, run it as usual.

pop-shell-shortcuts

shell-shortcuts's People

Stargazers

Watchers

Forkers

nicolae-stroncea maxwelldb shizonic timrichardson hixio-mh jmmaranan bennettip chrysostomus blankon tubbz-alt startung blomquistr unne27 isabella232 mynameis-13

shell-shortcuts's Issues

Typo in keyboard shortcuts

Just updated to 20.04 (awesome job!). I noticed a typo in the keyboard shortcuts guide:

"worksapce" -> "workspace"

PR #19 fixes this, as far as I can tell, but it's my first pop!_os-related commit.

Shortcuts window opens in tiling mode, but children of it are in floating mode

If I run pop-shell-shortcuts, the shortcuts window opens in tiling mode. If I have the shortcuts window active and open another application, that application opens in floating mode.

~~I'm also wondering if making the shortcuts window open only in floating mode (much like screenshots) is a good way to deal with #2~~ Never mind, it is designed to be tiled so it can be used as a reference.

Expand Resizing Shortcuts for Clarity

Change resizing keys in shortcut help to two descriptions.

Shift Direction Key Right/Down | Increase Window Size
Shift Direction Key Left/Up | Decrease Window Size

Designs for the window with Shell-related keyboard shortcuts

What's the point?

The extension introduces several new shortcuts and modifies some of the existing shortcuts. To provide an easier on-boarding experience, the new shortcuts could be listed in the separate window that helps users get a better idea of what the shortcuts do and how they work.
To get to that window a user can select "View all" under the Keyboard shortcuts in the extension's menu.

Default screen view - extension menu - keyboard shortcuts - View all

The design for the window with shortcuts (for light and dark modes):

The screens should emulate the movement of the windows when the shortcut is used. The prototype gives some idea of how that should work (although some movements are not quite there because of the tool's deficiencies): https://www.figma.com/proto/793ZrYA6NUofmPbG5rmxng/Tiling?node-id=527%3A1549&scaling=min-zoom
Please, note that the prototype might not have the latest UI

As an example of UI, a set of screens for one of the shortcuts.

x86_64' is not a recognized processor for this target

I'm installing/compiling this program for my Arch GNU/Linux machine over an unofficial AUR package. According to its PKGBUILD file, it calls make prefix=/usr to compile during the build() step, which fails. I get the following error during compilation:

==> Starting build()...
cargo build "--release"
   Compiling proc-macro2 v1.0.10
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.18
   Compiling serde v1.0.115
'x86_64' is not a recognized processor for this target (ignoring processor)
[...]
'x86_64' is not a recognized processor for this target (ignoring processor)
LLVM ERROR: 64-bit code requested on a subtarget that doesn't support it!
error: could not compile `unicode-xid`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
'x86_64' is not a recognized processor for this target (ignoring processor)
[...]
LLVM ERROR: 64-bit code requested on a subtarget that doesn't support it!
error: build failed
make: *** [Makefile:57: target/release/pop-shell-shortcuts] Error 101

Is this an issue with your Makefile or my system?

Shortcut to power off

Hi everyone,

Just moved to Pop!_OS this week and I am really enjoying it, great work you all have done!

I was thinking about a shortcut to power off the computer. Is there room for it? Also, I was thinking to leave super + L to block the computer and actually super + ESC to power off. What do you think?

Shortcuts aren't working as they supposed to

Back on 19.10, all of the keyboard shortcuts worked flawlessly. Now on 20.04 some works. Pressing ctrl+super+ direction keys only works up, down and left. The right doesn't work. If I try to move one window to the left and the other to the right, I can only move them to the left. The right is not doing anything. I have clean installed the OS three times thinking that I had a bad install but to no avail.
Thank you

edit: After fiddling around, I found out that disabling the "pop shell" extension restores that functionality. I don't know if that is intentional or a bug.

Show desktop Keyboard Shortcut is missing in v20.04

Super+D keyboard shortcut to Show Desktop icons is not registered in Keyboard Shortcuts. Need help as I use this shortcut quite frequently.

Arrow keys are incorrect

The 'Increase Window Size' and 'Decrease Window Size' sections but have down arrow keys instead of one down and one up arrow key.

Fails to install

Upon cloning the repo and running make, I am met with the following output:

❯ make
cargo build "--release"
   Compiling proc-macro2 v1.0.10
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.18
   Compiling serde v1.0.115
   Compiling unicode-segmentation v1.6.0
   Compiling pkg-config v0.3.17
   Compiling strum v0.18.0
   Compiling version-compare v0.0.10
   Compiling libc v0.2.69
   Compiling version_check v0.9.2
   Compiling pin-project-internal v0.4.23
   Compiling memchr v2.3.3
   Compiling proc-macro-nested v0.1.4
   Compiling futures-core v0.3.5
   Compiling futures-sink v0.3.5
   Compiling proc-macro-hack v0.5.15
   Compiling once_cell v1.4.1
   Compiling pin-utils v0.1.0
   Compiling slab v0.4.2
   Compiling anyhow v1.0.32
   Compiling futures-io v0.3.5
   Compiling either v1.6.0
   Compiling bitflags v1.2.1
   Compiling gio v0.9.1
   Compiling pango v0.9.1
   Compiling gdk-pixbuf v0.9.0
   Compiling cairo-rs v0.9.1
   Compiling atk v0.9.0
   Compiling gdk v0.13.2
   Compiling cascade v0.1.4
   Compiling enclose v1.1.8
   Compiling heck v0.3.1
   Compiling futures-channel v0.3.5
   Compiling futures-task v0.3.5
   Compiling itertools v0.9.0
   Compiling quote v1.0.3
   Compiling proc-macro-error-attr v1.0.4
   Compiling proc-macro-error v1.0.4
   Compiling gtk v0.9.2
   Compiling toml v0.5.6
   Compiling proc-macro-crate v0.1.5
   Compiling thiserror-impl v1.0.20
   Compiling strum_macros v0.18.0
   Compiling futures-macro v0.3.5
   Compiling glib-macros v0.10.1
   Compiling derive_more v0.99.9
   Compiling thiserror v1.0.20
   Compiling system-deps v1.3.2
   Compiling glib-sys v0.10.0
   Compiling gobject-sys v0.10.0
   Compiling gio-sys v0.10.0
   Compiling pango-sys v0.10.0
   Compiling gdk-pixbuf-sys v0.10.0
   Compiling cairo-sys-rs v0.10.0
   Compiling gdk-sys v0.10.0
   Compiling atk-sys v0.10.0
   Compiling gtk-sys v0.10.0
   Compiling pin-project v0.4.23
error: failed to run custom build command for `glib-sys v0.10.0`

Caused by:
  process didn't exit successfully: `/home/lenny/shell-shortcuts/target/release/build/glib-sys-92f03e50100043d4/build-script-build` (exit code: 1)
--- stderr
Failed to run `"pkg-config" "--libs" "--cflags" "glib-2.0" "glib-2.0 >= 2.44"`: No such file or directory (os error 2)

warning: build failed, waiting for other jobs to finish...
error: build failed
make: *** [Makefile:57: target/release/pop-shell-shortcuts] Error 101

Add missing COSMIC shortcuts

One would assume that all available shortcuts would be available under (window tile icon) -> Shortcuts, but they're not.

I was trying to find a way to access workspaces (now that they don't show up in the launcher in 21.04), and didn't see any shortcut for that in the list so I had to ask around in the chat rooms. Without doing so, how would folks know that it's Super-D if it's not listed?

From a UX perspective, the COSMIC shortcuts aren't discoverable at all.

Clarify `Move, resize, and swap windows` section

The section doesn't explain that you need to enter adjustment mode in order to use the shortcuts in there. One way to do it is rename section to:

Move, resize and swap windows in adjustment mode

Should we include Super+O and Super+G?

Super + O (O as in Oscar, not Zero) and Super + G seem like they will be very useful for using tiling mode, and I'm wondering if they're important enough to include in pop-shell-shortcuts. @maria-komarova what do you think of this?

For reference:
Super + O = toggle column vs row tiles
Super + G = toggle a window between tile mode and float mode

Cntrl arrow is not shifting focus only highlight

Thanks for the great software. I love POP!_OS 20.04. Nevertheless, ;) After hitting super enter, cntrl arrow moves the highlighting but not the active hint. So when an arrow is pressed on its own, the tile that was initially selcted with super enter is moved, and not the tile with the highlighting. Cheers!

[Feature Request] Build instructions for getting pop shell shortcuts

Hello, I am getting an error of not having pop-shell-shortcuts together with pop-shell on my system. How can I install this?

Thanks

Contents scrolls after resizing and before un-focusing

When the shortcuts list is maximized on a 1080p display (for example), the shortcuts split into two columns, allowing everything to be viewed without scrolling; however, scrolling is still possible:

Scrolling is only possible until the window is un-focused; once it's un-focused, the scrollbar moves back to the top by itself, and does not appear again after the window is re-focused.

It would be preferable if the scrollbar went away as soon as all of the contents is visible.

Add an option to start the first window of a workspace in stacked mode

Hey!

Looking for a way to start every workspace in stacked mode.
this helps in low res screens, laptops where it make sense to only to split the window into two , any further the window sizes get too small to be usefull.

I find myself splitting the window into two(in my low res laptop screen), starting stack mode on both, then piling on the windows in both the stacks..
this keeps the window sizes constant (half a screen), yet still lets me manage a large number of active windows.

this can be optional of course - as some would prefer to start in tiling mode and stay in tiling mode.

Impressed how close the extension makes gnome feel like i3!
the feature idea is much like workspace_layout stacking in i3 ;)

~ascesh

Add Super+Q to shortcuts help

Add keyboard icon to pop-shell-shortcuts

Super+/ Binding listed twice, in two sections, with different descriptions

The "Navigate Applications and Windows" section lists the Super+/ binding as "Launch and Switch Applications". It is also listed under "Launcher Shortcuts", as "Activate Launcher".

Do we want it listed in two places? It makes sense in both, but the duplication seems weird.
If we remove one, which should be kept?
In either case, presumably it should be described only one way. What should it be called?

shell-shortcuts isn't shrinking enough

shell-shortcuts overlapping over calculator.

Wire shortcuts to gsettings

To keep them aligned if users change defaults.

Pop shell shortcut compile warning

(1) Issue/Bug Description:

Compiling warning

(2) Steps to reproduce (if you know):

Make popshell

(3) Expected behavior:

(4) Distribution (run cat /etc/os-release):

NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux

(5) Gnome Shell version:

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

(7) Where was Pop Shell installed from:

git

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc):

(9) Other Installed/Enabled Extensions:

(10) Other Notes:

Compiling pop-shell-shortcuts v0.1.0 (/tmp/yaourt-tmp-markostech/aur-pop-shell-shortcuts-git/src/shell-shortcuts)
warning: unused variable: widget
--> src/app.rs:316:69
|
316 | let event_handler: Rc<dyn Fn(&gtk::EventBox, Event)> = Rc::new(|widget, event| {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: _widget
|
= note: #[warn(unused_variables)] on by default

warning: 1 warning emitted

Shell Shortcuts window is too small by default

When opening the Shell Shortcuts page, the window is too small to be useful by default, requiring that the window be resized to a much larger size in order to view anything. This doesn't happen in tiling mode because the tiling WM resizes the window as part of the tiling, however the "View All" link is still present by default with tiling disabled, and it looks broken having the window open up so small.

Using pop-shell 0.1.0~1586823586~20.04~63b89d0, up-to-date from APT as of 2020-04-14 at 12:16pm.

Screenshot attached:

The shortcuts window does not tile to small sizes well

The window will not get much smaller than quarter-size on my 1920x1080 display.

When it's quarter-sized, it does not show many shortcut items, meaning the user has to scroll through them. I'd like @maria-komarova 's thoughts -- are we ok with this the way it is? It's still usable at quarter-size, just probably not as good as it could be.