Giter Site home page Giter Site logo

popflamingo / oneaxisgeometryreader Goto Github PK

View Code? Open in Web Editor NEW
18.0 18.0 1.0 942 KB

This package attempts to reproduce the behavior of the GeometryReader view, but on a single axis

License: Apache License 2.0

Swift 100.00%
swift swift-package-manager swift5 swiftui

oneaxisgeometryreader's People

Contributors

popflamingo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

developerjigr

oneaxisgeometryreader's Issues

Release

It would be great if you could tag a release so we can target a major version of the dependency in SPM.

Remove FIXME in reduce(value:nextValue:)

First of all, I would like to thank you for contributing this repository. Even though it's already late 2021, SwiftUI still has a lot of imperfections. I still need OneAxisGeometryReader to avoid unwanted effects of the original GeometryReader.

When I read your source code, I found a FIXME tag here:

https://github.com/adtrevor/OneAxisGeometryReader/blob/579e35cbe61acf014e14a14c875a79aa5efc29e2/Sources/OneAxisGeometryReader/HorizontalGeometryReader.swift#L23

I believe this FIXME can be safely removed, since the empty implementation is intended in this case.

Update README

  • Consider wether or not the hack used by OneAxisGeometryReader is something that can be expected to be stable in future versions of SwiftUI. If it is the README should be updated to remove sections specifying the package is just an experiment.
  • Update alt text for images as it doesn't match the code anymore.

Determine if views should be renamed to shorter names (HGeometryReader and VGeometryReader)

Using HGeometryReader and VGeometryReader instead of HorizontalGeometryReader and VerticalGeometryReader would be more concise and would better fit existing SwiftUI naming conventions such as what's used for HStack, VStack and ZStack.

The only issue there might be is that since it matches SwiftUI naming conventions, I'm unsure of the consequences it would have if Apple were to add views named exactly like this in a future SwiftUI version.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.