Giter Site home page Giter Site logo

rollup-plugin-modify's People

Contributors

porsager avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

rollup-plugin-modify's Issues

Every replacement being in the same file is not a robust assumption

I've come across two separate issues with using the plugin where the built-in assumption that all the strings/regexes to replace would be in the same file fails;

      if (modifiers.every(x => !x[0].test(source)))
        return
  1. I'm working on some source code that even for a development environment contains semi-secret variables (cloud service ids etc) that should not be commited. With a setup based on the BoilerWebApp repo, however, the dev.js script doesn't actually put everything into the same file, so the .every check fails.

  2. For a production build, I have chosen to conditionally import/require separate files in the part of code that would be excluded (this is WIP for inlining bss stuff in the header), so while I can move the plugin location to such a place it actually replaces strings as expected, the bundling either fails or includes cruft that ideally should be tree-shaken away.

Relatedly, there's actually an inherent dependency on having this plugin in a specific place in the order of potential rollup-plugins that is not documented...

I realise that it's not necessarily an ideal situation, but perhaps optionally relaxing the same-file assumption might be an idea. Don't know if this is a situation with or what the possible solution for the issues might be with similar plugin implementations...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.