postlight/hubot-spotify-playlist

Allows the ability to add/remove/findTracks to a Spotify Playlist.

hubot-spotify-playlist's Issues

Remove debug code on first run

On the first run when the bot gets its access/refresh tokens, it displays it.

Preview Links?

Maybe can provide a link to preview the song on the search result. Would make things a bit easier

Quick add, where it would add the first search result

Instead of doing a search and adding a track, it looks like it might be a good idea to just do a straight out search and post the first entry.

Use Natural Language for Commands

Since these commands are typed by non-programmers, English words are common for Hubot plugins.

• findTrack could become spotify find <query>
• addTrack could become spotify queue <query>
• getToken could become spotify get token
• removeTrack could become spotify (unqueue|remove) <query>

Namespace Use of Hubot's Brain

Since it's just a key / value store, I can imagine something stepping on your data. One approach I've seen is in hubot-plusplus.

Simplify the posting of the requests code

Quite a bit of duplication, should clean it up.

Preserve Spotify Key so Users Don't Have to Send It

From #1.

Oh interesting, I didn't realize that limitation existed. It sounds like something that should be rolled into the bot. The bot itself has a Redis-based brain that can store data between requests. Perhaps we could authenticate and have it re-authenticate behind the scenes as necessary? Or at least save the last key.

Bot should make a single post when doing searches

The bot is currently making a post entry for each search result. Lets combine them so its just a single post.

Change from robot.hear to robot.listen

Please change robot.hear to robot.listen in these 4 instances: https://github.com/postlight/hubot-spotify-playlist/blob/master/src/spotify-playlist.coffee#L124-L133.

Since this is using robot.hear, when I run the bot locally (even with a different name), it responds to text matches regardless of the preceding name.

robot.hear - callback is called anytime a message's text matches
robot.respond - callback is only called for messages that are immediately preceded by the robot's name or alias

Hear vs. listen: https://github.com/github/hubot/blob/master/docs/scripting.md#hearing-and-responding

I tried to submit a PR for this myself but was denied due to permissions.