ppartisan/rundo

Adds Undo/Redo functionality to editable text fields in Android.

rundo's Issues

Fatal Exception: java.lang.StringIndexOutOfBoundsException

Im getting Fatal Exception: java.lang.StringIndexOutOfBoundsException

my logs :
java.lang.String.substring (String.java:1931)
com.werdpressed.partisan.rundo.SubtractStrings.getReplacedText (Unknown Source)
com.werdpressed.partisan.rundo.SubtractStrings.getItem (Unknown Source)
com.werdpressed.partisan.rundo.WriteToArrayDequeRunnable.run (Unknown Source)
android.os.Handler.handleCallback (Handler.java:751)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:154)
android.app.ActivityThread.main (ActivityThread.java:6682)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1534)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1424)

Im running version : 1.0.5

After rotation (on resume), undo and redo are not working

Prerequisites:

I have an activity with a fragmentPager and fragments, compiled against SDK28.
But i assume the bug could be reproduced with every activity using RunDo.

Description

Change the text of the linked EditText. Then rotate the device. The activity and thus RunDo(Support) get rebuild. But RunDo is in a broken state: neither undo nor redo will work. Even when changing the linked EditText's text again.

I think the bug is happening on this line:

RunDo/rundo/src/main/java/com/werdpressed/partisan/rundo/RunDoSupport.java

Line 82 in 7b2bde8

trackingState = TRACKING_STARTED;

RunDo gets instantiated with TRACKING_ENDED, what would work fine.

RunDo/rundo/src/main/java/com/werdpressed/partisan/rundo/RunDoSupport.java

Lines 33 to 41 in 7b2bde8

	public RunDoSupport() {
	mHandler = new Handler();
	mRunnable = new WriteToArrayDequeRunnable(this);
	countdownTimerLength = DEFAULT_TIMER_LENGTH;
	queueSize = DEFAULT_QUEUE_SIZE;
	trackingState = TRACKING_ENDED;
	}

But when resuming, it is set on TRACKING_STARTED, leaving RunDo in a somewhat illegal state.

Need to press multiple times before undo/redo happens

Sometimes when I undo, I need to do it a couple times before it happens (2-4 times) Only the cursor moves but the text doesn't change. Is this normal?

Get queue size

How can I get queue size? I want to use it to disable the undo and redo buttons when queue is empty.

Fix ReadMe image, broken link

The link is broken. And the tinypic fallback looks very sad. Please fix or remove the broken link.

Use on view extending EditText

How can I use this on my view which extends EditText? I can't return EditText on getEditText() method because it isn't one.

multi EditText support

you suppose i have 3 EditText on xml layout, how can i attach RunDo on one of them?