ppy / osu-web Goto Github PK
View Code? Open in Web Editor NEWthe browser-facing portion of osu!
Home Page: https://osu.ppy.sh
License: GNU Affero General Public License v3.0
the browser-facing portion of osu!
Home Page: https://osu.ppy.sh
License: GNU Affero General Public License v3.0
When you execute the instructions to create a new user on the README, it will do so without any problems. You can login and your nick will appear in the respective part.
However, user_id with values 0 and 1 will fail (binary comparison with integers?), and if you go to the userpage it will give an exception ( https://gist.github.com/comentarinformal/42f94d68232fe63b47dd ).
If you manually edit your user_id value in the mysql database to 2,3, or anything, it will work as expected, showing the usual jizz profile.
From this thread: https://osu.ppy.sh/forum/t/94891
What is the standart pass and username for mysql?
For the last 45 minutes I've been trying to pull request just one commit, followed a lot of guides but just can't seem to get it.
This is my fork of osu-web: https://github.com/MasterBugPatch/osu-web
I'm trying to pull request only 4294e82 to here.
Anybody can guide me on how I would go about doing that?
For Marcin
Pages:
Things to consider:
We are looking to create graphs like this in the profile section (and other places on the site).
As a test of how I want to move forward with development, I'm creating this issue as an open request. Whoever completed it will be rewarded (supporter tag / merchandise / money, not finalised yet but we'll figure it out).
What needs to be done:
Your code should make it easy for us to hook up the input data to the graph.
Bounty offered: 60
We've decided it looks better at ~80% rather than completely black.
Bounty offered: 1
As I (not so) recently learned, I've been violating a lot of efficient css guidelines. I've been trying to reduce the problem by implementing BEM in a few places but it's still pretty much over my head (and I think I did it incorrectly).
At least newly written CSS should conform the guidelines and going forward a major rewrite will save a lot of headaches (or so I hope).
Another thing is it's slightly easier doing BEM with LESS (which I just discovered last week):
.block {
...
&__element { ... } // will turn into .block__element
&--modifier { ... } // will turn into .block--modifier
}
Also, all javascripts related classes should always be prefixed with js-
so no one (mainly me) won't accidentally break javascripts by moving/renaming/adding things around.
Lastly, visiting the site shouldn't double as system stability test (store products listing page, for example, causes my laptop to go on fire by having it open for a while).
tl;dr: I suck at CSS. Someone pls2halp.
Was thinking of a feature which will make you being able to login when replying to a topic if not logged in.(If scrolled all the way down to the bottom of a thread). I was thinking of hopefully clicking a guest avat box in the reply prompt would open the login prompt to login and continue where we was last positioned
Would be possibly easier to login if scrolled all the way to the bottom without access the to the top header (without clicking the fast scroll button I guess)
I tried running this but i keep getting http://puu.sh/kCmcM/6a26689188.png and everything is working also i found out the VM is 64-bit and my PC doesn't support 64 bit os'es on Virtualbox it only uses 32-bit how could i use a 32-bit os on this!?
Trialling some larger bounties. This one involves implementing a design concept fully.
This is a stand-alone status page, which will be replacing http://stat.ppy.sh
Requirements:
Bounty offered: 350 (+150 for complete ready-to-connect React implementation with placeholder jsx datasource)
As per bounty guidelines, it is recommended that you claim this issue if you are serious about it.
If you are going to react it up, make sure to check out the profile page implementation for examples to follow.
Ask away for further clarifications.
The base62_encode
function has a very small bug in it, but I thought I'd mention it. If you call base62_encode(0);
it will return an empty string, and I assume that is not what you want. A simple fix is to use a do-while loop instead of a while loop, like so:
function base62_encode($input)
{
$numbers = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
$base = strlen($numbers);
$output = '';
$remaining = $input;
do
{
$output = $numbers[($remaining % $base)].$output;
$remaining = floor($remaining / $base);
} while ($remaining > 0);
return $output;
}
In the header of the osu!store, there's this back button...which, as you might think, should get you back to the frontpage of the store.
And well, it does, but only if you were on the frontpage before.
If not, the back button is still shown, but doesn't work as there is no history present you could jump back to.
Best way to reproducing this is visiting the store over ppy's last blogpost (just click on "available" in the first list item)
Not really a big issue, it might just confuse people because it does nothing at that state.
As Sulker@Slack noticed, nicks bigger than the current limit will get cut off on jizz forums, looking quite bad.
Short-term solution is easy: change the infobox from 120px to 140px. I don't know if there's people with bigger nicks than me, and if it would work in them, though.
As reported by Granger on the forums:
I tried to upload this image but all i got is a empty error message.
The image mentioned (hosted at puu.sh, mirrored here on Github):
How would I go about making a user supporter from the Vagarant SSH?
This has happened to me way too many times: http://puu.sh/kCNBH/ace0ef22a6.mp4
Bounty offered: 5
wiki page template
Trialling some larger bounties. This one involves implementing a design concept fully.
This is the wiki page template, which will be housing wiki articles currently found at http://osu.ppy.sh/wiki/
Requirements:
Bounty offered: 50
As per bounty guidelines, it is recommended that you claim this issue if you are serious about it.
Ask away for further clarifications.
While most of the installation is done automatically by 'vagrant up', there is a file (/vagrant/logs/nginx.log) that is not created, and makes nginx unable to start, making the rest of the installation fail.
When created, the next missing folder is (/data/osu!web/)bootstrap/cache; once you create said folder, the rest of the installation goes without a problem.
(Of course, you can create then yourself via ssh and then vagrant provision, but to set up PuTTY you have to migrate the private key Vagrant generates in puttygen, then save it somewhere, then set it as auth, which greatly differs from the four-steps installation guide.)
Hey, I really think this would be a great feature. By hovering over an image it just shows your cover as that image for a preview. I really wouldn't mind making a pull request for this as I can do it.
This might end up being one of those "oh well we're stuck with it" things, but maybe something can be done about it. The new me! tabs on profiles have a smaller width than their old-web counterparts, causing split-image userpage header graphics to break.
Some images for reference:
This affects the desktop version and the mobile version at certain widths. I have had them appear correctly at some elongated widths in mobile mode, but this should be expected due to it's dynamic width.
To give credit, Sulker on the osu!dev slack found this, and I investigated it further with him. We found one possible solution was to expand the profiles out by 100px on desktop, but this does not fix the issues on mobile.
Right now I'm making changes manually at a database level when a user requests an address or t-shirt design/size changes. We need the ability to edit orders from the admin page (/store/admin/).
Requirements:
Bounty offered: 50
Comment on this thread if you have anything you need from flyte. I'll update the list.
@arflyte ask if unsure about any of these. I'm using this as a place to keep track so you have an idea of what you need to do.
wang wang wang wang wang
If the profile cover image isn't loaded yet it will be completely transparent, showing the page background. This is most apparent when previewing profile covers.
Since it's not quite possible to make everything load instantly every time for everyone, I would like to propose having any grayscale colour (whichever feels best) below the profile cover so that it's not as ugly when this appears.
Edit: This also affects the profile cover on the user card.
The following command fails for when I try to create a user:
hhvm artisan tinker
It throws a run-time error (for me using vagrant on OS X 10.10.4 via the install on the web [vagrant 1.7.4]), which is the following:
Fatal error: unexpected St13runtime_error: locale::facet::_S_create_c_locale name not valid
If I try to go on my profilepage I get a error
http://jizz.ppy.sh/u/Miterosan
Error code: 894ad4018e42432ea371a24af30292c6
Likely bbcode parsing failure: http://jizz.ppy.sh/forum/t/259747?start=3508242#forum-post-3508242
Bounty offered: 4
Currently the live post preview is only visible when creating a new topic. Would be nice to have it when replying also.
Bounty offered: 250
Found an issue - if you repeatedly click on your avatar to show/hide the dialog too fast, the page progressively gets dimmer and dimmer.
Turns out it's a minor issue already in existence (not introduced with my commit) related to the login modal.
Other than that, it doesn't block user experience in general usage. Don't consider it anywhere near important, fix other things first.
When running ./node_modules/.bin/gulp I am getting multiple file not found log entries:
[02:29:21] Merging: resources/assets/js/messages.js
[02:29:21] File not found: bower_components/jquery-ujs/src/rails.js
[02:29:21] File not found: bower_components/jquery-timeago/jquery.timeago.js
[02:29:21] File not found: bower_components/jquery-zoom/jquery.zoom.js
[02:29:21] File not found: bower_components/history.js/scripts/bundled-uncompres
sed/html5/jquery.history.js
[02:29:21] File not found: bower_components/ResponsiveSlides.js/responsiveslides
.js
[02:29:21] gulp-notify: [Error running notifier] Could not send message: not fou
nd: notify-send
[02:29:21] Finished 'scripts' after 250 ms
[02:29:21] Starting 'coffee'...
[02:29:21] Running CoffeeScript: resources/assets/coffee/osu!live.coffee, resour
ces/assets/coffee/osu_common.coffee, resources/assets/coffee/turbolinks-mod.coff
ee, resources/assets/coffee/bbcode.coffee, resources/assets/coffee/main.coffee,
resources/assets/coffee/store.coffee, resources/assets/coffee/forum.coffee, reso
urces/assets/coffee/forum/post-box.coffee, resources/assets/coffee/forum/topic-a
jax.coffee, resources/assets/coffee/ujs-common.coffee, resources/assets/coffee/b
ootstrap-modal.coffee, resources/assets/coffee/login-modal.coffee, resources/ass
ets/coffee/logout.coffee, resources/assets/coffee/shared.coffee
[02:29:22] gulp-notify: [Laravel Elixir] CoffeeScript Compiled!
[02:29:22] Finished 'coffee' after 671 ms
[02:29:22] Starting 'browserify'...
[02:29:22] Running Browserify: ./resources/assets/js/index.js
[02:29:22] Running Browserify: ./resources/assets/js/jsx/modding_react.jsx
[02:29:22] Running Browserify: ./resources/assets/js/jsx/profile_page.jsx
[02:29:22] gulp-notify: [Error in notifier] Error in plugin 'gulp-notify'
not found: notify-send
[02:29:25] Finished 'browserify' after 3.8 s
[02:29:25] Starting 'version'...
[02:29:25] Versioning: public/css/app.css, public/js/app.js, public/js/bundle.js
, public/js/messages.js, public/js/modding_react.js, public/js/react/profile_pag
e.js, public/js/vendor.js
[02:29:25] File not found: public/css/app.css
[02:29:26] Finished 'version' after 220 ms
Bounty offered: 60
As per this report, username changes can show "0 more days" until available. Probably should show "1" in these cases.
Still waiting for more details to pinpoint when this occurs.
Digged up an old request for the forum to have. Basically have it list the users browsing the specific thread along or instead of the list showing which users are browsing the forum section.
https://osu.ppy.sh/forum/t/32252
Trialling some larger bounties. This one involves implementing a design concept fully.
This is the user card and menu, which will appear when you click your avatar/username at the top-right of any page.
Requirements:
Bounty offered: 60
As per bounty guidelines, it is recommended that you claim this issue if you are serious about it.
Ask away for further clarifications.
I found this when trying to create more than one user (with the first one's ID being 0). Now I had it happen trying to add a second address. It says 'failed loading requested page', and examining the error, it says
'QueryException in Connection.php line 638:
SQLSTATE[23000]: Integrity constraint violation: Duplicate entry '0' for key 'PRIMARY' (SQL: insert into osu_store
.addresses
(first_name
, last_name
, street
, city
, state
, zip
, country_code
, phone
, updated_at
, created_at
) values (Test2, TEST2NAME, Street Number 2, Holidays, State, Post Code, No, 666333999, 2015-09-01 22:01:51, 2015-09-01 22:01:51))'
This is probably a matter of a misconfigured key in the database created automatically
Disclaimer: I am a total Laravel noob ATM, so anything I say might be wrong.
While looking through the code, i noticed in App\Models\User.php:
...
public function groups()
{
return $this->hasMany("App\Models\Group");
}
...
and in App\Models\Group.php:
...
public function users()
{
return $this->hasMany("App\Models\User");
}
...
These method names suggest that this was meant to be a many-to-many relationship.
However, in Laravel docs it is stated that you need to implement it like this:
// App/Models/User.php
public function groups()
{
return $this->belongsToMany("App\Models\User");
}
// App/Models/Group.php
public function users()
{
return $this->belongsToMany("App\Models\Group");
}
Right now, I can't seem to add an user to a group using the ORM (i succeeded in doing so by editing the database manually), and I can't add more than one user to a group.
We've had ongoing cases where store addresses are getting trimmed. This happens for some users when they enter a street address or postcode that contains multiple words, where some words are removed completely.
We've added logging to try and track this down, but if anyone has an idea of how this could happen (and can cite in the code where the issue is, or submit a pull request to fix it), that would be pretty cool.
As it has caused a few orders to go missing or returned-to-sender, I'm willing to offer a bounty for a solution to this one.
Note that this does not always happen. It is likely a specific browser or workflow which causes it to trigger.
What needs to be done:
street
/ postcode
(possibly others) fields in osu_store.addresses
occasionally get trimmed.Bounty offered: 50
Creating this issue after these 2 comments on blog.ppy.sh.
There's 2 things I would like to be changed about the user card design.
Changing
transparent linear-gradient(to bottom, rgba(0, 0, 0, 0.5) 0px, rgba(0, 0, 0, 0.75) 100%) repeat scroll 0% 0%
to
transparent linear-gradient(to bottom, rgba(0, 0, 0, 0.35) 0px, rgba(0, 0, 0, 0.35) 100%) repeat scroll 0% 0%
is more or less what I think feels right.
Here's a comparison of the current user card and one where I quickly edited it to my liking, which is the idea I'm proposing here.
Should be a fun task for someone looking to get familiar with the framework.
Bounty offered: 5
The current challange accepted is thin and doesn't look well among other achievements.
It would be really convenient for there sample data for people working on the site. When people clone the repo it should available from the get-go. Preferably already on the site too, and not just in the DB.
Looking for:
Images are scale-to-fit width (similar to old forum) but there's no way to expand them out.
Either click-to-expand (in-line, similar to old forum, seemed to work well) or click to load in new tab/lihgtbox.
I'm a fan of the expand in-line since it doesn't break the UX.
Missing the Netherlands Antilles flag (https://jizz.ppy.sh/images/flags/AN.png)
A product in the store has a json-encoded list of image URLs added to its images_json column (tried with ["https://upload.wikimedia.org/wikipedia/en/c/c7/GlennRhee.jpg"] and ["http://lorempixel.com/500/500/?76327","http://lorempixel.com/500/500/?34281","http://lorempixel.com/500/500/?36519"] )
When loading the page of said product, a 'Read error!' will stop it from working.Full stack
By the mentioned line, I guess it's a problem with getting the image size cached
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.