pqina/filepond-plugin-image-crop

🖼 Add image crop instructions to files dropped on FilePond

filepond-plugin-image-crop's Issues

TIFF uploads are broken when plugin is active

The crop plugin seems to break TIFF uploads. When enabled and adding a TIFF file (image/tiff) I'm getting an "Uncaught (in promise)" error triggered on line 263. Could it be that loadImage(url).then(function(image) { cannot actually handle TIFF files?

Incorrect peer dependency

Hey guys. I've got this kind of warning just now.
How to reproduce:

yarn add filepond-plugin-image-crop

In results output:

warning " > [email protected]" has incorrect peer dependency "filepond@^3.0.0".

In the package.json of this plugin we have:

"peerDependencies": {"filepond": "^3.0.0"}

Which obviously (if there is no version related issues) should be changed to:

"peerDependencies": {"filepond": ">=3.x <5.x"}

Like in other plugins.

Option to turn off processing after setting crop

Background

I'm trying to integrate filepond in an existing project where there is a crop center being set externally. Practically, the image should not be cropped and so I don't have the transform plugin enabled. When the crop center is set, I call file.setImageCropCenter({...}) to reflect in the preview properly which works great.

Problem

The problem is that it also tries to upload the newly cropped image (which is not really cropped) to the server again. I understand why you would want this when coupled with the transform plugin but I just want the preview.

A few things I've tried:

• Turning off instantUpload. I don't want this behavior though so this isn't an option
• Checking the x & y positions in the process method and short circuiting if they both equal 0.5
  • This behavior isn't so bad but it seems really brittle

Proposal

Adding a flag like uploadOnCrop or something.

I'd be happy to submit a PR for this but I'm a little lost looking through the source code where the call to process is from this plugin 🤷