pqina/snippy

🍡 Quickly create your own custom shortcodes

Snippy WordPress Shortcode Builder

Use Snippy to create custom shortcodes. Upload files and create HTML, CSS and JavaScript snippets which then can be combined in your own shortcode.

Download Snippy

How to setup a JavaScript Countdown plugin on WordPress using Snippy.

snippy's Issues

Including 'placeholders.php' file, but it doesn't exist

Starting 6 hours ago (with 1.3.0), snippy.php tries to include 'placeholders.php' which was deleted from the repository. This causes a 500 server error

Including admin JS results in Javascript errors on page/post edit screens

Admin JS file is better enqueued conditionally.

Solution below

snippy.php, line 213:

public function register_admin_scripts($hook) {

    if( 'snippy_page_snippy_edit_bit' != $hook && 'snippy_page_snippy_edit_shortcode' != $hook ) {
        return;
    }

    \wp_enqueue_style( 'snippy-admin-styles', \plugin_dir_url( __FILE__ ) . 'admin/css/style.css', array(), Snippy::$version );
    \wp_enqueue_script( 'snippy-admin-scripts', \plugin_dir_url( __FILE__ ) . 'admin/js/script.js', array(), Snippy::$version, true );

}

No placeholders results in PHP error

When using a bit without any attributes (ie: [my_shortcode]), it displays the following:

Warning: array_merge(): Argument #1 is not an array in /.../wp-content/plugins/snippy/snippy.php on line 304
Warning: array_merge(): Argument #1 is not an array in /.../wp-content/plugins/snippy/snippy.php on line 307

Per the shortcode documentation "$atts - an associative array of attributes, or an empty string if no attributes are given" ( Shortcode API ) hence it's wrong to consider that $atts will always be an array. Since attributes are optional (ie: [my_shortcode] ), atts can be a blank string.

Adding this on line 304 fixes the issue

if (!is_array($atts)) $atts = array();

above these sections.

This started only since the last update.