pragdave/e4p-code

Code for the course "Elixir for Programmers"

e4p-code's Issues

Consider putting tally/1 into module Hangman

Hi,

at the end of the chapter (checkpoint 050-start-hangman-complete) you have suggested moving make_move/2 directly under public API module Hangman. Following the same logic, I would suggest that tally/1 should be also there. So the code would read

defmodule Hangman do
  alias Hangman.Game

  defdelegate new_game(), to: Game

  def make_move(game, guess) do
    game = Game.make_move(game, guess)
    { game, tally(game)}
  end

  def tally(game) do
    %{
      game_state: game.game_state,
      turns_left: game.turns_left,
      letters:    game.letters |> reveal_guessed(game.used),
    }
  end

  ############################################################################

  defp reveal_guessed(letters, used) do
    letters |> Enum.map(fn letter -> reveal_letter(letter, MapSet.member?(used, letter)) end)
  end

  defp reveal_letter(letter, _in_word = true), do: letter
  defp reveal_letter(_letter, _not_in_word), do: "_"

end

I've put the reveal_guessed there as well as it seems as a transform function which is used to create a public API (sort of view functionality).

Honestly, I am not really sure if I like it :)

Separated ecto application supervisor strategy

I have a situation where my phoenix layer connects to a postgres ecto layer before connecting to the postgres database. Should the postgres ecto layer supervisor strategy be a simple_one_for_one? Why or why not?

Question about

Hangman application supervisor

It Probably runs the error

:simple_one_for_one strategy is deprecated, please use DynamicSupervisor instead

Please update the course to actual versions.

Where's the code ?

Hi Dave, first off thanks for the awesome course.

Just wondering: what happened to the code?

Plenty of links in the course still lead to this repo.

Question about Genservers and Agents

I understand why you used an Agent to handle state in the Dictionary application.

What I don't understand is why you chose to use Genserver to manage state in the Hangman application. Why didn't you use Agents if they can also get the job done?

Supervisor code deprecated?

According to the docs it says this code is deprecated, but I'm still wrapping my head around the new actual code

https://hexdocs.pm/elixir/Supervisor.html