prcwiek/pmetar

Processing METAR weather reports package

pmetar's Issues

metar_decode command can't handle large data

Hi,
i want to decode a station metar data with the "metar_decode" command. when i run it over a short period (less than a year) i works fine, but when i want 3 or 4 years period the package returns an error :
"pmetar package error: it is not a metar weather report!"
while it is really a weather report. I used the following code:
NFTL<-metar_get_historical("NFTL", start_date = "2021-01-01", end_date = "2021-12-01", from = "iastate")
decoded_NFTL <- metar_decode(NFTL, metric = TRUE, altimeter = FALSE)

Temperature parsed as -273 degrees

The following parses the temperature as -273 degrees:

x <- "201905070355 METAR KDCA 070355Z AUTO 20005KT 10SM CLR A3010 RMK T0180 MADISHF"
df <- metar_decode(x, as_data_frame = TRUE)

metar_decode function error when using large datasets

Hi. First of all, thank you so much for your work.

I'm having an issue with the metar_decode function. The function works well when I use this function for a relatively small dataset (I mean a year of data for one airport). However, when I tried to use it with a bigger data sample (more than a year), an error displayed with the following sentence "Error: pmetar package error: Incorrect METAR weather report found and cannot be decoded!"

It is essential to mention that I also use the function metar_is_correct (and remove the incorrect data) before using the decode function.

Thanks!

message: `data_frame()` is deprecated as of tibble 1.1.0. Please use `tibble()` instead.

Hi.
Please update the syntax used in pmetar::metar_location.

Visibility parsed as NA when it shouldn't be

In the following, visibility is parsed as NA when the original METAR says 4 statute miles ("4SM"):

x <- "201905041400 METAR KDCA 041400Z AUTO 07004KT 4SM HZ OVC009 20/17 A2987 RMK T02000170 MADISHF"
df <- metar_decode(x, as_data_frame = TRUE)

In the following, visibility is parsed as 1 when the original METAR says "1 3/4 SM":

x <- "201905121244 METAR KDCA 121244Z 05010KT 1 3/4SM R01/6000VP6000FT -RA BR OVC007 14/12 A2978 RMK AO2 P0002 T01390122"
df <- metar_decode(x, as_data_frame = TRUE)

CRAN check

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_pmetar.html.

Please correct before 2021-11-12 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message
if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

Problems with downloading historical data from the Ogimet server

Problems appears on Windows. with downloading data from the Ogimet server with metar_get_historical. On linux, Xubuntu, the downloading works correctly.