pressbooks/pressbooks-jacobs

This theme is named after American-Canadian activist, journalist, and author Jane Jacobs, who is responsible for the New Urbanism movement in urban studies. It is designed for academic writing, particularly textbooks, but is also suitable for fiction. Headings and body type are set in Montserrat.

Jacobs

This theme is named after American-Canadian activist, journalist, and author Jane Jacobs, who is responsible for the New Urbanism movement in urban studies. It is designed for academic writing, particularly textbooks, but is also suitable for fiction. Headings and body type are set in Montserrat.

Requirements

• PHP >= 7.1
• WordPress >= 5.2.4
• Pressbooks >= 5.9.5
• McLuhan >= 2.8.12

Installation

Manual

Download the latest release and unzip the contents to WP_CONTENT_DIR . '/themes/pressbooks-jacobs/'.

Composer

From within your WordPress or Bedrock root directory, run:

composer require pressbooks/pressbooks-jacobs

GitHub Updater

Install the GitHub Updater plugin.

Then, from the GitHub Updater interface, navigate to the "Install Theme" tab. Enter https://github.com/pressbooks/pressbooks-jacobs as the Theme URI, then click "Install Theme". Tagged updates to this theme will then be available as normal WordPress updates.

Changelog

Please see the CHANGELOG file for more information.

pressbooks-jacobs's Issues

Improve type scale for headings 1-6

Prerequisites

• Can you reproduce the behavior you wish to address with all plugins except Pressbooks deactivated?
• Are you running the latest version of Pressbooks, the latest version of McLuhan, the latest version of this book theme and the latest version of WordPress?
• Are you experiencing the issue while using this book theme?
• Did you perform a cursory search to see if your bug or enhancement is already listed?

Description

As reported by @pbstudent at https://discourse.pressbooks.org/t/mcluhan-heading-styles/609/13.

Steps to Reproduce

Not applicable.

System Information

Jacobs: 1.1.1
McLuhan: 2.5.0

Table classes don't display in export formats for Jacobs theme

Description

Borders or lines for table classes don't export to PDF or ebook formats when users have selected the Jacobs theme. No tables, including "full grid" and "lines" tables, have any borders or lines. The tables do appear to still have background colors per their class, however.

How tables appear in the webbook (correct):

How tables appear in the PDF (incorrect):

Example: https://jacobsthemetables.textopress.com

Steps to Reproduce

1. Create a new chapter in your book and add a table
2. Click inside the table, then select the table icon from the visual editor and go to the Table Properties menu
3. Select a class (ex: full grid) from the Class dropdown menu
4. Save changes to settings and for the chapter
5. Export to PDF and EPUB

Expected behavior: Tables which have classes designed with borders and lines still have those borders in export formats

Actual behavior: Tables in the Jacobs theme do not have borders and lines in export formats

EPUB and PDF: Captions on small alignnone images have differing width than image.

Description

Caption on these images should break at the same width as the image it is under but does not.

'Before' pdf:

'After' pdf (Page 185):

Content breaks to next page on "Tracking Comparisons" chapter

Description

In "Tracking Comparisons" chapter, the content breaks to next page after the "Tests" header on both 'Before' and 'After' pdf's.

Steps to Reproduce

1. Navigate to page 61 on 'Before' and 60 on 'After' pdf's
2. Scroll to 'Tests' header

Alignment on images align-none should be automatically centered

Description

Align-none images align to the left on 'After' pdf but centered on 'Before' pdf.

TOC part title bottom margin

Description

Add $toc-part-title-margin-bottom spacing to match 'Before' pdf.

Steps to Reproduce

1. Navigate to TOC on both 'Before' and 'After' pdf's and compare

MOBI: Left and Right aligned image margins

Description

Left and right aligned images (both big and small, with and without captions) need updated margins.

Steps to Reproduce

1. Navigate to 'Part V: Images' in 'After' MOBI and look for left and right aligned images in any chapter

PDF/MOBI: Content breaks to next page on "Tracking Comparisons" chapter

Description

In "Tracking Comparisons" chapter (chapter 9), the content breaks to next page after the "Tests" header on both 'Before' and 'After' pdf's.

Steps to Reproduce

1. Navigate to page 64 on 'Before' and 'After' pdf's
2. Scroll to 'Tests' Header

MOBI: Small image (alignnone) is centered

Description

Small image (alignnone) is centered.

Steps to Reproduce

1. Navigate to chapter 42 and go to the next page

EPUB: Big images (align-none and centered) too large

Description

On EPUB, big images that are 'align-none' and 'centered' take up whole page in newer EPUB. This causes captions on big images to be pushed to the next page rather than being directly under the image.

Steps to Reproduce

1. Navigate to chapters 40 and 41 and compare images in 'Before' and 'After' EPUBs

Left and right aligned small images are larger than expected

Description

Left and right aligned small images (with and without captions) are displaying too large.

Steps to Reproduce

1. Navigate page 183 on 'After' pdf and page 181 on 'Before' pdf
2. Compare left aligned images and right aligned images

Add screenshot

Prerequisites

• Can you reproduce the behavior you wish to address with all plugins except Pressbooks deactivated?
• Are you running the latest version of Pressbooks, the latest version of Pressbooks Book, the latest version of this book theme and the latest version of WordPress?
• Are you experiencing the issue while using this book theme?
• Did you perform a cursory search to see if your bug or enhancement is already listed?

Description

Add a screenshot.

Steps to Reproduce

Not applicable.

System Information

Jacobs: 1.0-dev

EPUB/MOBI: TOC styling updates

Description

• Add top margin to TOC front matter titles
• Add top margin to TOC chapter titles
• Add TOC page margins
• TOC chapter subtitle text-transform: Set to Italic
• TOC chapter author text-transform: Set to Italic
• MOBI: TOC chapter title font-family needs to be changed

Before:

After:

Add sidebar textbox support

Page numbers should be on the outside corner, not the inside

Prerequisites

• Can you reproduce the behavior you wish to address with all plugins except Pressbooks deactivated?
• Are you running the latest version of Pressbooks, the latest version of McLuhan, the latest version of this book theme and the latest version of WordPress?
• Are you experiencing the issue while using this book theme?
• Did you perform a cursory search to see if your bug or enhancement is already listed?

Description

Like the title says.

Steps to Reproduce

Not applicable.

System Information

Jacobs: 1.1.1

Add floating image caption support

EPUB: Small centered images are not centered

Description

Small centered images are not centered (no caption and with link)

MOBI: Small image captions are not staying within the same width as their image

Description

Small image captions are not staying within the same width as their image

Example:

MOBI: Dropcaps not working

Description

Dropcaps not working.

Steps to Reproduce

1. Navigate to Chapter 2

Add compatility with wrapped headings

Prerequisites

• Can you reproduce the behavior you wish to address with all plugins except Pressbooks deactivated?
• Are you running the latest version of Pressbooks, the latest version of Pressbooks Book, the latest version of this book theme and the latest version of WordPress?
• Are you experiencing the issue while using this book theme?
• Did you perform a cursory search to see if your bug or enhancement is already listed?

Description

See pressbooks/pressbooks#1045.

Steps to Reproduce

Not applicable.

System Information

Jacobs: 1.0-alpha.1

Issues with inheritance re: table paragraph styling

Old Asana ticket:

We've got a book using the Jacobs theme and have noticed some strangeness inside of tables. What's happening is that inside of a table cell we've hit a hard return--the WYWSIWYG will then create a paragraph inside of the table cell. The problem is that the CSS for p elements is being applied rather than the CSS for table text. In this case, I think it could be fixed with some simple CSS, namely:

front-matter table p, .part table p, .chapter table p, .back-matter table p, body#tinymce.wp-editor table p {font-size: inherit; line-height: inherit;}

In this case the CSS for the table element (lines 439-454 of the style.css file) are setting the font-size to .9em and line height to 1.1em, but the paragraph element has a font-size value of 1.125rem and a line-height of 1.5; For now, we can put these rules (or similar ones) in place locally, but I wanted to flag them for a standard, uniform fix by whomever is working on theme improvements

PDF/EPUB/MOBI: Font size too large in textbox header

Description

Font size should be smaller on $textbox-header-font-size variable.

Steps to Reproduce

1.Navigate to page 102 on 'Before' and 'After' pdf's and scroll to textbox on bottom of the page
2. Compare textbox header size

Edu-textbox list margins

Description

In 'After' pdf, the left margin is too large and the top and bottom margins are too small.

Steps to Reproduce

1. Navigate to page 106 in both 'Before' and 'After pdf's and compare EDU textbox lists

EPUB/PDF/MOBI: Remove top and bottom borders on pullquotes

MOBI: Table not staying within the page width

Description

Table not staying within the page width.