Comments (8)
The sellstrom is displayed in the same way as it is being designed. Could you please let me know if there are any design guidelines or changes that I need to do here?
Also, in the screenshot I noticed that you have a message: looks like we got no XML document. This is an error message from the server side. Could you please let me know what steps you followed to get the message?
from sellstrom.
I get the message "looks like we got no XML document" when I click on "Create label". On a fresh install I just wrote my credentials on the settings page and made an order by selecting SellStrom.
About the original issue, you can see what what I'm talking about on the following screenshot:
Your box is not designed like the other ones. Maybe you should use bootstrap classes to make it look better on 1.6.
On PrestaShop 1.5, the look is better. But you should remove the tags <br/><br/>
to remove this big space.
from sellstrom.
I have fixed the original design on my local environment. For the second issue, "looks like we got no XML document", I believe you are trying to create a label for Stamps. Could you please let me know if you have phone number defined for the from address? It would be great if you can provide me the screenshot of the Sellstrom configure page. I believe we might need to put a validation from phone address before actually going to create the label because for Stamps, it is returning the SOAP Fault error because of the same. My configuration of the From address looks like the following:
from sellstrom.
Hi,
A phone number was already set for my shop, so I guess the issue did not come from that. But it was a French one, so I modified everything to get an American address.
But nothing changed ...
Here is my Store contacts:
PS : If the changes are done for the design, can you please commit them ?
from sellstrom.
I have committed the new changes in version 0.1.1. Please verify.
from sellstrom.
In my opinion it still can be improved by removing the <legend>
tags.
But now this is the 1.5 version which meet some issues.
Can you generate the properly box depending of the PS version ?
from sellstrom.
I have fixed the issue for Prestashop 1.5. Please verify.
from sellstrom.
I added some changes to fix this issue, as you can see on the commit 2ce31e2.
- I moved the
<legend>
tags of the title only for PrestaShop 1.5 - I removed a
/
which was already present in the variablecontentData.presta_base_dir
. Without it, the shipping icon would never be shown.
Anyway, I close this issue and I send your module to the security review.
from sellstrom.
Related Issues (9)
- Checks missing in label.php HOT 2
- SellStrom panel should not appear on Order details page
- Comments for sellstrom.php HOT 2
- Carrier list is not properly shown HOT 2
- Notice HOT 3
- Small design issue in settings page on PrestaShop 1.5
- minor security fix HOT 1
- Notices on "add to cart" with SellStrom HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sellstrom.