Giter Site home page Giter Site logo

sellstrom's Introduction

Sellstromship

Sellstrom Shipping Module for PrestaShop


Update October 31, 2014

  • Current Module version: 0.1.0

Update November 28, 2014

Issues fixed:

  • #7: minor security fix

Update November 17, 2014

Current Module version: 0.1.1. Issues fixed:

  • #1: Checks missing in label.php
  • #2: Comments for sellstrom.php
  • #4: Removed the unused $session_id variable to avoid the Notices
  • #5: Design on order page
  • #6: Small design issue in settings page on PrestaShop 1.5

Update February 11, 2015

Current Module version: 0.1.2.

New functionality added:

  • #1: Create Invoice
  • #2: Add Insurance

Issues fixed:

  • #8: Notices on add to cart with SellStrom

sellstrom's People

Contributors

prantikdasgupta avatar quetzacoalt91 avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sellstrom's Issues

Checks missing in label.php

In the file /label.php, you should add some tests before executing the requests.

In example:

if (Tools::getIsset('id_order') && Tools::getIsset('secure_key') && Tools::getIsset('id_tracking'))

Notice

When I am on the settings page, or on a order, I meet the following notice:
capture du 2014-11-07 10 10 21

And when I am on an order page not related to sellstrom, I get these ones:
capture du 2014-11-07 10 34 32
You should check in your hookDisplayOrderDetail if the concerned carrier is yours.

Comments for sellstrom.php

Here are a few comments for /sellstrom.php:

  • function hookDisplayOrderDetail():
  • function hookBackOfficeHeader():
  • function hookHeader():
    • HTML code must be moved in a tpl file
  • General: You should remove all commented HelperP::log(...) in you code for the release.
  • l.833: What this test is supposed to do ?

Design on order page

On the order details on PrestaShop 1.6, I have the following box from Sellstrom.

It seems to be not designed. Is it really what you expected ?
capture du 2014-11-07 10 37 19

SellStrom panel should not appear on Order details page

On the Back Office, you made the following panel to create labels for the new orders:
capture du 2015-03-17 11 31 52

But you should not display it when the carrier selected is not one of yours. Because if every module does not make this test, the page will be fulfilled by panels which won't be used.

Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.