'Reviewers can see other reviews' setting doesn't seem to have any effect

[skryukova]

'Reviewers can see other reviews' setting doesn't seem to have any effect

[rixx]

pretalx always applies the broadest possible permissions it can apply – if you have more permissions than just reviewer permissions, you'll always be able to access additional data. The "can see other reviews" permission is only applied to people who are just reviewers, i.e. who don't have permissions in addition to the reviewer permission.

[skryukova]

I understand that. However, my team members who are not administrators, and only have "reviewer" permissions are still able to see the reviews by other people.

For example, user with just "Is a reviewer" checkbox checked, can still see every review, every score. They are just not able to see the names of the other reviewers or average score.

If I add "Can work with and change proposals" to that role, the users can also see the names of the other reviewers and the average scores.

That does not seem like an intended behavior to me.

[rixx]

I cannot reproduce this bug at all. I created a new user, and added them to a team with exactly just the reviewer permission. The review phase is configured like this:

The review user is not able to see any reviews, neither before nor after submitting their review – they see only their own review:

In contrast, the organiser user can see this new review as well as all other reviews:

If changing the setting has no effect at all, then one of these must be true:

• your reviewers are part of some team that grants them additional permissions
• you're not in the review phase that you think you're in
• you're running different code than the current release or current development branch (though I don't think we had a bug related to this in ages)

It's impossible to know what's going on without further information, sorry – I hope showing a complete configuration/reproduction in my screenshots above is helpful in figuring out what's going on.