Giter Site home page Giter Site logo

Comments (8)

glyph avatar glyph commented on June 24, 2024 1
  1. Could you expand on the critical step, 'Go to the "register" link'? Do you mean that you click the "login" link in the upper right-hand corner, or that you follow the CfP (multi-step) form and eventually are asked to log in or register?

The login link in the upper right hand corner is the one I just experienced.

from pretalx.

rixx avatar rixx commented on June 24, 2024 1

A quick fix to avoid this frustration might be to add a speedbump on any navigation away from the page, "are you sure you don't want to save first"

This exists in pretalx as of the last release, as per #1107 – the instance we're (probably? nbpy?) talking about is lagging by a year / two big releases atm, not much I can do there, sadly.

from pretalx.

rixx avatar rixx commented on June 24, 2024

Hm, yeah, that sucks. Two questions to figure out how to proceed:

  1. Could you expand on the critical step, 'Go to the "register" link'? Do you mean that you click the "login" link in the upper right-hand corner, or that you follow the CfP (multi-step) form and eventually are asked to log in or register?
    The reason I'm asking is that these are two very distinct bug reports – we extensively test for the latter, as that's the expected workflow. It's meant to give users a (seamless-ish?) way to log in or register while in the process of filling in their proposal information.
  2. What do you mean by "Come back to see the site blanked out." – by "blanked out" you mean empty form fields, not a white page, right? Did you open the login/registration form in a separate tab and switched back to the previous one? On page reload, are you thrown back to the first form of the CfP? Or did you log in then navigate back in the browser (which I could see leading to CSRF errors, hm).

Things I just tested manually:

  • Submit first form, be directed to login/register page, log in, continue: works.
  • Submit first form, be directed to login/register page, open other login page in separate tab, log in, reload page. See 404 (not ideal!), but on using browser navs to go back a step to the first form and hard-reloading, all info is still there.
  • Start filling in first form, do not submit, log in in separate tab, then submit form in first tab: Get CSRF error. Navigating back with browser navigation shows me the previously entered data, and soft refresh retains the data, but that's browser dependent behaviour – Firefox keeps form data across soft refresh, Chrome doesn't.
  • Start filling in first form, do not submit, log in in separate tab, refresh: data is lost or not as above depending on browser behaviour.

I feel like forms being emptied of data when reloading without submitting is right on the edge of "expected, correct behaviour, do not mess with it" and "annoying af, do magic with localstorage to prevent". (Any data loss following a form submit is definitely a bug and needs to be treated as such of course.) I do think we need to err on the side of messing with JavaScript and LocalStorage, as much as it pains me, because this isn't the first time I've heard people complain of this, and being useful is more important than being correct etc etc.

from pretalx.

glyph avatar glyph commented on June 24, 2024

2. What do you mean by "Come back to see the site blanked out." – by "blanked out" you mean empty form fields, not a white page, right? Did you open the login/registration form in a separate tab and switched back to the previous one? On page reload, are you thrown back to the first form of the CfP? Or did you log in then navigate back in the browser (which I could see leading to CSRF errors, hm).

Yes, empty form fields. I did not open a new tab; just clicked the link, then ended up on the blank form, hit "back" to see if the state was saved in my page history, and it still wasn't, that one was blank as well.

from pretalx.

glyph avatar glyph commented on June 24, 2024

I feel like forms being emptied of data when reloading without submitting is right on the edge of "expected, correct behaviour, do not mess with it" and "annoying af, do magic with localstorage to prevent". (Any data loss following a form submit is definitely a bug and needs to be treated as such of course.) I do think we need to err on the side of messing with JavaScript and LocalStorage, as much as it pains me, because this isn't the first time I've heard people complain of this, and being useful is more important than being correct etc etc.

Thanks, yeah, I think the LocalStorage option is the one I'd like to see.

(Is PyScript at the point where you could avoid JavaScript, I wonder? Or would that destroy page load performance? :))

from pretalx.

glyph avatar glyph commented on June 24, 2024

A quick fix to avoid this frustration might be to add a speedbump on any navigation away from the page, "are you sure you don't want to save first", but a nice background autosave would be preferable.

from pretalx.

glyph avatar glyph commented on June 24, 2024

the instance we're (probably? nbpy?) talking about

good guess :)

from pretalx.

glyph avatar glyph commented on June 24, 2024

To be fair I have experienced this problem on PyCon several times as well. Glad to know that the speedbump exists.

from pretalx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.