slow performance. How long should it take?

[prettier]

slow performance. How long should it take?

[github-actions]

Stale issue

[Hatko]

While investigating a slow performance of eslint, I found that the most time of what it takes is prettier/prettier:

TIMING=1 yarn lint

[tony]

[osdiab]

For anyone looking for workarounds, if you just run prettier directly instead of running it through ESLint, it runs dramatically faster.

This is what I do in package.json, using TypeScript with create-react-app:

{
  "scripts": {
    "eslint": "eslint --ext \"js,ts,jsx,tsx\" ./src",
    "prettier": "prettier \"src/**/*.{ts,tsx,js,jsx}\"",
    "lint": "yarn prettier --check && yarn eslint",
    "lint:fix": "yarn prettier --write && yarn eslint --fix"
  }
}

[stavalfi]

something is eating my machine:

 p/dancer $$ TIMING=1 yarn eslint --max-warnings 0 'packages/dancer-feed-db-api/**/*.{ts,js,json,d.ts}' --cache --fix                                                                                                                                                   932ms
yarn run v1.22.4
$ /Users/stavalfi-dev/projects/dancer/node_modules/.bin/eslint --max-warnings 0 'packages/dancer-feed-db-api/**/*.{ts,js,json,d.ts}' --cache --fix
Rule                                       | Time (ms) | Relative
:------------------------------------------|----------:|--------:
prettier/prettier                          |  2087.620 |    94.5%
unused-imports/no-unused-imports           |    19.940 |     0.9%
no-redeclare                               |    11.459 |     0.5%
@typescript-eslint/type-annotation-spacing |     6.720 |     0.3%
jest/no-identical-title                    |     5.282 |     0.2%
json/*                                     |     4.064 |     0.2%
no-misleading-character-class              |     4.025 |     0.2%
no-regex-spaces                            |     3.994 |     0.2%
@typescript-eslint/no-use-before-define    |     3.934 |     0.2%
no-empty-character-class                   |     3.763 |     0.2%
Rule | Time (ms) | Relative
:----|----------:|--------:
✨  Done in 316.94s.     <<<<<<<<<<<<<<------------------- WTF??!

• with eslint_d i reduced the time to be 60 seconds (but all the files were already fixed with the first command so maybe this test doesn't say much)

[firebluetom2]

Seeing similar

[stavalfi]

in my case, it was extrimly slow because I worked in a monorepo (with yarn) and each package had huge node_module.

I forced that all packages has the exact same version of all dependnecies so all the packages's node_module folders become almost empty (all the installations moved to the root node_module).

I reduced the lint duration from 316 seconds to 50 seconds.

still slow as hell but good enough for now.

[kentcdodds]

Yes, prettier-eslint is fairly slow. But it shouldn't be that show (unless your file is huge or your computer is underpowered). There hasn't been a lot of effort to optimize prettier-eslint though. Would you like to look into it to try and optimize things?

[jeffwillette]

I'm afraid im not too good with the newer javascript ecosystem but I can take a look. Can you think of anything (I might have goofed something simple) that would make the process run so slow? It is a regular react project created with create-react-app so I do not think that the project size is an issue

[kentcdodds]

You might try some of the tips in the troubleshooting guide 😄

[osdiab]

I'm also experiencing this (though for me its not the only one):

[sefabaser]

Suffering from the same issue.

[hpetev]

I noticed that this happens on saving even on a very small file like this one:

it("should pass", () => {
  expect(true).toEqual(true);
});

when a I save package.json before that getting an error: Saving 'package.json': Running 'Prettier - Code formatter' Formatter (configure). Then it becomes slow on all the files. After restart/reinstall starts working fast again until package.json is saved again.

[tony]

I'm in the same boat - on the other hand - I'm hoping someone does a Golang/Rust alternative for eslint, in general. It's just too slow, even with prettier disabled. Even on simple typescript codebases.

While this doesn't build/work yet, following this: deno lint

[jiacai2050]

https://www.reddit.com/r/neovim/comments/mrep3l/speedup_your_prettier_formatting_using_prettierd/

Prettierd seems a possible solution.