DataExporter: Make the ExporterUtils.getColumnValue method overridable

[stolp]

DataExporter: Make the ExporterUtils.getColumnValue method overridable

[stolp]

I also have this issue with DataTableExporter:

    protected void exportRow(FacesContext context, DataTable table, int rowIndex) {
        if (rowIndex != NO_ROW_INDEX_REQUIRED) {
            table.setRowIndex(rowIndex);
            if (!table.isRowAvailable()) {
                return;
            }
        }

        super.addCells(context, table);
    }

This should be addCells(context, table); at the end of the method instead, to make the addCells method effectivly overwritable.

[Rapster]

I'll most probably deprecate ExporterUtils and put everything back in TableExporter 😢

[stolp]

I still have a suggestion for improving this:

I think it would be beneficial if utility methods in TableExporter were protected, so users can override them individually.

Right now, to have a custom implementation of getComponentValue(), I have to override both getColumnValue() and addCells() as well.

Or am I missing something? Sorry for not having noticed that during review.

[Rapster]

They're all public or protected, what am I missing?

[stolp]

Right. My excuses, I was apparently overthinking this.

It is good enough as it is I guess.