Comments (7)
Hey @TylerJDev! We're going to release a new version of eslint-plugin-github
hopefully tomorrow, once these two PRs are merged in:
So I would encourage bumping to that version once it's out!
Here's what changed:
- The existing mapping currently under
github
can be removed. that format has been deprecated thanks to Kendall's work in github/eslint-plugin-github#449. - If we want to define component mapping for accessibility rules now in
eslint-plugin-github
too, we now support the same format asjsx-a11y
. They are documented in https://github.com/github/eslint-plugin-github#component-mapping-experimental.
from eslint-plugin-primer-react.
Hey @khiga8, this sounds good!
Just to clarify, is the idea to remove the mappings under "github" in the recommended.js file?
As far as the mapping in jsx-a11y
, we definitely could add additional mappings. Nothing comes to mind right now, but I can review our current list of components to see if any of them would benefit from being mapped.
from eslint-plugin-primer-react.
Sounds good! I'll create a draft PR that should include some of the changes suggested!
from eslint-plugin-primer-react.
Closing per #67.
from eslint-plugin-primer-react.
@TylerJDev should we keep this open until the false positives flags are fixed? 🤔
from eslint-plugin-primer-react.
@khiga8, I was planning on creating a separate issue to track these. But I don't have a preference either way.
from eslint-plugin-primer-react.
Ooh that sounds good! Just want to make sure your follow-up efforts are tracked! :)
from eslint-plugin-primer-react.
Related Issues (15)
- Create a lint rule for `TriangleDownIcon` inside `trailingAction` HOT 2
- Add lint rules for recommended imports and prop usage HOT 2
- Test issue
- Add support for TypeScript parser to ESLint rule tester HOT 1
- Create an eslint rule that suggest using the new accessible Tooltip
- Create a rule to disallow directly accessing themes from `sx` or styled system props HOT 2
- Rule no-system-props does not detect ``Parent.Children`` component tags
- Create a lint rule that restricts tag usage HOT 5
- Create a lint rule that restricts `aria-label` or `aria-labelledby` usage based on tag HOT 2
- [Spike] Create a lint rule that suggests a more appropriate component for `as` HOT 1
- [Idea] Opinionated rule that requires `as` to be set for `<Heading>` HOT 2
- Create an lint rule to warn deprecated component usage HOT 1
- Update the `a11y-tooltip-interactive-trigger` to exclude elements that have `disabled` attribute from the interactive element list
- Create a lint rule for disabled controls HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-primer-react.