Comments (2)
TylerJDev
commented on April 27, 2024
2
Closing as a11y-explicit-heading rule has been added to eslint-plugin-primer-react!
from eslint-plugin-primer-react.
TylerJDev
commented on April 27, 2024
I think this is a great idea. Since removing the as prop entirely would result in a breaking change, I think that this is a good way to slowly lower the amount of usages where the heading level isn't defined.
We could also add to this rule to ensure that usage of as is only being used with heading elements. We already have some safeguards around this, but I think adding this as a rule could supplement those safeguards.
from eslint-plugin-primer-react.
Related Issues (15)
- Create a lint rule for `TriangleDownIcon` inside `trailingAction` HOT 2
- Add lint rules for recommended imports and prop usage HOT 2
- Test issue
- Add support for TypeScript parser to ESLint rule tester HOT 1
- Create an eslint rule that suggest using the new accessible Tooltip
- Create a rule to disallow directly accessing themes from `sx` or styled system props HOT 2
- Rule no-system-props does not detect ``Parent.Children`` component tags
- Create a lint rule that restricts tag usage HOT 5
- Create a lint rule that restricts `aria-label` or `aria-labelledby` usage based on tag HOT 2
- [Spike] Create a lint rule that suggests a more appropriate component for `as` HOT 1
- Make sure `recommended.js` is up-to-date and dependecies are up-to-date HOT 7
- Create an lint rule to warn deprecated component usage HOT 1
- Update the `a11y-tooltip-interactive-trigger` to exclude elements that have `disabled` attribute from the interactive element list
- Create a lint rule for disabled controls HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-primer-react.