Comments (7)
Should be in effect. 🤞 it works!
from conan-center-index-pending-review.
There's not enough activity in 10 minutes... its 1000 requests every hour so I doubt that will be the biggest limitation (it's about ~2.1 API requests per PR)
There's no notification as of now 😕 not sure what you meant there.
Would once an hour be a good compromise? The bot will only merge once every 30 minutes
from conan-center-index-pending-review.
One hour would be great, sure.
There's no notification as of now 😕 not sure what you meant there.
I mean, if someone subscribes to the issue, they might get notified every time the page is changed.
AFAIK, It doesn't always work as expected if the change to the message is done via API.
from conan-center-index-pending-review.
It's an edit so there is no notification from GitHub that I know of.
I'll update the cron job when I get back but feel free to open a PR in the mean time!
from conan-center-index-pending-review.
Yes, the problem with notifications I have in mind is happening in the android github app. I had to do an explicit verification before each post update here in order to avoid notifying everybody each time the bot ran
from conan-center-index-pending-review.
Ahhh thank you! i never used the app but that makes sense
I just edit the comment with out checking currently
conan-center-index-pending-review/main.go
Line 79 in e4a5938
from conan-center-index-pending-review.
Looks like it's working 🎉
from conan-center-index-pending-review.
Related Issues (20)
- New applet for "interested reviewers" to tag followers of certain recipes HOT 1
- Adjust effort ranking HOT 2
- Handling comments which are resolved? HOT 2
- Handling dismissed approvals
- Valid PR changing github config are rejected
- Approving then commenting does not dismiss approval
- Highlight PRs waiting for just one more review HOT 1
- Green PRs with dismissed or zero Approvals don't appear on the board HOT 2
- Show PRs that are in progress
- Highlight PRs that have merge conflicts HOT 1
- Open Versus Merge fails to upload GIF larger than 1MB
- Open Versus Merged fails to fetch data at the start of a new week
- Support new `bump dependencies` label HOT 1
- Support `GitHub config` labels
- Some PRs are showing new "in progress" when API is sucessful HOT 1
- bot stuck HOT 5
- use upstream information directly HOT 2
- Clean up label detection code
- publish to github pages
- Should labels be transparent?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conan-center-index-pending-review.