Giter Site home page Giter Site logo

Comments (7)

prince-chrismc avatar prince-chrismc commented on June 10, 2024 1

Should be in effect. 🤞 it works!

from conan-center-index-pending-review.

prince-chrismc avatar prince-chrismc commented on June 10, 2024

There's not enough activity in 10 minutes... its 1000 requests every hour so I doubt that will be the biggest limitation (it's about ~2.1 API requests per PR)

There's no notification as of now 😕 not sure what you meant there.

Would once an hour be a good compromise? The bot will only merge once every 30 minutes

from conan-center-index-pending-review.

mathbunnyru avatar mathbunnyru commented on June 10, 2024

One hour would be great, sure.

There's no notification as of now 😕 not sure what you meant there.

I mean, if someone subscribes to the issue, they might get notified every time the page is changed.
AFAIK, It doesn't always work as expected if the change to the message is done via API.

from conan-center-index-pending-review.

prince-chrismc avatar prince-chrismc commented on June 10, 2024

It's an edit so there is no notification from GitHub that I know of.

I'll update the cron job when I get back but feel free to open a PR in the mean time!

from conan-center-index-pending-review.

ericLemanissier avatar ericLemanissier commented on June 10, 2024

Yes, the problem with notifications I have in mind is happening in the android github app. I had to do an explicit verification before each post update here in order to avoid notifying everybody each time the bot ran

from conan-center-index-pending-review.

prince-chrismc avatar prince-chrismc commented on June 10, 2024

Ahhh thank you! i never used the app but that makes sense

I just edit the comment with out checking currently

_, _, err = client.Issues.Edit(context, "prince-chrismc", "conan-center-index-pending-review", 1, &github.IssueRequest{

from conan-center-index-pending-review.

prince-chrismc avatar prince-chrismc commented on June 10, 2024

Looks like it's working 🎉

from conan-center-index-pending-review.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.