prof7bit/pid-trainer

tune a simulated pid loop with the mouse to get a feel for how the impulse response changes in real time

pid-trainer's Issues

PID structure

Hello,

when tuning PID, maybe people forget that structure of PID is something really important when considering setting parameters.

http://www.acsysteme.com/en/serial-or-parallel-pid

Common PID structures are :

• Serial
• Parallel
• Mixed

Given calculate function definition

pid-trainer/pid-trainer.py

Lines 51 to 56 in 8d7ca3b

	def calculate(self, error):
	self.p = error * self.kp
	self.i += error * self.ki
	self.d = (error - self.previous_error) * self.kd
	self.previous_error = error
	return self.p + self.i + self.d

I think you are considering parallel PID tuning.

Maybe you should consider adding a dropdown combobox to choose PID structure and ajuste calculate function accordingly.

Kind regards