Comments (8)
Can I tackle this one also as I'm new to java and I feel comfortable going after it?
from jadventure.
Hell yeah!
Just push your changes.
from jadventure.
I think a solved this, but before I push my changes I am going to try to tweak some other stuff, such as confirmation of performed actions via printing, etc. We also need to add "hands" as an item in the json file, I'll fix that also.
from jadventure.
Hands isn't really an item, just a placeholder in the absence of anything else. It should automatically default to hands if there is no item. It shouldn't be an item.
And this may be a pain, but I'm going to have to ask you to update your fork fully. And I mean FULLY. There was a ton of changes with the pull requests and I don't want to have to turn down your pull request because of the recent issues I've been having. It may not be a problem, but just check before making your pull request.
Thanks!
from jadventure.
The reason why we need to add hands to the items.json file is that I pull the name of the item to display when equipped from the json file. When it gets to hands, it pulls a 'null' because hands doesn't have a name. See below.
public void getStats(){
Item weapon = new Item(getWeapon());
System.out.println("Player name: " + getName() +
"\nCurrent weapon: " + weapon.getName() +
"\nGold: " + player.getGold() +
"\nHealth/Max: " + getHealth() + "/" + getHealthMax() +
"\nDamage/Armour: " + getDamage() + "/" + getArmour() +
"\n" + getName() + "'s level: " + getLevel());
}
We also may want to change the getStats to display the equiped armour while we are at it and therefore the setArmour() method needs to be expanded similar to the setWeapon() method and allow to multiple pieces of armour to be set for different body parts.
I may take a stab at equiping various pieces of armour before I push my changes back.
from jadventure.
Can't you also do player.getWeapon()? That should be set to "hands".
from jadventure.
That would work if the weapon equipped was "hands". When I called player.getWeapon() on the stat line when the player had a shiv equipped it displayed the itemID. I assume the getWeapon() method when called on a weapon that is a class item displays the first value which is the itemID. When "hands" is equipped, it isn't an Item class, it is a string so it just returns hands. I guess that I can put a condition in that if the string is equal to "null", display hands. That would prob get around it without adding "hands" to the json file.
EDIT: I got it working without adding to the json file
from jadventure.
references #58
from jadventure.
Related Issues (20)
- NPC health carries over when reverting save HOT 8
- Selling to guide and then killing him causes negative gold drop HOT 5
- Creating new profiles deletes equipped armors in all other profiles HOT 2
- Saving after killing an NPC on one profile saves NPC death on all profiles HOT 1
- Items should cost more when you sell them to the npc HOT 4
- Merge json/ and json/original_data HOT 1
- Conversation menu infinite loop HOT 5
- when buy things with Guide,it will always loop.[BUG] HOT 1
- Standalone jar doesn't recognize external libraries HOT 4
- Use Adapt for Intent Parsing HOT 2
- i lost my file HOT 3
- prices display while selling HOT 1
- Save Selection Should be Clearer HOT 1
- Debug Error Reporting
- Link github pages site on title HOT 2
- Small amount of Dead code in Main Menu class HOT 4
- QueueProvider rework suggestion HOT 3
- Trading into menus package
- Jacoco breaks build
- Cucumber tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jadventure.