Giter Site home page Giter Site logo

Comments (8)

pthayer3 avatar pthayer3 commented on June 23, 2024

Can I tackle this one also as I'm new to java and I feel comfortable going after it?

from jadventure.

shkesar avatar shkesar commented on June 23, 2024

Hell yeah!
Just push your changes.

from jadventure.

pthayer3 avatar pthayer3 commented on June 23, 2024

I think a solved this, but before I push my changes I am going to try to tweak some other stuff, such as confirmation of performed actions via printing, etc. We also need to add "hands" as an item in the json file, I'll fix that also.

from jadventure.

projectdelphai avatar projectdelphai commented on June 23, 2024

Hands isn't really an item, just a placeholder in the absence of anything else. It should automatically default to hands if there is no item. It shouldn't be an item.

And this may be a pain, but I'm going to have to ask you to update your fork fully. And I mean FULLY. There was a ton of changes with the pull requests and I don't want to have to turn down your pull request because of the recent issues I've been having. It may not be a problem, but just check before making your pull request.

Thanks!

from jadventure.

pthayer3 avatar pthayer3 commented on June 23, 2024

The reason why we need to add hands to the items.json file is that I pull the name of the item to display when equipped from the json file. When it gets to hands, it pulls a 'null' because hands doesn't have a name. See below.

public void getStats(){
    Item weapon = new Item(getWeapon());

    System.out.println("Player name: " + getName() +
                        "\nCurrent weapon: " + weapon.getName() +
                        "\nGold: " + player.getGold() +
                        "\nHealth/Max: " + getHealth() + "/" + getHealthMax() +
                        "\nDamage/Armour: " + getDamage() + "/" + getArmour() +
                        "\n" + getName() + "'s level: " + getLevel());
}

We also may want to change the getStats to display the equiped armour while we are at it and therefore the setArmour() method needs to be expanded similar to the setWeapon() method and allow to multiple pieces of armour to be set for different body parts.

I may take a stab at equiping various pieces of armour before I push my changes back.

from jadventure.

projectdelphai avatar projectdelphai commented on June 23, 2024

Can't you also do player.getWeapon()? That should be set to "hands".

from jadventure.

pthayer3 avatar pthayer3 commented on June 23, 2024

That would work if the weapon equipped was "hands". When I called player.getWeapon() on the stat line when the player had a shiv equipped it displayed the itemID. I assume the getWeapon() method when called on a weapon that is a class item displays the first value which is the itemID. When "hands" is equipped, it isn't an Item class, it is a string so it just returns hands. I guess that I can put a condition in that if the string is equal to "null", display hands. That would prob get around it without adding "hands" to the json file.

EDIT: I got it working without adding to the json file

from jadventure.

pthayer3 avatar pthayer3 commented on June 23, 2024

references #58

from jadventure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.