progether/jadventure

Java text adventure game.

jadventure's Issues

implement npc organizations

thoughts:

1. thief guild - underground and within the city
2. mage guild - within the city
3. gang - underground
4. army - recruit's org
5. political scene

stats command is bugged

When using the stats command (on the DebugPrompt) it throws a NullPointerException, here is the stack trace.

java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at com.jadventure.game.prompts.CommandParser.parse(CommandParser.java:60)
at com.jadventure.game.Game.gamePrompt(Game.java:68)
at com.jadventure.game.Game.(Game.java:35)
at com.jadventure.game.menus.MainMenu.testOption(MainMenu.java:94)
at com.jadventure.game.menus.MainMenu.start(MainMenu.java:46)
at com.jadventure.game.menus.MainMenu.(MainMenu.java:31)
at com.jadventure.game.JAdventure.main(JAdventure.java:47)
Caused by: java.lang.NullPointerException
at com.jadventure.game.entities.Player.getStats(Player.java:168)
at com.jadventure.game.prompts.DebugPrompt.parse(DebugPrompt.java:77)
at com.jadventure.game.prompts.DebugPrompt.(DebugPrompt.java:30)
at com.jadventure.game.prompts.CommandCollection.command_debug(CommandCollection.java:107)
... 11 more

initial sewer rat quest

thoughts:

1. kill a recruit
2. steal some money
3. join a guild or gang

Factory

I have made constructors for a lot of different monsters that can be returned from the factory. Before I submit any pull requests though I wanted to get input from you guys on a few things. My goal is to have this completely independent from the gameplay so we can use it for future projects.

1. There was a suggestion to turn this into not just a factory for the games monsters, but for NPC's in general. This can be done quite easily, and I like the idea, but it will change the implementation, and require changes to our existing code (nothing extensive fortunately, just 3-4 lines). If you guys want to go that rout, let me know and I'll get it ready this week.

2. The way it is currently working, the monsters stats are based on the players level, and for now, I just kind of pulled numbers out of my butt. When someone is ready to get battle working, get with me so I can fine tune these stats to balance things out a bit.

3. The types of monsters returned are based on the setting the player is in. So whoever handles areas will need to assign each area a 'locationType' (i.e. forests, caves, fields, swamps etc...) Do you guys like that idea? Or would you rather just have a pool of monsters that it pulls from randomly.

4. I'm open to all other suggestions you guys have. So feel free to pitch any ideas. In the mean time I'll continue the direction it is headed in now.

Experience and leveling

How do we want to implement the mechanics for leveling and experience?

1. How do we want to scale the required experience for each leveling up. We need to designate some sort of equation that would allow leveling difficulty to increase without blowing up.
2. Do we want the experience given by monsters to scale up with leveling or just have areas with higher level monsters that give more experience. This would require different zones for the player and an ever expanding world as the player levels up.
3. How will leveling effect stats? Do we want some sort of equation to determine stats at different levels dependent on classes or just an increase of a set amount each level. Are there strength or level requirements for equipping certain items?

initial recruit quest

thoughts:

1. capture a sewer rat or underground npc and force them to join the army
2. kill n amount of monsters in the wilderness

locations not reloaded on in-game exit and restart

When you exit the game by stopping jadventure and restarting it, the locations and all the default items are reloaded to their default state. But when you exit from the jadventure menu to the main menu and "[1] Start" a new player, the old locations and changed items remain. the json/original_data/locations.json should be recopied over to json/locations.json when this option is selected.

picking up items doesn't work

Difficulty: Medium

It spawns three empty prompts and doesn't pick up the item.

monster loot

flesh out loot drops and make sure it works fine. some thoughts:

1. loot is based on player's level
2. loot is primarily gold but can be items based on specific criteria such as monster rarity and player level

for multiple clients, locations are messed up

for multiple clients, they all use the same locations.json file which can mess with each other. They should all use separate locations.json files.

Up option available even when it should not be

Underground titles offer the option to goto up, even though this should be impossible, except at certain places, e.g. the stairs.

Attack/Defence

Attack and defence mechanisms that still need to be implemented:

1. Monsters auto attack with the option to run away or fight.
2. Need to moderate leveling and XP gain.
3. Need safe areas where monsters are not spawned.
4. Monsters Should only have a chance of spawning and not spawning on every dangerous tile.

Ideas for what is required available here

changes to debug menu

pretty simple, change the stats command in debug menu to reflect the standard command in the game. oh and it might be best to hide the debug menu option from the help and only let it activate when the test user is loaded. That way regular players can't use it to cheat.

Documentation

Code needs to be documented using:

1. Comments in the code.
2. Flow diagrams of the application life cycle
3. Complete user-case and acceptance tests in src/site
4. Flesh out and complete src/site

Ideas for what is required available here

Classes are too bulky

they should be moved to json files as well instead of having a class for each character type. I have a commit ready that i'll upload later. just leaving a note here for later reference and discussion.

monstermenu: use is too ambiguous

Does use mean equip? Will use also "equip" potions by drinking them an applying the stat? what about if the player is wearing an amulet that decreases attack but increases health and the player wants to remove it? Will use show equipped items too (it doesn't) and then dequip it?

implement city life

thoughts:

1. random npc citizens
2. some political scene

Documentation

I was thinking about writing some documentation, not just for the new guys that want to join, but also for myself. So that I know how everything works.

But I'll need your help, I have no clue if what I am writing is correct in your eyes. Or if it needs more/is incomplete.
So I thought let's create an issue here where we can discuss this. I'll work on it on a separate branch(https://github.com/blackwolf12333/JAdventure/tree/documentation) on my own github repo untill we agree to merge it.

README, Grammar, and Bug

Hey, everyone! This is the first time I've ever opened an issue/offered solutions to an open source project, but I'm excited to contribute to this project.

I'm not sure if these issues are large enough to warrant a pull, but every bit counts, I suppose.

1. There are some formatting issues in the README
2. A few in-game descriptions and introductions have some grammatical errors
3. There is a bug that causes "Prompt:" to display twice when the player enters a command

I'll submit a pull request when I've updated my local copy. Thanks. :)

can't view during battle

I think this would be an invaluable thing to have while fighting; to see the backpack, stats, and equipped items.

delete menu: show name of player to delete on y/n prompt

It's important that instead of displaying the name given by the player, the confirm prompt shows the folder name to be deleted so that the user can be sure that there are no errors in deleting a character.

ex:

Are you sure you want to delete { playerFolder.name }? y/n:

create weapons and items that cannot be used without a minimum level

locations.json is not ignored by .gitignore

It's cluttering up the commits and really changes should not be marked (since it is replaced by the locations.json in original_data anyway)

Dropping doesn't dequip

Difficulty: Medium

Dropping an item keeps the item equipped which should be impossible. I'm also going to start guessing at the level of difficulty for each bug/issue so newcomers can easily figure out which issues to tackle and which they may want to leave alone.

Loading avatar issues/readability/commands

If you go to the load avatar option off the main menu and you do not know what avatar to load, there is no way to return to the main menu and pick new game without restarting the game or atleast I haven't found one. Also, is there a way we can display the available avatars, perhaps an option to delete them.

I also noticed that when I load an avatar, I return to the the initial location rather than where I had saved.

Perhaps can we also display all the options for the player when waiting for a prompt. For example when you first enter a room you have the room exit options and items presented to you but if you go to pick up an item or open the backpack, the options shift upwards. Then when you drop the item, you don't see it available in the room unless you leave and reenter.

Perhaps the options/items can be redisplayed with a key. I know when you type 'help' you get a list of options, but it is outdated. The other thing is changing the font color for items or monsters, something to break up the wall of text, making it easier to see when you equip or pickup something.

Refactoring JAdventure

See comments about refactoring of code

Player mechanisms that still need to be implemented:

1. Add class switching for things like explorer, hunter, etc.
2. Add quests.

Ideas for what is required available here

Wrong displayed name for equipped item

Difficulty: Easy

Equipped items are displayed as the item ID instead of the item name. You just need to initialize the item, grab the item name, and then display that instead.

fully implement client / server disconnect

jadventure only partially supports being a server, there's no way to get input or have a client remotely connect to the game. The items that need to be implemented for this goal to be finished is:

1. abstract user input to another class
1. set up command line arguments to allow jadventure to be started in multiple modes:
1. local remote (both on same computer or network)
1. http remote (server on one, client on another)
1. standalone (playing directly on the core)
1. allow jadventure to be started as a server with an open socket
1. create a basic client that can connect to socket and send/receive text
1. allow multiple people to connect to server (not multi-player, but allows one server, multiple clients for a public web game)

For clients:

1. web based
2. desktop terminal
3. desktop gui

clients should be able to be implemented in multiple languages such as c, c++, python, java. It shouldn't be too hard as they need to just be able to connect to a socket and receive/send data.

test client on all platforms

thoughts:

we need to make sure that end users can easily download and setup a client on any platform and start playing. that means that there need to be multiple distro packages for all main linux distros and an executable for windows and osx.

I can check packages for linux (specifically arch linux).

to make sure that this is finished, we can share our game on certain subreddits (i.e /r/playmygame) and forums (communitycontributions on arch linux) and see feedback from real users. we'd have to make sure that our game is at least playable and that we can call it an alpha version.

Experience/Leveling

Experience mechanisms still need to be implemented:

1. Experience gained for killing monsters.
2. Experience gained for completing quests.
3. Sewer Rats - XP for stealing or killing rival gang members.
4. Recruits - XP for killing sewer rats.
5. Increase in experience results in increased level

Ideas for what is required available here

Move debug commands into CommandCollection class

From @projectdelphai in pull request #112:

an interesting concept would be to remove the debug prompt and merge all the commands into the main prompt. They would only be valid commands however if the current player is test. this way, we save code and minimize the amount of prompts while keeping the same functionality. just a thought.

Unused imports

There are some unused imports lying in the codebase.
Performance isn't much of a variable but it can have some naming conflicts.

Related question on Stackoverflow

Any thoughts on that?

Implement location

There is no way to record location, or move between locations. goTo method in Game.java has not been implemented.

Exit from gameprompt

If a new game and you type "exit" from gamePrompt(), it leads you back to the chooseClass method. Should quit to mainmenu after the first time.

create quest items or rare items

thoughts:

1. randomly generated so there aren't multiple in a multiplayer setup?
2. special attacks

Cannot equip items with more than one word name

location: The entrance to Silliya's Underground Society
command: plock and pick
result: No response

Think the spaces are causes problems in the parsing of the command

Equip is not increasing stat, dequip lowering stat

player: new recruit
item: shiv
location: spawn spot
commands: pshiv, eshiv, ueshiv
attack = 47

why?: I'm pretty sure it's because when place = "" and is passed to equip method and so line 209 in Entity.java is being invoked and stat is lowering to 47. Something over there is really weird. Line 257 in Player.java is passing "" though which is definitely wrong.

Player

See comments about refactoring of code

Player mechanisms that still need to be implemented:

1. Add class switching for things like explorer, hunter, etc.
2. Add quests.

Ideas for what is required available here

CommandParser will get to big

The command parser class as it is, is not very big. But in the futere when we add more commands it will become a "god object". We should probably think of some way to move out some of the code to different functions.

This does not have a high priority, but it should be done at some point in the future...

Backpack modifications

Followed from #47.

can't drop equipped items anymore

there used to be a feature that allowed you to drop an equipped item which would automatically unequipd the item and drop it. It was really helpful and I think we should have that option back.

There are too many monsters without any variation

There needs to be both dangerous zones and safe zones. for instance, around 70% of the underground is dangerous, about 20% of the above is dangerous (excluding the wildlands/forests)

There should be a dangerous/safe property for each location to that is used to determine the possibility of a monster. if there is a possibility, then there should be some method of deciding whether a monster spawns of not (random or calculated). if calculated, then there shouldn't be consecutive monsters (or maybe there should?). It might be even better to have a danger grading system. Tiles with a danger of 5 (maximum) will have monsters next to each other and multiple monsters while lvl. 1 tiles will have monsters only once every 5-6 tiles (for instance).

teleport method

This can be used later in the game (for spells and such) but for now, it'd definitely help with internal testing both manually and with junit.

NPE when using stats command

I get a NullPointerException when using the stats command.
I checked all the values are non-null, some of the Integers are 0 but I don't know if that causes this.

have a guide underground who can help explain the rules

Lots of "don't merge yet"

Don't make a pull request to the main repo's master if you don't want your commit merged yet. At the very least, create a new branch. Again, don't make pull requests if you're not willing to merge that code.

Sorry if I come off as brash, I'm just being direct. Rather than opening a pull request, consider opening an issue to discuss the problem you're fixing. Keep the WIP updates to your fork, maybe merging the updates to their separate branch in the main repo if they're's enough there to warrant it.

Remove Item remove all similar Items.

For example, if you have a backpack of three milks, and you call:

dmilk

then all the milks are dropped and you are left with an empty backpack.

Post any solutions here.

h command

h command is not printing out the help menu. I'm working on it

Equipping of Armor, Special Items, other weapons

So there are basic equipping mechanics in place, however it is still pretty limited.

Next steps to be done for equipping mechanics.

1. Designate slots for the equipping of armor such as helmets, shields, chestplates, pants, shoes, etc.
2. Determine one handed or two handed items that can be equipped and designate slots for hands. For example, shield cannot be used with two handed sword.
3. Designate slots for special amulets, rings, etc.
4. Expand available items to take advantage of these new slots.
5. Do equipped items take up backpack space?

Equipping should show stat change

It becomes rather annoying to run the stats command and get such a large output especially when you then don't know what changed. It'd be much easier to see the changes (i.e strength: +5, intelligence: -3) on equip/unequip.