Giter Site home page Giter Site logo

Comments (4)

projectdelphai avatar projectdelphai commented on August 24, 2024

hmm, I thought this issue was fixed, guess not. One of the ways I found out about this bug was by printing the command that the engine received. If you type plock and pick and the printed line is plock then you know it isn't parsing correctly. I'm almost positive this issue was fixed already though. must be a regression.

from jadventure.

avaloni avatar avaloni commented on August 24, 2024

So, while debugging I noticed that Scanner.next() was being used at QueueProvider.take(), next() stops reading when it finds a delimiter, and the default delimiter are whitespaces. So it would only read plock and stop at the whitespace ignoring the rest of the command (it needs to be pick lock and pick or plock and pick in order to match the item's name at the json).

I propose changing next() to nextLine() which reads until it finds an end of line character, I've been testing and it doesn't seem to create new problems. I'm new at github so sorry for any mistake I might have made.

from jadventure.

paddatrapper avatar paddatrapper commented on August 24, 2024

Welcome then. That would make sense, and your fix is great. I haven't had time to look at it since I found the issue. @projectdelphai I'm sure will merge your request when he has seen it. In which case I will close this issue. Thanks!

from jadventure.

projectdelphai avatar projectdelphai commented on August 24, 2024

This is the fix that we were using. I guess when QueueProvider.take() was implemented it was transferred over as Scanner.next() instead of Scanner.nextLine(). Create a pull request from your branch to progether:master and I'll merge it.

from jadventure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.