Classes are too bulky

[progether]

Classes are too bulky

[verhagen]

Have a look in my improve-code branch as well, I've done the same as well.

[projectdelphai]

@verhagen unfortunately I've had to come to the conclusion that your improve-code branch is way too big for me to look through. With 100 commits ahead and 20+ commits behind master, I can't differentiate which is the same, which is behind, and which is ahead. So honestly your best bet is to start multiple branches which deal with different issues and connect those specific branches as pull requests with specific issues. As it is right now, not only is the improve-code branch too big, it also contains many controversial changes which we may not want to be implemented. Now I and some of the other maintainers (i.e @hawk554 or @indivisible-irl ) could go through and git cherry-pick the specific commits but honestly it's just much easier to leave it alone and let those changes come in organically one at a time.

Sorry but unless someone is willing to fork your branch, fix all the merge conflict and then separate all the commits apart, it's gonna be too difficult to merge.

[projectdelphai]

fixed.

[verhagen]

I think several of the changes, done in these last 20 commits, I did fix already as well, in the improve-code branch.
There are more test and the code is a lot cleaner I think. Have a look through the issues I resolved to get an idea.
Indeed merging is not easy, I do understand that as well. Is it possible the pull my branch in, check which of the 20 commits have not been resolved in the improve-code branch, re-do them there and then merge the improve-code into master.

[projectdelphai]

1. I think your link to the resolved issues is wrong.
2. Yes, it's possible but not worth it and not (as I believe) good practice. Rather, it is better to cherry pick from your branch what hasn't been fixed into master and only merge those. We merge from outside in and not inside out and then back again. Too much confusion.
3. And unfortunately, even if you did fix them, they're not recognized as valid fixes until a patch is requested and merged.