Giter Site home page Giter Site logo

sapphire's People

Contributors

ankhou0 avatar csmartinsfct avatar dmf3030 avatar dolaned avatar imdevin567 avatar jawetzel avatar jeffdunn2 avatar nicholaszuccarelli avatar ryandeming avatar smaho avatar troymccabe avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sapphire's Issues

Sapphire shows "Blockchain disconnected" when syncing headers

When doing a fresh sync the blockchain connected indicator on the bottom left keeps jumping from green "blockchain connected" to red "blockchain disconnected". This doesnt effect the syncing, nor is the daemon actually stopped (refering to the debugfile), but this would probably look strange to the average user.

Here is a video of what it looks like:
https://www.dropbox.com/s/h0b73ii5qbvigji/Sapphire%20connected-disconnected.mp4?dl=0

text on "Address" main screen

On the main screen after clicking “Contacts” the bottom sentence says: “Type the name of an ANS contact and click to add him or fill the Address input (+ optional Name) to add a regular address.”

I would suggest:
a) not to mention “male” only, maybe better choose something like “the name”.
b) to not make such long sentences so after “… and click to add the name” a dot.

Next part of the sentence beginning with “…or fill the Address input (+ optional Name) to add a regular address.” is not exactly clear to me what you can do? I can puzzle but would like that it is clear for even the biggest noob to keep the threshold as low as possible.

Wallet balance

Wallet balance stil not correct. Block explorer shows correct amount but in sapphire it shows the wrong amount.

mnemonic seeds

When will Sapphire support mnemonic seeds? It's a basic feature that every wallet should have. I don't agree that shipping private keys to the different computers you want to use the ECC wallet on is good practice. And a mnemonic seed is a lot easier to write down on a piece of paper than a private key is.

Sapphire icon not displaying in tray

Version: 1.1.2
OS: Windows 10 Home 64-bit

While the app is running, the icon in the tray isn't displaying. Also, a right-click window isn't appearing when you click on that icon.

Untitled

Transactions filter

I have pending transactions when I choose to show only pending transactions it returns a empty screen and the next button still works but everything is empty. I can only see my transaction when I show All

first sentence of instructions is not that clear

it says: "If you never installed Lynx or Sapphire on your computer, or if you do not have this folder, please disregard this and simply install Sapphire and run it:"

should it not be something like this:

"If you never installed Lynx or Sapphire on your computer, or if you do not have the folder mentioned below for the operating system you use, please disregard ...

what? this bootstrap or the instruction to delete?
and simply install Sapphire (is that another file or the same bootstrap?) and run it:

at least not clear to me.

Dismiss update button restarts updater

The "dismiss" button of the daemon updater, shown when the update failes, restarts the update process again.
So you can't break the updating loop if it fails for some reason.

non-intuitive access to the blockchain progress screen

Sapphire has non-intuitive access to the blockchain progress screen.
We need to click over progress stats on the left bottom screen first.

It would be nice if label "Syncing 23.00%" changes color to orange if user moved the mouse's cursor on the label.

executing sapphire v1.0.1 and first contact with user....

  1. Initialization of the .exe takes about 1 minute on my AMD FX™-8320 Eight Core Processor 3,51 GHZ with 8 GB internal memory W8.1 pro 64-bits., x64 processor. Through task manager it takes about 110 MB internal memory divided in 2 background processes.

  2. It checks my wallet which is encrypted. After they congrats me they say to write my password down now. Which password? The one I have or miss I something? What then to write down?

  3. I continue and get warned that it can takes some time?
    a) Should you not specify why it takes time and which key factors influences the speed and what are average times processing?
    b) Should you also not mention how many times in the future it will take that much time etc.?
    c) Should you not also mention that you cannot use until it is finished sync. or …etc.?
    d) again, should you not mention that it not only takes time but also absorbs space on your drive or...?
    e) can you intterupt installation processing and what happens then? do you need to start over etc?

  4. Finished. 100% sync now. It took about 1h for 10%, about 7h for 70% and guess therefore around 10h total? The space in the eccoin folder is about 3,5 GB (including the bootstrap.dat.old file).

delete almost all existing files in map eccoin but some more information might be required

  1. Did it (actually removed it to another area) and find out it is 2GB. Should you not warn users who install for the first time that space required is more then 2GB or did (and do) you do that already? At least I cann't remember.
  2. should you not mention why you must keep wallet.dat?
  3. should you not mention to "close deamon" and to "stop wallet" before deleting etc.?

Update failure

Currently running on Windows 10 Sapphire version v1.0.3g & v0.2.5.11d.
Tried to update several times with the settings option and notification option, same attached failure notification as result.
How to solve it and update to current version?

Update failure

Error

Sapphire Auto generated github issue.

STACK TRACE:

Error: connect ECONNREFUSED 127.0.0.1:19119
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1054:14)

Node Environment: production

Running Environments:
Sapphire 1.3.0
Electron 6.0.12
win32 10.0.18362
Locale: en-US

Wallet syncing - 0% for past 2 days

Sapphire wallet has been running for 2 days, however there is no progress on syncing. Is there any setting issue? System details:
Windows 8, 64 bit
Sapphire wallet - v1.0.3g & vd
No previous wallet installed
sapphire issue

Strange behaviour of staking button

I mentioned this in Discord and was requested to report here. I have run the Sapphire wallet for several months now. Occasionally it has to be turned off to reboot my PC. When I turn the wallet back on, of course I have to re-enter the password to start staking again. I always have to do this twice! The first time, the white staking button flicks to the right and claims to be staking but then very quickly resets to the left again with staking off. I have to enter the pw a second time. This is always successful and staking begins and remains active.

Minimizing sapphire in OSX mojave makes it hide and not come back

If you minimize sapphire to the dock when you click on the doc icon the sapphire window doesnt show up. Top menu bar shows that you have sapphire active and if you toggle fullscreen mode it will bring up fullscreen and then you can go back to windowed mode to make it appear again, so there is a way to recover but its not pretty.

costs for using addresses etc.

In the Wallet / Addresses there is the message “ANS addresses are recognized by name in the network and have a cost of 10 ecc per month.”

a) How is this justified and who collects these ecc for what etc?
b) Should these costs also not be mentioned where you can create contacts?

For now I think this might become a roadblock for many or do I miss costs from other wallets? Should you then not compare this and see where it is competitive to other rates and fees?

Advanced setting: Clear Blockchain fails

When clicking on the clear the blockchain button it shows a daemon stopped succesful toast. Then it tries to clear the chain and it fails to delete the chain. Then it tries to restart the daemon but fails.

It seems that this is caused by a problem that was also reported in issue #83 . The daemon stopped signal is fired to early. So sapphire thinks the daemon is stopped even though its not yet. The process fails, tries to restart the daemon, but since it is still shutting down it fails there aswell

Mac OS 10.12.6 program end unexpectedly at startup

When I first open Sapphire it I never gets past the "Hello, we are getting a few things ready ..." screen. The program quits and gives "Sapphire quit unexpectedly".

Here is the report:
Process: Sapphire [896]
Path: /Applications/Sapphire.app/Contents/MacOS/Sapphire
Identifier: com.github.csmartinsfct.sapphire
Version: 1.0.0 (1.0.0)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: Sapphire [896]
User ID: 501

Date/Time: 2018-04-20 20:02:33.332 -0500
OS Version: Mac OS X 10.12.6 (16G29)
Report Version: 12
Anonymous UUID: AB594D74-AD33-3900-8183-67A2F68135B0

Time Awake Since Boot: 1900 seconds

System Integrity Protection: enabled

Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes: 0x0000000000000001, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY

Termination Signal: Illegal instruction: 4
Termination Reason: Namespace SIGNAL, Code 0x4
Terminating Process: exc handler [0]

Application Specific Information:
Performing @selector(_close:) from sender _NSThemeCloseWidget 0x60000018dea0

slow refresh rate of synced blockchain

Sapphire has very slow refreshe rate of synced blockchain - it refreshes every 20 seconds.
In comparison to the Lynx updates the progress every ~ 3 seconds.

what to do after download ecc-bootstrap-20180412.zip?

Finally downloaded the file (took 40 minutes). After downloading the file the instruction says:
“….and unzip bootstrap.dat into that folder. Then launch Sapphire.”

According to me the bootstrap.dat file is inside the ecc-bootstrap-20180412.zip file and now I understand you have to run the Sapphire v1.0.1.

Maybe the sentence(s) can be more precisely to avoid confusions?

Sapphire should not immediately start daemon

At the moment is seems like sapphire is immediately firing up the daemon if it exists.
After that it runs the update checks and tries to update the daemon.

At least on windows this causes a problem, because the *.exe file of the daemon is in use at that moment and can't be replaced.

One proposed solution:

  • start sapphire
  • check if daemon exists
    • if exists -> run daemon --version and compare version with online avaiable version
      • if online == local -> run daemon
      • if online > local -> run update and then run daemon
    • if not exists -> run update

ANS and Normal Addresses

Under “Your Adresses” is mentiond “All your normal and ANS addresses” with further 2 columns “ANS addresses” and “Normal Addresses”. Besides the mixed use of capital and small letters what is a “normal address” and should this not be made more clear or maybe better, use another term for “normal address” like “crypto address”, “bitcoin address” or just “address”?

Starting sapphire without a daemon present never starts the freshly downloaded daemon.

When you start sapphire and dont have a daemon in the .eccoin-wallet folder or dont have the .eccoin-wallet folder fails to start the daemon after downloading it.

Looking at the folder while starting sapphire you can see that it downloads the .zip, unpacks it and places the eccoind.exe from the unzipped folder in the .eccoin-wallet folder and even renames it. But then sapphire never starts the daemon. So it just sits there trying to connect to the daemon, eventhough it never started the daemon.

Here is a video of what the console looks like:
https://www.dropbox.com/s/u1xth7y9gh7qwcw/Sapphire%20after%20it%20downloads%20a%20fresh%20daemon.mp4?dl=0

downloadspeed very slow, only local or...?

while downloading ecc-bootstrap-20180412.zip it says: "Unknown remaing time – xyzMN (356 KB/sec)" which might be locally (I only have 3MB down now) caused but also due to other reasons very slow downloading speed.

Exporting private key to PDF

I managed to export my private key to PDF just fine. After updating to the latest version the 'export' button (last step before saving) was unresponsive a couple of times. Tried it again just a couple of minutes later and it worked. Windows 10 64 bit.

tiles on google drive doesn't show which OS to select?

when I open the google drive containing the instructions and sapphire v1.0.1 it doesn't show exactly which tile to select (not much text visible in tile). Only when you move your mousepointer to the tile you can see which one is what which is less userfriendly.

[Sapphire 1.3.0] Error popup I got (but Sapphire and Daemon are still working/syncing)

Sapphire Auto generated github issue.

STACK TRACE:

NonError: { message: "Cannot read property 'getWrappedInstance' of null" }
at module.exports (C:\Program Files\Sapphire\resources\app.asar\node_modules\ensure-error\index.js:14:10)
at handleError (C:\Program Files\Sapphire\resources\app.asar\node_modules\electron-unhandled\index.js:24:10)
at C:\Program Files\Sapphire\resources\app.asar\node_modules\electron-unhandled\index.js:91:4
at invokeFunc (C:\Program Files\Sapphire\resources\app.asar\node_modules\lodash.debounce\index.js:160:19)
at trailingEdge (C:\Program Files\Sapphire\resources\app.asar\node_modules\lodash.debounce\index.js:207:14)
at timerExpired (C:\Program Files\Sapphire\resources\app.asar\node_modules\lodash.debounce\index.js:195:14)

Node Environment: production

Running Environments:
Sapphire 1.3.0
Electron 6.0.12
win32 6.1.7601
Locale: fr

Many more major languages like CJK, German, Spanish, Dutch etc.

What I missed and seriously recommend are the choice in which language you want to install. Especially Asia (!!!!) is not directly English speaking and huge countries e.g. German, Spanish spoken countries a.o. prefer (to say the least) that installation can be in their own language, especially when it comes to assets etc. and to lower the threshold for users. According to me a major point of attention.

Is this ANS also foreseen for CJK languages or face this difficulties? What is the strategy and should this not be mentioned somewhere?

Of course I want to help get the translations done and hope this was forseen in the current release (and not to be build in for future releases otherwise major issue). Translations can be done realy quickly (within days).

Advanced setting: Redownload daemon fails

There seem to be a few issues with the advanced options that redownloads the daemon.

Firstly it seems to falsely identify that it stopped the daemon.
After clicking redownload daemon option you get one of those toasts saying: Daemon succesfully stopped. Then you get a red toast saying it to remove the daemon, after checking the debug.log file you could clearly see that it wasnt stopped yet when it tried to remove the daemon.

Then i tried to do it with the daemon already stopped, it removed the daemon but then when it started downloading the new daemon it displayed some other weird behaviour. At first it looked like the progress % was jumping up and down. After futher investigation in the console you could see that every message was being posted 2 times, as if the process was started two times. Which would also explain the progress % jumping up and down, since two processes where reporting their progress to the label.

So 2 problems here:

  1. When stopping the daemon it falsely identifies that the daemon was stopped, eventhough it wasnt.
  2. Redownloading the daemon seems to start the process twice.

came back after an overnight and when i pulled Sapphire out of the dock got this:

Sapphire Auto generated github issue.

STACK TRACE:

NonError: { message: "Cannot read property 'getWrappedInstance' of null" }
at module.exports (/Applications/Sapphire.app/Contents/Resources/app.asar/node_modules/ensure-error/index.js:14:10)
at handleError (/Applications/Sapphire.app/Contents/Resources/app.asar/node_modules/electron-unhandled/index.js:24:10)
at /Applications/Sapphire.app/Contents/Resources/app.asar/node_modules/electron-unhandled/index.js:91:4
at invokeFunc (/Applications/Sapphire.app/Contents/Resources/app.asar/node_modules/lodash.debounce/index.js:160:19)
at trailingEdge (/Applications/Sapphire.app/Contents/Resources/app.asar/node_modules/lodash.debounce/index.js:207:14)
at timerExpired (/Applications/Sapphire.app/Contents/Resources/app.asar/node_modules/lodash.debounce/index.js:195:14)

Node Environment: production

Running Environments:
Sapphire 1.3.0
Electron 6.0.12
darwin 18.6.0
Locale: en-US

Missing Icon

Wallet: Sapphire 1.0.1g
OS: Ubuntu 18.04 LTS
DE: Gnome

The icon is present in the application menu,
but missing in the taskbar and tray bar once the wallet has been opened or minimized.

image

lattest saphire error

Sapphire Auto generated github issue.

STACK TRACE:

TypeError: Cannot read property 'match' of undefined
at matchName (C:\Program Files\Sapphire\resources\app.asar\node_modules\find-process\lib\find_process.js:18:15)
at C:\Program Files\Sapphire\resources\app.asar\node_modules\find-process\lib\find_process.js:95:22
at Array.filter ()
at ChildProcess. (C:\Program Files\Sapphire\resources\app.asar\node_modules\find-process\lib\find_process.js:91:12)
at ChildProcess.emit (events.js:200:13)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)

Node Environment: production

Running Environments:
Sapphire 1.3.0
Electron 6.0.12
win32 10.0.18362
Locale: en-US

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.