project-zot/helm-charts

helm-charts's Issues

liveness probe fails when basic auth is enabled

The same as brotandgames/ciao#59. Issue links to a PR with a good solution where the helm chart can enable and disable the probes

[Feat]: Add configurable startupProbe

Currently, the deployment uses the livenessProbe to check whether the Zot pods are ready to start receiving requests. When using the new search extension from Zot 2.0.0 in combination with remote storage, it can take a while for the Zot pods to become ready. If this takes too long, Kubernetes will kill the pods off before giving them a fair chance to become healthy.

Therefore, I suggest we add a startupProbe to the deployment, which can be configured with e.g. a higher failure threshold. With a higher failure thresholds Pods in this scenario can get some extra time to become healthy.

Add a way to configure the namespace

I'm trying to install Zot using helm template (actually using the helm_template terraform data source) into Talos Kubernetes, but without a way (e.g. a namespace helm value) to set the namespace, Zot can only be installed at the default namespace, which is a bummer.

A possible way is suggested at https://gitea.com/gitea/helm-chart/issues/630.

[Feat] Allow external secret for secretFiles

project-zot/zot#1721

[Feat]: Add LDAP credentials test for helm charts

LDAP credentials are now configured in a separate file, see project-zot/zot#1736.
Update the helm chart to support configuring them if necessary, and also add a test to cover this scenario.

See also #11 for context.

Add support prometheus-operator?

This will simplify the process of collecting Prometheus metrics

Bug: Volume not defined when `mountSecret` is set to `true` but not `mountConfig` or `persistence`

Hello again 👋

Here is the result of the helm template with mountSecret is set to true and all other values using default:

$ helm template zot project-zot/zot --set mountSecret=true -s templates/deployment.yaml
---                      
# Source: zot/templates/deployment.yaml
apiVersion: apps/v1 
kind: Deployment        
metadata:               
  name: zot               
  labels:           
    helm.sh/chart: zot-0.1.27
    app.kubernetes.io/name: zot                                                                                                                                                               
    app.kubernetes.io/instance: zot
    app.kubernetes.io/version: "v2.0.0-rc6"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: zot
      app.kubernetes.io/instance: zot
  template:
    metadata:
      labels:
        app.kubernetes.io/name: zot
        app.kubernetes.io/instance: zot
    spec:
      serviceAccountName: zot
      securityContext:
        null
      containers:
        - name: zot
          securityContext:
            null
          image: "ghcr.io/project-zot/zot-linux-amd64:v2.0.0-rc6"
          imagePullPolicy: IfNotPresent
          ports:
            - name: zot
              containerPort: 5000
              protocol: TCP
          volumeMounts:
            - mountPath: '/secret'
              name: zot-secret
          livenessProbe:
            initialDelaySeconds: 5
            httpGet:
              path: /v2/
              port: 5000
              scheme: HTTP
          readinessProbe:
            initialDelaySeconds: 5
            httpGet:
              path: /v2/
              port: 5000
              scheme: HTTP
          resources:
            null

As you can see the volumeMounts for the secret is defined but not the volume itself.

Add ingress tests for helm charts