projectcalico/go-build

go-build's Issues

s390x Dockerfile needs base image updated

Most of our Dockerfiles have migrated over to Alpine v3.9 and Go 1.12 but s390x is still using s390x/golang:1.11.9-alpine3.8, which means the image is missing some security patches (e.g. this most recent one).

Any s390x users want to take this on? 😄

Replace manifest-tool with `docker manifest` command

It's still experimental, but only required when releasing go-build. Still probably preferable to grabbing the tool from estep's github.

why not upgrade to golang:1.19.5 for all platforms?

the pr 1.19.5 just update amd64.
why not update all others?
like

Dockerfile.s390x,
Dockerfile.ppc64le,
Dockerfile.armv7,
Dockerfile.arm64

Cross-compile calico for arm64 and ppc64le from amd64

Following the merge of #23 , which simplifies building go-build for arm64 on arm64 and ppc64le on ppc64le, this issue is intended as a tracking issue for cross-compile binaries and cross-build of docker images for arm64 and ppc64le (in addition to amd64, of course) from amd64.

Since every CI-as-a-service provides amd64 only, we want to be able to run the entire build and push from amd64.

Related: see #22

cc @caseydavenport @tomdee @fasaxc

Ideas and issues raised by the above people are in a follow-on comment.

please add a link to the dockerfile on hub

https://hub.docker.com/r/calico/go-build/ does not have a link to the dockerfile - of course I found it here, but having a link would be great

Can't use a big UID

Hi there.

I have a big user id (1069552525) in my ubuntu system. (the uid was assigned by my system administrator). When I try to use go-build image with passing a LOCAL_USER_ID env variable, I get a warning message (the second line):

Starting with UID : 1069552525
adduser: number 1069552525 is not in 0..256000 range

The case in that alpine adduser command has a limit on user id.

The case when it is critical for me:
I try to build the felix project (https://github.com/projectcalico/felix). When I run make build LOCAL_USER_ID=$(shell id -u) is passing to the go-builder (https://github.com/projectcalico/felix/blob/master/Makefile#L215), but this uid is not acceptable for the alpine adduser command and it fallbacks to the 0 uid (root user, as we know). As a result, a vendor directory creates on behalf of the root user and this step https://github.com/projectcalico/felix/blob/master/Makefile#L285 is failed with permission denied error.

I have linked PR that fixes this problem.

Thanks.

Pushing out the arm64 images to docker hub?

Are there plans to push out the alternate architecture images to the hub? The Makefile says that the image names are:

• calico/go-build: x86_64
• calico/go-build-arm64: arm64

However, the hub only has the calico/go-build (x86_64) image.

Will you be doing one of:

• Pushing calico/go-build-arm64 out?
• Creating a single multi-arch calico/go-build with a multi-arch manifest?

The docker manifest subcommand hasn't been merged in yet (see this ), but you can use the manifest-tool to do the same thing.

Move build image to golang v1.13

Relates to Homebrew/homebrew-core#44132

The homebrew is already using go 1.13 to build all the golang formula is possible, seems calicoctl can live well with the latest release.

Maybe it worth taking the base build image to the latest and greatest. :)

Dockerfile.amd64 vs Dockerfile.s390x differences

Team,

I am trying to understand why there is such a dissimilarity between Dockerfile used to build amd64 and s390x images.

I have built s390x image based on Dockerfile.amd64 and it seem to have worked for me. I also ran Calico test cases which passed as well.

Is there something I am missing here? Here is a diff file that seems to have done the job for me when building Calico 3.18.1 on s390x:

 diff Dockerfile.s390x Dockerfile.amd64
1c1
< FROM calico/bpftool:v5.3-s390x as bpftool
---
> FROM calico/bpftool:v5.3-amd64 as bpftool
3c3
< FROM s390x/golang:1.15.2-buster
---
> FROM amd64/golang:1.15.2-buster
33c33
<         libbpf-dev linux-headers-s390x  && \
---
>         libbpf-dev linux-headers-amd64  && \
52,58c52,53
< RUN git clone -b v1.0.1 https://github.com/fossas/fossa-cli.git $GOPATH/src/github.com/fossas/fossa-cli; \
<     cd $GOPATH/src/github.com/fossas/fossa-cli; \
<     make; \
<     cp $GOPATH/bin/fossa /usr/local/bin; \
<     chmod +x /usr/local/bin/fossa
< #RUN curl -L https://github.com/fossas/fossa-cli/releases/download/v${FOSSA_VER}/fossa-cli_${FOSSA_VER}_linux_s390x.tar.gz | tar zxvf - -C /usr/local/bin --extract fossa
< #RUN chmod +x /usr/local/bin/fossa
---
> RUN curl -L https://github.com/fossas/fossa-cli/releases/download/v${FOSSA_VER}/fossa-cli_${FOSSA_VER}_linux_amd64.tar.gz | tar zxvf - -C /usr/local/bin --extract fossa
> RUN chmod +x /usr/local/bin/fossa
61,67c56,57
< RUN git clone -b v2.3.0 https://github.com/vektra/mockery.git $GOPATH/src/github.com/vektra/mockery.git; \
<     cd $GOPATH/src/github.com/vektra/mockery.git; \
<     go get github.com/vektra/mockery/v2/.../; \
<     cp $GOPATH/bin/mockery /usr/local/bin/mockery; \
<     chmod +x /usr/local/bin/mockery
< #RUN curl -L https://github.com/vektra/mockery/releases/download/v${MOCKERY_VER}/mockery_${MOCKERY_VER}_Linux_x86_64.tar.gz | tar zxvf - -C /usr/local/bin --extract mockery
< #RUN chmod +x /usr/local/bin/mockery
---
> RUN curl -L https://github.com/vektra/mockery/releases/download/v${MOCKERY_VER}/mockery_${MOCKERY_VER}_Linux_x86_64.tar.gz | tar zxvf - -C /usr/local/bin --extract mockery
> RUN chmod +x /usr/local/bin/mockery
103c93
< # Enable non-native runs on s390x architecture hosts
---
> # Enable non-native runs on amd64 architecture hosts
114c104
< RUN curl -sSL https://github.com/estesp/manifest-tool/releases/download/${MANIFEST_TOOL_VERSION}/manifest-tool-linux-s390x > manifest-tool && \
---
> RUN curl -sSL https://github.com/estesp/manifest-tool/releases/download/${MANIFEST_TOOL_VERSION}/manifest-tool-linux-amd64 > manifest-tool && \

go-build build is failing, glibc is the problem.

Docker build of the go-build images are (all architectures) started failing today. This is the error.
<....>
---> Running in 7ae02d7469e8
The command '/bin/sh -c wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://raw.githubusercontent.com/sgerrand/alpine-pkg-glibc/master/sgerrand.rsa.pub' returned a non-zero code: 5
Makefile:37: recipe for target 'calico/go-build' failed

It can be fixed by updating the url to:
https://cdn.rawgit.com/sgerrand/alpine-pkg-glibc/master/sgerrand.rsa.pub
( as recommended on https://rawgit.com/)

However, why do we need glibc in the first place, alpine is based libc.musl? I discovered that we have been installing this same package for all arch, yet the lib installed in all cases is for x86-64 so it could not be working on anything except the amd image. Therefore it must not be needed.

I suggest we remove the glibc from all the Dockerfiles.

@fasaxc WDYT

goveralls not found on v0.12 release

su-exec: goveralls: No such file or directory

Cross compiles are slow due to rebuilding stdlib

Since we do cross compiles using the amd64 image, it'd speed up the downstream builds if we built the standard library for each of the target arches.

New push-manifest target not working on semaphore

# Docker login to hub.docker.com required before running this target as we are using /home/runner/.docker/config.json holds the docker login credentials
docker run -t --entrypoint /bin/sh -v /home/runner/.docker/config.json:/root/.docker/config.json calico/go-build:latest-amd64 -c "/usr/bin/manifest-tool push from-args --platforms linux/amd64,linux/arm64,linux/ppc64le --template calico/go-build:latest-ARCH --target calico/go-build:latest"
FATA[0003] Inspect of image "calico/go-build:latest-arm64" failed with error: manifest unknown: manifest unknown