Giter Site home page Giter Site logo

angular-peity's Issues

Please add Dynamic options checking

Please add this to your directive:

var OptsWatcher = scope.$watch('options', function () {
    jQuery(span).peity(chartType, options);
}, true);

scope.$on('$destroy', function () {
    watcher();
    OptsWatcher();
});

typo in bower.json

In the bower.json peity is written piety.
e.g. in order for bower to be able to automatically include this script
"main": "angular-piety.js",
should be
"main": "angular-peity.js",

Watcher didn't work on array

Hello,
I'm trying to use the line-chart to make a monitor for cpu usage but the data didn't get updated when it changed.

I found that the watcher works when I update some elements of an array, but doesn't work when push or shift to the array.

I checked the source code and found that at line 39-41

      var watcher = scope.$watch('data', function(){
        span.textContent = scope.data.join();
        jQuery( span ).change();
      });

The watcher doesn't have params objectEquality. So I changed it to

      var watcher = scope.$watch('data', function(){
        span.textContent = scope.data.join();
        jQuery( span ).change();
      }, true);

And it works, maybe the objectEquality params should be added to the watcher?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.