Giter Site home page Giter Site logo

Continuous Integration about proot-rs HOT 7 CLOSED

proot-me avatar proot-me commented on May 27, 2024
Continuous Integration

from proot-rs.

Comments (7)

jyn514 avatar jyn514 commented on May 27, 2024 1

Link to original clippy issue: rust-lang/rust-clippy#2604

from proot-rs.

jyn514 avatar jyn514 commented on May 27, 2024 1

Just so you know, cargo fmt --all && git diff --numstat | awk '{print $1 + $2}' | paste -sd+ | bc shows 800 modified lines, which is a bit much to review by hand. Maybe only check formatting for modified files in each commit?

from proot-rs.

oxr463 avatar oxr463 commented on May 27, 2024
  • Update gcc dependency
[build-dependencies]
-gcc = { git = "https://github.com/vincenthage/gcc-rs", branch = "master" }
+gcc = { git = "https://github.com/alexcrichton/cc-rs", branch = "master" }
  • Switch to nightly channel
rust:
- nightly
  • Fix formatting, cargo fmt --all.

from proot-rs.

oxr463 avatar oxr463 commented on May 27, 2024

But won't running cargo fmt --all, automatically fix the formatting?

How would I only check the formatting for modified files?

from proot-rs.

jyn514 avatar jyn514 commented on May 27, 2024

Hmm... maybe something like this? git status --porcelain | sed 's/^...//' | grep '\.rs$' | xargs cargo fmt -v --, see https://stackoverflow.com/questions/5237605/how-can-i-run-git-status-and-just-get-the-filenames#5238537

from proot-rs.

jyn514 avatar jyn514 commented on May 27, 2024

Also the existing unit tests aren't passing, I'm taking a look at that now

from proot-rs.

oxr463 avatar oxr463 commented on May 27, 2024

Closing per #12

from proot-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.