psc-cotc/psc-fram-admin

Administration tools and utilities used by the PSC Coho Technical Committee to administer FRAM model runs.

psc-fram-admin's Issues

Review setting the non retention flag

Need to look at how the FRAM model uses the NonRetention Flag.

Possibly always setting it to 1 for the model to use the value.

Simplify annual report generation

👽 Drop annual specific batch files
👽 Automatically detect year specific config file
👽 Prompt user for the year they want to generate the annual report for

Do not display warning if recruit scalar modified to zero

When importing post season files, ignore the modification of recruit scalars if set to zero and the escapement flag identifies that the target escapement should be set. An example of the warning is:

WARNING - Area 11 Hatchery Marked changed recruit scalar not imported because of escapement flag (0.440600 -> 0.000000).

Add help documentation around TAMM Fishery and Escapement References

The CreateImportFiles does not limit stocks to valid stocks in the base period

The PersonFramStocks includes definitions for the following stocks that are not in the base period:

Area 9 Miscellaneous Wild UnMarked (121)
Area 9 Miscellaneous Wild Marked (122)
Makah Coastal Wild UnMarked (123)
Makah Coastal Wild Marked (124)

These should be excluded when creating import files.

Add validation of TAMM references to not allow reuse of a cell reference

When loading TAMM refernces, the worksheet name, row number, and cell number should be check for uniqueness. This would prevent accidently including the sample fishery or escapement value multiple times in a FRAM model run

Add gui to select FRAM model run

Add a simple GUI to select model run based on list of model runs

Identify specific condition that Recruit Scalars are updated from import file format

The conditions regarding when a recruit scalar is updated based on the import file format must be defined.

This could possibly be done through a specific escapement flag. The following escapement flags could be added:

3 = No target escapement, use recruitment scalar for Backwards FRAM
4 = Recruit Scalar and Target Escapement are to be updated

Only when these new escapement flags are provided will the recruit scalar be updated.

RStudio 1.2 does not support 32-bit R

June 2019: Unable to run 32-bit R from RStudio version 1.2.1335 (preventing use of RODBC package to query Access databases)

See this forum post for details: https://community.rstudio.com/t/unable-to-select-32-bit-r-version-in-rstudio-v1-2-1047-1-preview/16404/32

Developer indicates 32-bit R will be supported in later updates to RStudio v1.2 (comment May 8, 2019), but as of June 25, 2019 this has not been implemented yet.

Interim solution: re-install and run RStudio version 1.1.463 until the patch for version 1.2 is implemented.

Should this project be rewritten as a R Package?