pupix/lcu-connector

🔌 Streamlined LCU integration for your app.

Hey, what's up?

I am Robert, a cutting edge tech enthusiast and a full stack developer that wears many hats, from white to black, and everything in between. I specialize in web and API development, cloud architectures, system integrations and IoT. Been developing API FORGE, a RESTful APIs factory for a few years. I've also been working on an IoT monitoring and analysis platform called BEENO. Why do things yourself when you can have a bunch of smart devices do everything while you take a nap?

In my spare time I like to crack open a cold one 🍺, and as many file formats and protocols as possible.

Want to chit-chat?

You can find me in my discord server all the damn time, on linkedin for corporate and business stuff and all around the web @pupix or @robertmanolea most likely.

kthxbai.

lcu-connector's Issues

Riot Client

There's a new Riot Client rolling out on PBE that we can't connect to with lcu-connector

Chokidar 1.7 has a low severity vulnerability

Chokidar 1.7 has a low severity vulnerability with braces.

Report Log NPM :
` npm audit

                   === npm audit security report ===                        
                                                                            
                                                                            
                             Manual Review                                  
         Some vulnerabilities require your attention to resolve             
                                                                            
      Visit https://go.npm.me/audit-guide for additional guidance           

Low Regular Expression Denial of Service

Package braces

Patched in >=2.3.1

Dependency of d8093eed39f8dcb4bc474bb9753cbaeccf44b71bb9413cf13042e55bf2d…

Path d8093eed39f8dcb4bc474bb9753cbaeccf44b71bb9413cf13042e55bf2d…
> chokidar > anymatch > micromatch > braces

More info https://npmjs.com/advisories/786

found 1 low severity vulnerability in 1511 scanned packages
1 vulnerability requires manual review. See the full report for details.`

Can't find league process in windows if run from Windows Subsystem for Linux

Currently, if you're working within WSL and your League of Legends client is installed as a normal Windows program, WMIC PROCESS WHERE name='LeagueClientUx.exe' GET commandline will never find the program. Instead, you would have to do something like this:

command = "echo WMIC PROCESS WHERE \\\"name=\\'LeagueClientUx.exe\\'\\\" GET commandline | powershell.exe"

In addition, let lockfile_path = path.join(this._dirPath, 'lockfile'); doesn't work because _dirPath will be the windows path which needs to be referred to using the virtual mount. You can do something like: cp.exec("echo wsl wslpath \\\'" + lockfile_path + "\\\' | powershell.exe" ... and process stdout to get the actual path.

As far as actually detecting if someone is on WSL, I think best option is probably something like:
const IS_WSL = process.platform === 'linux' && process.env.PATH.indexOf("/mnt/c/Windows/System32") > -1;

Probably not a very high priority issue and it would add some complexity to what is a very nice and simple file.

Wrong INSTALL_REGEX on macOS fails to resolve LCU path

When I do ps x | grep 'LeagueClientUx' on macOS, I get something like this (this is a trimmed example):

3477   ??  S      0:12.72 /Applications/League of Legends.app/Contents/LoL/RADS/projects/league_client/releases/0.0.0.120/deploy/League of Legends.app/Contents/MacOS/LeagueClientUx --release=0.0.0.89 --rads-product-directory=/Applications/League of Legends.app/Contents/LoL/RADS/solutions/league_client_sln/releases/0.0.0.89/deploy/ --install-directory=/Applications/League of Legends.app/Contents/LoL/ --app-name=LeagueClient --ux-name=LeagueClientUx --ux-helper-name=LeagueClientUxHelper --no-proxy-server

const INSTALL_REGEX = /"--install-directory=(.*?)"/; fails to match my stdout.
I don't know where the problem lies, (in my ps implementation or in your code?), so I'm not doing a pull request, but for now I fixed for me with:
/--install-directory=(.+?)(?: --|$)/ it matches the required string (without those questionable double quotes) plus the beginning of another param or the end of the string (non capturing group).

Please, let me know if you can solve this problem or if I have to keep my fix. Thanks!

EDIT: found CodesignDev@73f4a4b that probably solves the same issue.