purecpp-org/raftcpp

A RAFT implementation to help build your RAFT service in 1 minute.

raftcpp's Issues

Enhance Config class

1. Add ToString() method for Config class.
2. Add operator== and other operators for Config class.
3. Add move constructor for Config class.
4. Add more unit tests for Config class.

Add DEBUG level for nanolog

There is no DEBUG level in nanolog.

Should we write all code in the header only files?

Support metrics module

Add clang-format to check code style

Refine readme

add a script to run all tests

Add planing and roadmap document

Add the default servers to commuicate to each other.

Rename `OnRequestPreVote` to `HandleRequestPreVote`

HandleRequestPreVote will be clearer.

Use actor model for node.

Since node is a FSM, it's better to use actor model to avoid any lock. Not only for performance, but also for easy to write.

Under the implementation, we can use a concurrentqueue for task pending.

Add ID classes

Implement the operator<< in TermID

Implement the operator<< in TermID

can't print NodeID with log

RAFTCPP_LOG(RLL_INFO) << node_id; will be error

cmake compile failed

I git clone raftcpp and build project by following readme, but I got this error:

ENV:
g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Linux aliyun 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

node_elect_test will crash

Env:
gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04)

I find some bug(or not), need analysis:

1. 166
   thread destory, but112 threads vector also destory thread. double free?
2. node.hthis could TimerManager timer_manager_ to set end, because timer_manager_ need first free.
3. I fix the crash in pr can work, but it canot pass test case.
   Becase I need add code in line 163

    threads[leaderFlag].join();
    nodes[leaderFlag].reset();

But it crash nodes[leaderFlag].reset(); this line.

Protect curr_term_id_ when changing it.

@BryainZhang

add windows ci support

as titile

Enhance Endpoint class

1. Add ToString() method for Endpoint class.
2. Add operator== and other operators for Endpoint class.
3. Add move constructor for Endpoint class.
4. Add unit test for Endpoint class.

node_elect_test may fail

We can't pass node_elect_test all the time.

Add nanolog and refine all dependencies by cmake.

Add case to test LogManagerMutexImpl in multi threads.

node_elect_test is complex

node_elect_test is complex, simplify it.

[BUG] `RAFTCPP_CHECK(false)` can't interrupt the process.

int main() {
  RAFTCPP_CHECK(false);
  // this line shouldn't be reached.
}

RAFTCPP_CHECK(false) should crash the process by design. But now it cannot. The process will exit normally, which is a bug.

Add a script to format the code style easily.

• unix
• windows

Integrate gtest

Implement `LogManagerLockFreeImpl`

Use lock free queue in boost to implement the LogManagerLockFreeImpl class.

Add `MostFront()` method for log_queue to get the most front items from queue.

We have the need that get the most front items from the queue.
Please add the public method MostFront() for class BlockingQueueInterface.

How about using bazel instead of cmake as the building system?

maybe it's better to use cmake by default now.

Use random library in modern C++.

https://github.com/topcpporg/raftcpp/blob/master/src/common/timer.cc#L7

We should use modern C++ random instead of rand()

Integrate googletest and add the test to git action CIs.

Migrate other gitsubmodules to cmake dependencies

There are 2 gitsubmodules: asio and rest_rpc.

We should move them to cmake dependencies.

Add cancel button for RandomTimer

Setup python integration tests.

Support an easy to use integration test framework.

Need a cluster to manage nodes and mock the real-world network

Add hash operator for class ID

Currently, NodeID and TermID are not able to be used in unordered map as key type.

Add `Slice` for blockingqueue.

So that we can use the slice in all of our code.

Implementation of toString and operator<< in LogEntry

Implement operator<< in NodeID

Add counter client and run counter example.

Support non-reply RPC model in restrpc.

Currently, we use request-response RPC model to transport data, which is not a good usage because the state of node is dynamically and we have no need use reply.

For example, if nodeA is leader, it should post logs to other nodes, and once it became to a follower it should be a receiver of RPC.

In this proposal, we shouldn't define any response for each request.

[TestCases] Add test cases for log replication.

Use spdlog instead of nanolog

[TestCases] Add test cases for election.

Add `ADD_TEST()` function for cmake

Integrate submodules for building test and rpc modules

Implement a ContinuousTimer

Implement LogManager

• Basic log manager processes. #144
• RequestAppendLogs RPC -> PullLogs RPC #144
• Use map to store logs. #144
• Unit tests to cover log managers: Like use 2 log managers as a test.
• CommitLogToStateMachine
• HandleReceivedLogsFromLeader
• TriggerAsyncDumpLogs
• Full IT cases

Implement election.

This issue traces that the part of leader election.