Warning on build: No files found using pattern: src/**/*.js

[purescript-contrib]

Warning on build: No files found using pattern: src/**/*.js

[garyb]

Yep, it's a warning - when we first introduced the FFI that uses external files there were two separate arguments for supplying the locations of PureScript and JS files - we then added a warning for when a path is specified that matches no files (which is what you're seeing here) - but the most recent change was to make it so one path glob can be used to specify both JS and PS files.

I've not opened a PR yet, as not everyone using Pulp will necessarily be on the latest compiler version, so I was intending on waiting until we cut a 0.8 release before doing so.

[raould]

I have no idea what the comments here mean in terms of this being resolved or not. What I would like to suggest is that sooner rather than later the confusing-alarming-apparently-noise-not-signal-at-least-to-newbies message

psc: No files found using pattern: src/**/*.js

go away. $0.02 intending to help the entire PureScript experience be more streamlined so more people want to use it instead of getting quickly scared away.

[hdgarrood]

Yes, we understand this, and it's going to happen. Please don't rush us.

[raould]

(Is it anything I can do in a PR, or is there too much nuance for me to make any useful example commits? I mean I expect there's a way you want it done, and 99 million other ways not to do it.)

[garyb]

This is the issue that holds it up a bit purescript/purescript#1937.

@hdgarrood would a src/**/*.* style glob help for now perhaps? Although I guess that still breaks down if a directory has a dot in the name.

[hdgarrood]

Yeah that seems like it should work. Directories won't have dots in their names in most cases, at least not if people are following the (almost universal) convention of file names relating to module names. I personally don't mind imposing that requirement for pulp too much.

[paf31]

A workaround could be to just ignore directories in the compiler.

[garyb]

I think that's the fix, not a workaround 😄... for "workaround" I was thinking of changes we could make in pulp alone.

[paf31]

Ah, but the linked issue suggests recursively enumerating files inside directories.

Edit: sorry, I misread it. Didn't realize it suggested either/both.

[garyb]

And I didn't realise it suggested that 😄

[garyb]

I'm not sure the directory approach works though, does it, as if you gave did psc src bower_components you'd end up picking up test .purs files and all sorts from the libraries, so you'd still need a glob to get that one to behave as desired.

[hdgarrood]

This does open an opportunity for pain given that pulp is not the only build tool, though. Suppose someone who doesn't use pulp puts purescript code in a directory that does have dots; it would break only after a pulp user tried to compile it.

We could change pulp's glob now, and fix the issue in the compiler later (the above situation seems so rare that I don't mind there being some short window of time where it might happen).

[hdgarrood]

Haha sorry I didn't see all these responses. Yes, I suppose we do want to stick with globbing then.

[hdgarrood]

@raould if you were to send a PR making pulp use globs that end with **/*.* instead of **/*.js or **/*.purs that would make me very happy. :) Of course it would be contingent on @bodil's approval too.

[raould]

ok! i will try (tho honestly probably not before a several hours have passed, and i get out of work.)

[raould]

Apologies. Tried and failed. I am too clueless at the moment apparently to get Pulp to build. I will post the error I am getting here, but I don't mean to make this drag on with my ignorance -- somebody who Knows What They Are Doing can address this issue later. :-) I am on commit 27743da of the pulp repo. I got purescript built on my linux x86 machine via 'stack'. I did 'bower update'.

$ pulp run
* Building project in /home/superman/Dev/pulp
Error found:
at /home/superman/Dev/pulp/src/Pulp/Project.purs line 14, column 28 - line 14, column 28

  Unable to parse module:
  unexpected "class"
  expecting "module", identifier, (, proper name or )


See https://github.com/purescript/purescript/wiki/Error-Code-ErrorParsingModule for more information,
or to contribute content related to this error.

* ERROR: Subcommand terminated with error code 1

[hdgarrood]

Unfortunately stack install purescript will usually get you an out of date version, so you'll want to run stack install purescript --resolver=nightly. I think the download page on the website has only just been fixed in this respect.

[hdgarrood]

That is: the problem here is that your psc is too old. Pulp requires at least 0.8.0 now.

[hdgarrood]

This is resolved by psc no longer requiring to be told where to find FFI files as of 0.9.x.