pwalczyszyn/express-myconnection

Connect/Express middleware that auto provides mysql connections

express-myconnection's Issues

Connection leak when the response is terminated unexpectedly

Node HTTP API defines two events to finish the response: finish and close. When res.end() is called node triggers the finish event, but if the request terminates unexpectedly (i.e.: the client reloads the page before the response is sent) close is triggered instead.

Proxying res.end() does not take into account the close event and it causes a connection leak. The strategy should be changed to listen for both finish and close events.

req.getConnection is not a function

Hi
i am trying to connect mysql, but it is showing me req.getConnection is not a function
Bellow is the code snipet which i have used.
In app.js
var mysql = require('mysql'), connection = require('express-myconnection'), dbOptions = { host: 'localhost', user: 'root', password: '', port: 3306, database: 'nodejs' }; app.use(connection(mysql, dbOptions, 'request'));
In Customers.js
exports.list = function(req, res, next) { req.getConnection(function(err, connection) { if (err) return next(err); connection.query('SELECT * FROM customer', function(err, rows) { if (err) console.log("Error Selecting : %s ", err); res.render('customers', { page_title: "Customers - Node.js", data: rows }); }); }); };

Can you please check what is have done wrong. I am pretty new in nodejs, so may be i am missing something.

If you want to check my complete package, please follow bellow URL, i have push all code in my git repository
https://github.com/chiraggmodi/nodeCrud

express-myconnection with passport.js

Wonder how one would create a LocalStrategy (that autenticates users againsts a user table in a database) using express-myconnection?

There is no req object in this case.

Connection in custom function

How i can use this in my custom function 👎
function dbcheck() {
getConnection(function (err, connection) {
connection.query('SELECT *FROM users ', function (err, results) {
if (err) return next(err);
return results;
});
});
}

Problem with 'pool'

var config = {
    db: {
        host: 'localhost',
        user: process.env.DB_USER || 'root',
        password: process.env.DB_PWORD ||  '',
        port: process.env.DB_PORT || 3306,
        database: process.env.DB_NAME || 'xxx',
        multipleStatements: true
    }
}
app.use(myConnection(mysql, config.db, 'pool'));

Gives me the following error:

ReferenceError: pool is not defined
    at IncomingMessage.req.getConnection (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express-myconnection/lib/express-myconnection.js:86:21)
    at getContent (/Users/scottvanlooy/Development/Node/fcnode/routes/index.js:36:7)
    at exports.index (/Users/scottvanlooy/Development/Node/fcnode/routes/index.js:55:2)
    at callbacks (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express/lib/router/index.js:164:37)
    at param (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express/lib/router/index.js:138:11)
    at pass (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express/lib/router/index.js:145:5)
    at Router._dispatch (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express/lib/router/index.js:173:5)
    at Object.router (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express/lib/router/index.js:33:10)
    at next (/Users/scottvanlooy/Development/Node/fcnode/node_modules/express/node_modules/connect/lib/proto.js:193:15)
    at Object.loc [as handle] (/Users/scottvanlooy/Development/Node/fcnode/node_modules/loc/lib/i18n.js:129:3)

Not sure why, any ideas?

connection pool

Connection pool does not work with mysql, when the wait_timeout in mysql the server disconnects. This causes an error to be thrown. Express connection does not reacquire connection. I can find no comments or solutions in any forum on this.

A connection with type 'request', gives that variable conn on line 101 does not exist. Should this variable be named connection instad?

support for multiple data sources connections?

if we have transactional database and datamart/reporting db can this support having multiple pools available in some way?

first I guess can a given controller/service/router getting a request use getConnection with some qualifier stating which datasource to use?

could it support getting multiple

If client connections drops then the mysql connection is leaked.

I am implementing long polling in express and my clients can timeout and drop the connection.

In this case the connection is leaked using request strategy. I've solved in my long polling code with:

    req.on('close', function(err) {
        req.getConnection(function(err, connection) {
            connection.end();
        });
    });

how to config to database replication

Please help me config connection to database replication (master & slave)

Thanks
Sid