B038 false positive in 24.1.15 + 24.1.16

[mikaelarguedas]

B038 false positive in 24.1.15 + 24.1.16

[mimre25]

Oh snap, I actually ran this on a quite big code-base as a test and I didn't have any false positives reported.

I'll take a look and see if I can fix this.

Thanks for reporting this and tagging me 🙂

[cooperlees]

Agree this looks a bad / annoying false positive. Will take a fix for this asap and release.

Thanks for reporting.

[mikaelarguedas]

cc @mimre25 for feedback on this as it may also impact the ruff implementation

[wxtim]

Looks similar to

mydicts = {'a': {'foo': 1, 'bar': 2}}

for mydict in mydicts:
    if mydicts.get('a', ''):
        print(mydict['foo'])

B038 is complaining about any instance of an object method called inside the loop that object is the iterator for, without checking whether the loop is modifying it.

[Skrethel]

I've also encountered this false positive for copy() function

d = {}
for _ in d:
	copied = d.copy()