Couple new rule suggestions

[r-downing]

Couple new rule suggestions

[cooperlees]

Thanks for asking before spending the time on the PR and us potentially saying nope.

1. I'd accept it - Thought I do feel cpython/implementations should error on this
2. I'd accept it ... Anything that is usless / pointless and not covered by a more specific flake8 plugin is welcome here

With this one, are you only checking that there is always explicit returns at the end of a function's body? You're never worrying about the type right as I feel mypy / other type checkers will get that.

• If so, I'd accept that too.

I don't feel the need for any of these to be optional. They all seems sane to me. But would love another contributor or users views ...

[JelleZijlstra]

Agree 1 and 2 are good.

3 is probably better left to a type checker; mypy already has a similar check. In general, it requires type information to know whether a function always returns. Some examples:

def int_or_die(s: str) -> int:
    try:
        return int(s)
    except ValueError:
        sys.exit(1)

def does_it_return() -> int:
    while True:
        try:
            return int(raw_input())
        except ValueError:
            continue