pyrzak/bugzilla-extension--inline-images

Allows users to display images inline

bugzilla-extension--inline-images's Issues

Constant subroutine Bugzilla::Extension::InlineImages::NAME redefined at /usr/share/perl/5.8/constant.pm line 115.

I've just installed the InlineImages extension on Bugzilla 4.2, and was getting this error.

It seems to be that NAME is defined twice - in Config.pm and Extension.pm

The fix is to remove the second declaration, in Extension.pm on line 28, which is currently as follows:

use constant NAME => 'InlineImages';

Doesn't work with Bugzilla 4.0rc1

checksetup.pl fails in 4.0rc1:

"get_attachment_link" is not exported by the Bugzilla::Template module
Can't continue after import errors at ./extensions/InlineImages/Extension.pm line 25
BEGIN failed--compilation aborted at ./extensions/InlineImages/Extension.pm line 25.
Compilation failed in require at Bugzilla/Extension.pm line 82.

Add configuration option to allow images to be displayed by default.

Currently, image display defaults to off.

If you click 'show images' on a page that has images, then the state of the setting is remembered in a cookie, so subsequent pages automatically show images on load (on the current computer/browser, for as long as the cookie persists).

However, this link isn't necessarily obvious, and users may not notice that this feature is available. It also requires that you manually enable it each time you visit the site from a different machine.

There should be a user preference to 'display image attachments inline'. This should work like other user preferences - a default can be set for the site, and you can specify whether users can over-ride this default, and if they can over-ride it, users get the three options 'site default', 'yes' and 'no.

I imagine all the UI stuff will be handled automatically by Bugzilla and that you just need to define the parameter, and update the code to make use of it.

Thank you!

This still works in 2023 with Bugzilla 5.0.6 under Linux. Thank you. This really should be a feature, a picture is worth a thousand words.