python-gino/gino-aiohttp

An extension for GINO to support aiohttp.web server.

gino-aiohttp's Issues

Prod docker-compose example does not work

Expected Behavior

Run the example aiohttp application

Actual Behavior

docker compose cannot start service ''migration''

Steps to Reproduce the Problem

1. Git clone repo
2. run docker-compose build from prod example
3. get error

ERROR: Service 'migration' failed to build: The command '/bin/sh -c python -m venv /env && . /env/bin/activate && poetry install' returned a non-zero code: 1

Specifications

• MacOs version: 10.15.4
• Docker desktop version: 2.3.0.2
• other python libs -> from repo

Bump dependencies

Hey. I have recently looked at some Gino extensions and noticed that this extension requires some dependencies to be bumped. At least two (#37 and #34) are security related, and it might also be worth to look at the other merge requests by Dependabot.

Dependabot couldn't authenticate with https://pypi.python.org/simple/

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Config retry_limit does not work.

Expected Behavior

When specifying a retry_limit (as seen in the code https://github.com/python-gino/gino-aiohttp/blob/master/src/gino_aiohttp.py#L152), I'm expecting the code to exit after x retries.

Actual Behavior

The amount of retries is never incremented, thus the retries will always stay at 0, meaning it'll never get out of the "trying to connect" loop.

Steps to Reproduce the Problem

1. Use the following config:

app["config"] = {
    "gino": {
        "dsn": "postgres://username:[email protected]:5432/db",
        "retry_limit": 3,
    },

2. Run the common usage
3. Expected result; raise an exception after 3 connection retries

Specifications

• Python version: 3.8
• GINO version: 1.0.0
• gino-aiohttp version: 0.1.0
• aiohttp version: 3.6.2