Comments (7)
I think your analysis is correct, but i wonder if builds after pytorch/builder#1787 would revert to the original behavior.
@snadampal can we add some sort of a regression test to the release process to avoid such flaws in the future?
from pytorch.
Ok, taking for myself as pytorch/builder#1787 actually broke nightly builds, need to restart the process..
from pytorch.
Ok, taking for myself as pytorch/builder#1787 actually broke nightly builds, need to restart the process..
@malfet Thanks.
Will there be a nightly version of 2.3.1?
from pytorch.
Hi @dilililiwhy , can you please try with the latest nightly wheel, something like this
pip3 install --pre torch==2.4.0.dev20240426 -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
this has the correct openBLAS and also correct libgomp. This was the main difference went into previous builder patch you had pointed out.
from pytorch.
Hi @malfet , yes, we need some regression tests around openblas and openmp. will check what can be included in the CD test.
from pytorch.
Hi @dilililiwhy , can you please try with the latest nightly wheel, something like this
pip3 install --pre torch==2.4.0.dev20240426 -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
this has the correct openBLAS and also correct libgomp. This was the main difference went into previous builder patch you had pointed out.
Time taken is return to normal by using dev20240426.
Step 0 : 4.790385484695435
Step 1 : 0.009980916976928711
Step 2 : 0.0010445117950439453
Step 3 : 0.0010247230529785156
Step 4 : 0.0011034011840820312
Step 5 : 0.0011696815490722656
... ...
Step 25 : 0.0009491443634033203
Step 26 : 0.0009517669677734375
Step 27 : 0.0009474754333496094
Step 28 : 0.000934600830078125
Step 29 : 0.0009233951568603516
Step Avg : 0.17011735439300538
torch 2.4.0.dev20240426
torchvision 0.19.0.dev20240426
@snadampal Thanks for your help. Will there be a nightly version of torch 2.3.1?
from pytorch.
great! I have raised this PR to fix this issue on pytorch/2.3 release
pytorch/builder#1805
I think once it is merged to 2.3 release branch, there may be a nightly wheel.
from pytorch.
Related Issues (20)
- Add testing for NJT serialization
- Triton kernel doing more work uses less registers HOT 8
- GCC 14.1 internal compiler errors? HOT 4
- [NestedTensor] Graph breaks with SDPA + NT constructor HOT 1
- [ONNX] Support constant, buffer, parameters in ExportedProgram serialization to ONNX tensor HOT 2
- [dynamo] Handle inplace op aliasing errors
- `SobolEngine.draw` does not respect the default `dtype` and always uses the passed in dtype (defaulted to float32) HOT 1
- [ONNX] dynamo_export always uses external ONNX weights if the argument is ExportedProgram, even for small models HOT 3
- [FSDP2][2D] test_clip_grad_norm_2d is failing on main
- [ONNX] Unsupported FX nodes: {'call_function': ['aten\ .glu.default']}
- xpu: provide a way to debug explicit CPU fallback HOT 5
- DISABLED test_mixed_mm_epi_works (__main__.TestPatternMatcher) HOT 1
- DISABLED test_non_contiguous_input_bmm (__main__.TestMaxAutotune) HOT 1
- xpu: support torch.utils.data.DataLoader(pin_memory_device='xpu') HOT 2
- DISABLED test_nonzero_no_warning (__main__.TestAdvancedIndexing) HOT 4
- DISABLED test_dtensor_op_db_dstack_cpu_float32 (__main__.TestDTensorOpsCPU) HOT 2
- DISABLED test_conv_empty_input_cpu_bfloat16 (__main__.TestNNDeviceTypeCPU) HOT 2
- DISABLED test__int_mm_k_32_n_32_use_transpose_a_False_use_transpose_b_False_cuda (__main__.TestLinalgCUDA) HOT 1
- Microsoft Visual C++ Redistributable is not installed, this may lead to the DLL load failure. HOT 2
- Potential issue of βerrno: 98- Address already in useβ error in DDP (with torchrun)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytorch.