Giter Site home page Giter Site logo

Comments (7)

malfet avatar malfet commented on May 31, 2024

I think your analysis is correct, but i wonder if builds after pytorch/builder#1787 would revert to the original behavior.

@snadampal can we add some sort of a regression test to the release process to avoid such flaws in the future?

from pytorch.

malfet avatar malfet commented on May 31, 2024

Ok, taking for myself as pytorch/builder#1787 actually broke nightly builds, need to restart the process..

from pytorch.

dilililiwhy avatar dilililiwhy commented on May 31, 2024

Ok, taking for myself as pytorch/builder#1787 actually broke nightly builds, need to restart the process..

@malfet Thanks.
Will there be a nightly version of 2.3.1?

from pytorch.

snadampal avatar snadampal commented on May 31, 2024

Hi @dilililiwhy , can you please try with the latest nightly wheel, something like this
pip3 install --pre torch==2.4.0.dev20240426 -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html

this has the correct openBLAS and also correct libgomp. This was the main difference went into previous builder patch you had pointed out.

from pytorch.

snadampal avatar snadampal commented on May 31, 2024

Hi @malfet , yes, we need some regression tests around openblas and openmp. will check what can be included in the CD test.

from pytorch.

dilililiwhy avatar dilililiwhy commented on May 31, 2024

Hi @dilililiwhy , can you please try with the latest nightly wheel, something like this pip3 install --pre torch==2.4.0.dev20240426 -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html

this has the correct openBLAS and also correct libgomp. This was the main difference went into previous builder patch you had pointed out.

Time taken is return to normal by using dev20240426.

Step 0 : 4.790385484695435
Step 1 : 0.009980916976928711
Step 2 : 0.0010445117950439453
Step 3 : 0.0010247230529785156
Step 4 : 0.0011034011840820312
Step 5 : 0.0011696815490722656
... ...
Step 25 : 0.0009491443634033203
Step 26 : 0.0009517669677734375
Step 27 : 0.0009474754333496094
Step 28 : 0.000934600830078125
Step 29 : 0.0009233951568603516
Step Avg : 0.17011735439300538

torch 2.4.0.dev20240426
torchvision 0.19.0.dev20240426

@snadampal Thanks for your help. Will there be a nightly version of torch 2.3.1?

from pytorch.

snadampal avatar snadampal commented on May 31, 2024

great! I have raised this PR to fix this issue on pytorch/2.3 release
pytorch/builder#1805

I think once it is merged to 2.3 release branch, there may be a nightly wheel.

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.