qalculate/libqalculate

Qalculate! library and CLI

libqalculate's Issues

libqalculate doesn't gracefully handle mistakenly using a unit of temperature in a hexadecimal expression

People often try to mistakenly input hexadecimal numbers as F2 or 1C (instead of 0xF2 or 0x1C). When they do this, libqualculate produces undefined behavior, which can crash software that uses libqalculate.

You can see this by using KDE KRunner (which uses libqalculate as a backend) and entering either of the following:

• =(1C)^2
• =F2

KRunner crashes in response to the undefined output.

This was discovered in https://bugs.kde.org/show_bug.cgi?id=358617

Zero terms in simplification

This is more a CAS issue but still.

Try e.g.

x^2-1
factor
simplify

Build fails if mpfr.h not available

configure checks for the presence of mpfr.h, but ignores the result.
If it is not present, the build fails.

Failure to compile

Hi

I've tried compiling libqalculate just now, with the latest source (30aug '17), but the 'make' sessions fails.

./configure passed ok, so I am not sure what I am missing here.

./configure and make output below

station:~/Downloads/libqalculate-master> ./configure
configure: loading site script /usr/share/site/x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking whether ln -s works... yes
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking whether NLS is requested... yes
checking for intltool-update... /usr/bin/intltool-update
checking for intltool-merge... /usr/bin/intltool-merge
checking for intltool-extract... /usr/bin/intltool-extract
checking for xgettext... /usr/bin/xgettext
checking for msgmerge... /usr/bin/msgmerge
checking for msgfmt... /usr/bin/msgfmt
checking for gmsgfmt... /usr/bin/msgfmt
checking for perl... /usr/bin/perl
checking for perl >= 5.8.1... 5.18.2
checking for XML::Parser... ok
checking build system type... x86_64-suse-linux-gnu
checking host system type... x86_64-suse-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/x86_64-suse-linux/bin/ld
checking if the linker (/usr/x86_64-suse-linux/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-suse-linux-gnu file names to x86_64-suse-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-suse-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/x86_64-suse-linux/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/x86_64-suse-linux/bin/ld -m elf_x86_64
checking if the linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... no
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for pthread_create in -lpthread... yes
checking mpfr.h usability... yes
checking mpfr.h presence... yes
checking for mpfr.h... yes
checking unordered_map usability... no
checking unordered_map presence... no
checking for unordered_map... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for LIBCURL... yes
checking for ICU... yes
checking for LIBXML... yes
checking for ld used by gcc... /usr/x86_64-suse-linux/bin/ld -m elf_x86_64
checking if the linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) is GNU ld... yes
checking for shared library run path origin... done
checking for iconv... yes
checking for working iconv... yes
checking whether to use readline... yes
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking readline/history.h usability... yes
checking readline/history.h presence... yes
checking for readline/history.h... yes
checking for readline in -lreadline... yes
  Using -lreadline -lncurses
checking for library containing nanosleep... none required
checking for msgfmt... (cached) /usr/bin/msgfmt
checking for gmsgfmt... (cached) /usr/bin/msgfmt
checking for xgettext... (cached) /usr/bin/xgettext
checking for msgmerge... (cached) /usr/bin/msgmerge
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... yes
checking whether to use NLS... yes
checking where the gettext function comes from... libc
checking locale directory... checking for struct lconv.int_p_cs_precedes... yes
checking for struct lconv.int_n_cs_precedes... yes
"/usr/local/share/locale"
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating libqalculate/Makefile
config.status: creating data/Makefile
config.status: creating po/Makefile.in
config.status: creating po-defs/Makefile
config.status: creating docs/Makefile
config.status: creating docs/reference/Makefile
config.status: creating libqalculate.pc
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing po-directories commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
config.status: executing po/stamp-it commands
claus@Battlestation:~/Downloads/libqalculate-master> make
make  all-recursive
make[1]: Entering directory '/home/claus/Downloads/libqalculate-master'
Making all in libqalculate
make[2]: Entering directory '/home/claus/Downloads/libqalculate-master/libqalculate'
/bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I..  -I.. -DPACKAGE_DATA_DIR=\""/usr/local/share"\" -I/usr/include/libxml2      -g -O2 -MT Function.lo -MD -MP -MF .deps/Function.Tpo -c -o Function.lo Function.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -I.. -DPACKAGE_DATA_DIR=\"/usr/local/share\" -I/usr/include/libxml2 -g -O2 -MT Function.lo -MD -MP -MF .deps/Function.Tpo -c Function.cc  -fPIC -DPIC -o .libs/Function.o
Function.cc: In member function 'virtual std::string IntegerArgument::subprintlong() const':
Function.cc:1735:40: error: 'INT_MIN' was not declared in this scope
    case INTEGER_TYPE_SINT: {str += i2s(INT_MIN); break;}
                                        ^
Function.cc:1737:41: error: 'LONG_MIN' was not declared in this scope
    case INTEGER_TYPE_SLONG: {str += i2s(LONG_MIN); break;}
                                         ^
Function.cc:1758:40: error: 'UINT_MAX' was not declared in this scope
    case INTEGER_TYPE_UINT: {str += i2s(UINT_MAX); break;}
                                        ^
Function.cc:1759:40: error: 'INT_MAX' was not declared in this scope
    case INTEGER_TYPE_SINT: {str += i2s(INT_MAX); break;}
                                        ^
Function.cc:1760:41: error: 'ULONG_MAX' was not declared in this scope
    case INTEGER_TYPE_ULONG: {str += i2s(ULONG_MAX); break;}
                                         ^
Function.cc:1761:41: error: 'LONG_MAX' was not declared in this scope
    case INTEGER_TYPE_SLONG: {str += i2s(LONG_MAX); break;}
                                         ^
Makefile:521: recipe for target 'Function.lo' failed
make[2]: *** [Function.lo] Error 1
make[2]: Leaving directory '/home/claus/Downloads/libqalculate-master/libqalculate'
Makefile:501: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/claus/Downloads/libqalculate-master'
Makefile:409: recipe for target 'all' failed
make: *** [all] Error 2

Kind regards

Compilation error

I am having trouble compiling the latest version of libqalcuate. The ./configure is successful but 'make' results in an error. The output for ./configure and make are shown below. Any help is appreciated.

./configure
configure: loading site script /usr/share/site/x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking whether ln -s works... yes
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking whether NLS is requested... yes
checking for intltool-update... /usr/bin/intltool-update
checking for intltool-merge... /usr/bin/intltool-merge
checking for intltool-extract... /usr/bin/intltool-extract
checking for xgettext... /usr/bin/xgettext
checking for msgmerge... /usr/bin/msgmerge
checking for msgfmt... /usr/bin/msgfmt
checking for gmsgfmt... /usr/bin/msgfmt
checking for perl... /usr/bin/perl
checking for perl >= 5.8.1... 5.18.2
checking for XML::Parser... ok
checking build system type... x86_64-suse-linux-gnu
checking host system type... x86_64-suse-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/x86_64-suse-linux/bin/ld
checking if the linker (/usr/x86_64-suse-linux/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-suse-linux-gnu file names to x86_64-suse-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-suse-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/x86_64-suse-linux/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @file support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/x86_64-suse-linux/bin/ld -m elf_x86_64
checking if the linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... no
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for pthread_create in -lpthread... yes
checking mpfr.h usability... yes
checking mpfr.h presence... yes
checking for mpfr.h... yes
checking unordered_map usability... no
checking unordered_map presence... no
checking for unordered_map... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for LIBCURL... yes
checking for ICU... yes
checking for LIBXML... yes
checking for ld used by gcc... /usr/x86_64-suse-linux/bin/ld -m elf_x86_64
checking if the linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) is GNU ld... yes
checking for shared library run path origin... done
checking for iconv... yes
checking for working iconv... yes
checking whether to use readline... yes
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking readline/history.h usability... yes
checking readline/history.h presence... yes
checking for readline/history.h... yes
checking for readline in -lreadline... yes
Using -lreadline -lncurses
checking for library containing nanosleep... none required
checking for msgfmt... (cached) /usr/bin/msgfmt
checking for gmsgfmt... (cached) /usr/bin/msgfmt
checking for xgettext... (cached) /usr/bin/xgettext
checking for msgmerge... (cached) /usr/bin/msgmerge
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... yes
checking whether to use NLS... yes
checking where the gettext function comes from... libc
checking locale directory... checking for struct lconv.int_p_cs_precedes... yes
checking for struct lconv.int_n_cs_precedes... yes
"/usr/local/share/locale"
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating libqalculate/Makefile
config.status: creating data/Makefile
config.status: creating po/Makefile.in
config.status: creating po-defs/Makefile
config.status: creating docs/Makefile
config.status: creating docs/reference/Makefile
config.status: creating libqalculate.pc
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing po-directories commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
config.status: executing po/stamp-it commands
raaj-Laptop:/home/raaj/Desktop/libqalculate-master # make
make all-recursive
make[1]: Entering directory '/home/raaj/Desktop/libqalculate-master'
Making all in libqalculate
make[2]: Entering directory '/home/raaj/Desktop/libqalculate-master/libqalculate'
/bin/sh ../libtool --tag=CXX --mode=link g++ -g -O2 -version-info 12:0:0 -no-undefined -o libqalculate.la -rpath /usr/local/lib64 Function.lo Calculator.lo DataSet.lo Variable.lo ExpressionItem.lo Number.lo MathStructure.lo Prefix.lo util.lo Unit.lo BuiltinFunctions.lo -lcurl -lxml2 -licuuc -licudata -lpthread -lmpfr -lgmp
libtool: link: g++ -fPIC -DPIC -shared -nostdlib /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../lib64/crti.o /usr/lib64/gcc/x86_64-suse-linux/4.8/crtbeginS.o .libs/Function.o .libs/Calculator.o .libs/DataSet.o .libs/Variable.o .libs/ExpressionItem.o .libs/Number.o .libs/MathStructure.o .libs/Prefix.o .libs/util.o .libs/Unit.o .libs/BuiltinFunctions.o -Wl,-rpath -Wl,/usr/lib64 -Wl,-rpath -Wl,/usr/lib64 -lcurl /usr/lib64/libxml2.so -L/lib64 -ldl -lz -llzma -licuuc -licudata -lpthread -lmpfr -lgmp -L/usr/lib64/gcc/x86_64-suse-linux/4.8 -L/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/lib -L/usr/lib64/gcc/x86_64-suse-linux/4.8/../../.. -lstdc++ -lm -lc -lgcc_s /usr/lib64/gcc/x86_64-suse-linux/4.8/crtendS.o /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../lib64/crtn.o -O2 -Wl,-soname -Wl,libqalculate.so.12 -o .libs/libqalculate.so.12.0.0
/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../lib64/libgmp.a(lt20-get_str.o): relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a shared object; recompile with -fPIC
/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../lib64/libgmp.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
Makefile:486: recipe for target 'libqalculate.la' failed
make[2]: *** [libqalculate.la] Error 1
make[2]: Leaving directory '/home/raaj/Desktop/libqalculate-master/libqalculate'
Makefile:501: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/raaj/Desktop/libqalculate-master'
Makefile:409: recipe for target 'all' failed
make: *** [all] Error 2

RPN syntax is broken in CLI

Try an example from manual: "5 2 +".

  warning: RPN syntax error. Operator ignored as there where only one stack value.
  52 = 52

The GUI version works, though.

Crash in transpose

Try e.g. transpose([[0,0]]) twice.

Aborting long computations can crash

Try e.g. to factor Mersenne prime 2^61-1 and then press enter to abort it. The result is a crash with this message: terminate called without an active exception.

from where does libqalculate retrieve the list of exchange rates?

Where does libqalculate go to retrieve the exchange rates? Does it use HTTPS?

Build failure with clang++/libc++ on Linux

When building with clang++/libc++ on Linux, I get the following error:

In file included from Function.cc:14:
In file included from ./Function.h:15:
In file included from ../libqalculate/ExpressionItem.h:15:
In file included from ../libqalculate/includes.h:47:
/usr/bin/../include/c++/v1/ext/hash_map:213:5: warning: Use of the header <ext/hash_map> is deprecated. Migrate to <unordered_map> [-W#warnings]
#   warning Use of the header <ext/hash_map> is deprecated.  Migrate to <unordered_map>

In file included from Function.cc:14:
In file included from ./Function.h:15:
In file included from ../libqalculate/ExpressionItem.h:15:
../libqalculate/includes.h:54:4: error: invalid preprocessing directive
#               #define unordered_map Sgi::hash_map

In file included from Function.cc:14:
./Function.h:74:2: error: unknown type name 'unordered_map'
        unordered_map<size_t, Argument*> argdefs;

Segmentation fault on nonsensical unit conversions/expressions

Certain combinations of nonsensical unit conversions lead to segmentation faults. These expressions all seem to fall into two categories: 1/(t1+x) to t2 and y/(t1+z) to y/t2, where t1 and t2 are different units of time, x is any non-time unit, and y and z are any units.

Here are some examples:

1/(m+s) to h
cd/(ly+ns) to cd/fortnight
1/(dd+s) to h
1/(m+s) to d

However, this pattern doesn't always hold. Here are some examples which follow the patterns I stated above but don't cause segmentation faults:

1/(m+ms) to h
cd/(mm+ms) to cd/d
1/(dd+ms) to h
1/(m+ms) to d

And here are some more expressions I found in the process of writing this issue that also cause segmentation faults:

m/(ly+fs)
cd/(m+ns)
V/(Gh+Gy) to kd

For reference, I am using qalc from version 2.1.0-1 of libqalculate on Arch Linux.

Mantissa rounded off in Engineering Mode

When I switch to Mode -> Numerical Display -> Engineering, 1/10 results in 1E-3 (the correct result is of course 1E-1). In Scientific and Normal mode the result is correct.
More examples:
1/10 -> 1E-3 (correct: 100E-3)
1/100 -> 1E-3 (correct: 10E-3)
1/1000 -> 1E-3 (correct)
1/10000 -> 1E-6 (correct: 100E-6)
and so on.
2/100 -> 2E-3 (correct: 20E-3)
2.1/100 -> 21E-3 (correct)
2.0/100 -> 2E-3 (correct: 20E-3)

Precision is on 8 (default)
Decimals are not set (default)

Inconsistent parsing of single argument functions in RPN syntax expressions

The parsing of an argument expression for a single argument functions is very surprising when using RPN syntax. When there is exactly one object preceding such function, then everything is working as expected. But if there are any calculations involved - everything breaks apart. So, 9 √ returns 3, but 3 3*√ raises error even if stack is not empty. To make things even more confusing, 3 3*.5^ works just fine. That's definitely a limitation of the parser. BTW, I don't seem to find any way to swap top of the stack. Am I missing something?

To put things into context. I'm trying to find a drop-in replacement for dc. I find it's usage of RPN just perfect for my needs, but it has a very limited set of operations. Qalculate! looks very advanced but sometimes it lacks some very basic conveniences of a decent RPN calculator. If only Qalculate! was on par with it's RPN parsing abilities, nobody would ever need to use that old and rusty dc again.

That's not a complain, actually. Qalculate! has the best balance between a desktop calculator and a general algebra system. I just think that Qalculate! is missing a few important pieces that make it not as well known as it really deserves. Thanks for your continuing work on a very useful application.

Defining functions in qalc

I'm just starting to use it, and qalc is utterly fantastic.

The documentation seems a bit lacking, though. The documentation for qalculate is complete, but it doesn't always say how to do something in qalc. For example, I found out that a variable can be given a value with the := operator, but the qalculate manual only mentions using the menus.
I haven't figured out how to define a function, though. Is it possible to do that in qalc?

Deadlock after calling Calculator::calculate()

The following simple code causes a deadlock for me when using libqalculate v2.0.0.

#include <libqalculate/qalculate.h>

int main() {
  Calculator* pcalc = new Calculator();
  MathStructure result;
  pcalc->calculate(&result, "1+1", 2000);
  delete pcalc;
  return 0;
}

Here is a backtrace showing the issue:

(gdb) thread apply all bt

Thread 2 (Thread 0x7fffee1d5700 (LWP 20434)):
#0  0x00007ffff582c20d in read () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007ffff57bd889 in _IO_new_file_underflow (fp=0x616000000380) at fileops.c:600
#2  0x00007ffff57bc6f8 in __GI__IO_file_xsgetn (fp=0x616000000380, data=<optimized out>, n=1) at fileops.c:1422
#3  0x00007ffff57aebe1 in __GI__IO_fread (buf=<optimized out>, size=1, count=1, fp=0x616000000380) at iofread.c:38
#4  0x00007ffff68a7628 in Thread::read<bool> (this=0x6080000016a0, data=0x7fffee1d49a0) at ../libqalculate/util.h:151
#5  0x00007ffff67bceb0 in CalculateThread::run (this=0x6080000016a0) at Calculator.cc:240
#6  0x00007ffff6aa083f in Thread::doRun (data=0x6080000016a0) at util.cc:783
#7  0x00007ffff6427617 in start_thread (arg=0x7fffee1d5700) at pthread_create.c:456
#8  0x00007ffff583bb8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

Thread 1 (Thread 0x7ffff7f88cc0 (LWP 20356)):
#0  __lll_lock_wait_private () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:95
#1  0x00007ffff57bdeb8 in __GI__IO_un_link (fp=0x616000000380) at genops.c:67
#2  0x00007ffff57be0b2 in __GI__IO_un_link (fp=<optimized out>) at genops.c:92
#3  0x00007ffff57ad98d in _IO_new_fclose (fp=0x616000000380) at iofclose.c:54
#4  0x00007ffff6efdf81 in fclose () from /usr/lib/gcc/x86_64-pc-linux-gnu/7.2.0/libasan.so.4
#5  0x00007ffff6aa0632 in Thread::~Thread (this=0x6080000016a0, __in_chrg=<optimized out>) at util.cc:763
#6  0x00007ffff68de0c7 in CalculateThread::~CalculateThread (this=0x6080000016a0, __in_chrg=<optimized out>) at Calculator.cc:214
#7  0x00007ffff68de0e2 in CalculateThread::~CalculateThread (this=0x6080000016a0, __in_chrg=<optimized out>) at Calculator.cc:214
#8  0x00007ffff67c4a10 in Calculator::~Calculator (this=0x624000000100, __in_chrg=<optimized out>) at Calculator.cc:491
#9  0x00007ffff67c4e02 in Calculator::~Calculator (this=0x624000000100, __in_chrg=<optimized out>) at Calculator.cc:496
#10 0x000000000040170c in main ()

Basically the calculator thread is being shut down without being notified about this.
So it is still stuck in Thread::read<bool>() and will never return making the destruction of the Calculator object impossible.

I don't fully understand this threading/signaling concept but I guess you need something
to unblock this read here in CalculateThread::run():

bool b_parse = true;
if(!read<bool>(&b_parse)) break;

Compute on date/time

Is there a way to compute some operations with date/time (like addition/substraction) ? Like 13h56min12s-1h25min to s ?

Aliases for currencies

It is a bit cumbersome to convert to e.g. czech koruna. Sign isn't supported and code is accepted only as upper case which is not so comfortable to write. (All those $2 outputs are incorrect.)

qalc -t 2$ to czk
$2

qalc -t 2$ to CZK
CZK 48.959957

qalc -t 2$ to Kč
$2

qalc -t 2$ to Kc
$2

qalc -t 2$ to kc
$2

Also full name seems to be missing:

qalc -t 2 DOLLAR to EURO
EUR 1.8119224

qalc -t 2$ to CZECH KORUNA
7.751938((u$*A*C*EC*H*K*N*R*s) / (MA^2 * K*g*m^3))

qalc -t 2$ to CZECHKORUNA
7.751938((u$*A*C*EC*H*K*N*R*s) / (MA^2 * K*g*m^3))

qalc -t 2$ to CZECH_KORUNA
7.751938((u$*A*C*EC*H*K*N*R*s) / (MA^2 * K*g*m^3))

qalc -t 2$ to CZECH KORUNY
7.751938((n$*C*EC*H*K*N*R*s) / (GA*K*g*m^3))

qalc -t 2$ to CZECHKORUNY
7.751938((n$*C*EC*H*K*N*R*s) / (GA*K*g*m^3))

qalc -t 2$ to CZECH_KORUNY
7.751938((n$*C*EC*H*K*N*R*s) / (GA*K*g*m^3))

I noticed that some currencies are way better with tons of synonyms and support of sign. E.g. dollar or euro:

qalc -t 2 dollars to euros
EUR 1.8119224

qalc -t 2$ to €
EUR 1.8119224

It would be nice to have other currencies supported as well (not just CZK).

I think full name is not that important, but a currency sign is nice-to-have and a currency code in lower case is IMO a must.

Milli-inch aliases with minute in CLI

The expression .001 in gets normalized to 1 min by default, but the unit string min is interpreted as minute:

> .001in

  0.001 * inch = 1 min

> 1min to s

  1 * minute = 60 s

In particular, the expression it outputs, .001 * inch = 1 min isn't true by its own evaluation:

> .001 * inch == 1 min

  (0.001 * inch) = (1 * minute) = 0

Probably it should spell milli-inch differently in the output (is there a standard way to disambiguate this sort of thing?)

sh: gnuplot: command not found

I just use qalc from command line but now it's showing that error message.

Add BDT currency

Hi,

Can anyone please suggest how to add Bangladeshi Taka (BDT). Something that I want to do is

> 30USD to BDT

Currently it says

warning: Error(s) in unitexpression.
30 * dollar = $30

Please suggest

error: use of undeclared identifier 'VERSION'

Hi,

i can not build 0.9.8 version Logs can be find here http://file-store.openmandriva.org/api/v1/file_stores/fd65f91fd4726f4705451b0374ef0d5cb6b35a2f.log?show=true

Compiled with LLVM/clang 3.8.1

In file included from ./DataSet.h:15:
../libqalculate/includes.h:18:17: warning: using directive refers to implicitly-defined namespace 'std'
using namespace std;
^
DataSet.cc:754:61: error: use of undeclared identifier 'VERSION'
xmlNewProp(doc->children, (xmlChar_) "version", (xmlChar_) VERSION);
^
1 warning and 1 error generated.
make[2]: *** [Makefile:529: DataSet.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Entering directory '/builddir/build/BUILD/libqalculate-0.9.8/libqalculate'

Calculator.cc:384:2: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
pipe(pipe_wr);
^~~~ ~~~~~~~
Calculator.cc:7589:61: error: use of undeclared identifier 'VERSION'
xmlNewProp(doc->children, (xmlChar_) "version", (xmlChar_) VERSION);
^
Calculator.cc:7667:61: error: use of undeclared identifier 'VERSION'
xmlNewProp(doc->children, (xmlChar_) "version", (xmlChar_) VERSION);
^
Calculator.cc:7835:61: error: use of undeclared identifier 'VERSION'
xmlNewProp(doc->children, (xmlChar_) "version", (xmlChar_) VERSION);
^
Calculator.cc:7996:61: error: use of undeclared identifier 'VERSION'
xmlNewProp(doc->children, (xmlChar_) "version", (xmlChar_) VERSION);
^
Calculator.cc:8200:61: error: use of undeclared identifier 'VERSION'
xmlNewProp(doc->children, (xmlChar_) "version", (xmlChar_) VERSION);
^
4 warnings and 5 errors generated.
make[2]: *** [Makefile:529: Calculator.lo] Error 1

Use abstract syntax tree for parser (long term ambitious idea)

After thinking about last issue discussion some more, I came to conclusion that the current parser architecture is too rigid. Maybe it'd be worth considering converting it to use some form of AST and provide an API for consumers to manipulate it in a real time. That way you could abstract all implementation details like a particular strings, keys and their ordering used for different operations. Then the parser would become more clear and modular. It'd also help to make a libcalculate more of a compiler than a UI.

It's an ambitious idea which requires a major rewrite. But I believe that it'd worth it in a long run. Or maybe it's an overkill, it's up for you to decide. Just a thought.

intltool and gettext

With intltool as part of the build, autoreconf needs to be rerun in a macports environment so that the correct perl is used. Now with the addition of gettext in 2.x, I get this error:
config.status: error: po/Makefile.in.in was not created by intltoolize.
It seems that intltool and gettext cause problems when used together:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724555

Can you fix or suggest a workaround? Thanks.

Compilation error when time_t is not long int

Trying to compile version 2.0.0 on FreeBSD 11.0 i386 (clang 3.8.0). In TimestampFunction::calculate(), mstruct.set(time(NULL), 1L, 0L) will fail to compile if time_t is not of type long int. On FreeBSD 32-bit, time_t is int and there is no function to cover this case. I was able to compile it by casting time(NULL) to long int and qalc produced a correct timestamp.

/bin/sh ../libtool  --tag=CXX   --mode=compile c++ -DHAVE_CONFIG_H -I. -I..  -I.. -DPACKAGE_DATA_DIR=\""/usr/local/share"\" -I/usr/local/include   -I/usr/local/include/libxml2   -I/usr/local/include  -DLIBICONV_PLUG -I/usr/local/include -isystem /usr/local/include  -O2 -fno-strict-aliasing -pipe -march=core2 -DLIBICONV_PLUG -fstack-protector -isystem /usr/local/include  -DLIBICONV_PLUG -isystem /usr/local/include -MT BuiltinFunctions.lo -MD -MP -MF .deps/BuiltinFunctions.Tpo -c -o BuiltinFunctions.lo BuiltinFunctions.cc
libtool: compile:  c++ -DHAVE_CONFIG_H -I. -I.. -I.. -DPACKAGE_DATA_DIR=\"/usr/local/share\" -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include -DLIBICONV_PLUG -I/usr/local/include -isystem /usr/local/include -O2 -fno-strict-aliasing -pipe -march=core2 -DLIBICONV_PLUG -fstack-protector -isystem /usr/local/include -DLIBICONV_PLUG -isystem /usr/local/include -MT BuiltinFunctions.lo -MD -MP -MF .deps/BuiltinFunctions.Tpo -c BuiltinFunctions.cc  -fPIC -DPIC -o .libs/BuiltinFunctions.o
BuiltinFunctions.cc:2524:11: error: call to member function 'set' is ambiguous
                mstruct.set(time(NULL), 1L, 0L);
                ~~~~~~~~^~~
../libqalculate/MathStructure.h:251:8: note: candidate function
                void set(int num, int den = 1, int exp10 = 0, bool preserve_precision = false);
                     ^
../libqalculate/MathStructure.h:252:8: note: candidate function
                void set(long int num, long int den, long int exp10 = 0L, bool preserve_precision = false);
                     ^
../libqalculate/MathStructure.h:276:8: note: candidate function not viable: no known conversion from 'time_t' (aka 'int') to 'MathFunction *' for 1st argument
                void set(MathFunction *o, ...);
                     ^
../libqalculate/MathStructure.h:283:8: note: candidate function not viable: no known conversion from 'time_t' (aka 'int') to 'Unit *' for 1st argument
                void set(Unit *u, Prefix *p = NULL, bool preserve_precision = false);
                     ^
../libqalculate/MathStructure.h:237:8: note: candidate function not viable: requires at most 2 arguments, but 3 were provided
                void set(const MathStructure &o, bool merge_precision = false);
                     ^
../libqalculate/MathStructure.h:258:8: note: candidate function not viable: requires at most 2 arguments, but 3 were provided
                void set(string sym, bool preserve_precision = false);
                     ^
../libqalculate/MathStructure.h:264:8: note: candidate function not viable: requires at most 2 arguments, but 3 were provided
                void set(double float_value, bool preserve_precision = false);
                     ^
../libqalculate/MathStructure.h:289:8: note: candidate function not viable: requires at most 2 arguments, but 3 were provided
                void set(Variable *o, bool preserve_precision = false);
                     ^
../libqalculate/MathStructure.h:295:8: note: candidate function not viable: requires at most 2 arguments, but 3 were provided
                void set(const Number &o, bool preserve_precision = false);
                     ^
1 error generated.
gmake[4]: *** [Makefile:532: BuiltinFunctions.lo] Error 1

libqalculate.so.6 : No such file or directory

Hello!
I've compiled and installed libcalculate 0.9.10 and qalculate-gtk 0.9.9 from source tarball. In both cases I executed:
PKG_CONFIG_PATH=/usr/local/lib/pkgconfig ./configure
make
sudo make install

When I try to run qalc or qalculate-gtk a warning message shows up:
"error while loading shared libraries: libqalculate.so.6: cannot open shared object file: No such file or directory"

I guess some link is missing but I don't know where. libqalculate.so.6 is in "/usr/local/lib/"
My system is linux Mint 18.1 Serena Cinnamon Edition.

Thanks in advance!

Wrong conversion from 1/1ns to GHz?

That doesn't seem to be right:

$ qalc
> 1/1ns to GHz

  1 / (1 * nanosecond) = 1E18 GHz

should be: 1 GHz.

I'm on version 0.9.9

clang and char16_t error on Mac OS X

When building the latest libqalculate (0.9.12) on Mac OS X (10.10.5) via macports, I encountered this error:

libtool: compile:  /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I.. -I.. -DPACKAGE_DATA_DIR=\"/opt/local/share\" -DPACKAGE_LOCALE_DIR=\"/opt/local/share/locale\" -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/libxml2 -I/opt/local/include -pipe -Os -stdlib=libc++ -arch x86_64 -O2 -MT Number.lo -MD -MP -MF .deps/Number.Tpo -c Number.cc  -fno-common -DPIC -o .libs/Number.o
DataSet.cc:17:25: error: typedef redefinition with different types ('unsigned short' vs 'char16_t')
typedef __CHAR16_TYPE__ char16_t;
                        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__config:234:20: note: previous definition is here
typedef __char16_t char16_t;
                   ^
Calculator.cc:27:25: error: typedef redefinition with different types ('unsigned short' vs 'char16_t')
typedef __CHAR16_TYPE__ char16_t;
                        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__config:234:20: note: previous definition is here
typedef __char16_t char16_t;
^

Deleting:

#if (defined(__clang__) && !defined char16_t)
typedef __CHAR16_TYPE__ char16_t;
#endif

in Calculator.cc and DataSet.cc resolved this for me. Perhaps the if statement is not quite right? My version of clang is

$ clang++ --version
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin14.5.0
Thread model: posix

Discrepancies between try exact and approximate

I'm not sure if this was intended or an oversight. The display of a result in try exact and approximate mode is different for calculations with approximate numbers. Try e.g.:

set approximation approximate
pi/2
save v
cos(v*rad)
approximate

Ignore comma in numbers

qalculate-gtk has this option in preferences. How to enable it in command-line qalc? Is there any command line switch for it? If there is, can we get this listed in qalc --help? If not, please treat it as a feature request for qalc.

Get proper exchange rates

Hi,

I'm using the version that came with Kubuntu 17.04: Qalculate! 0.9.9.

When I want to use it for currency conversions, it offers me Euros [€] and only the former currencies, which have now been replaced by euros (e.g. Deutsche Mark). I cannot use any current currencies like British Pounds or US$.

My suspicion is that there is something wrong with fetching the exchange rates from the European Central Bank. It seems to only fetch the frozen exchange rates of those former currencies relative to Euros.

How do I get the list of available functions when using qalc?

I'm using libqalculate right now and I can't find a man page or a any information about the list of available functions when using qalc. Note that I'm not using the GTK version but the CLI version.

Missing functions for manupulating stack in RPN mode

Every RPN calculator should have at least swap and duplicate top operations. Some provide rotate stack as well. Without such functions it's very difficult to arrange ordinary calculations without resorting to memory variables. But these are not part of a stack machine.

parsing of "1 W Ohm /K/K"

Why should 1 W Ohm /K/K be different from 1 W Ohm /K /K? What's wanted in any case is 1 watt ohm kelvin^-2. The first form, however, gives 1 W Ohm and the two kelvins cancel.

Bug parsing simple expression ("-" is not a valid variable/function/unit)

I came across a weird bug while using Qalculate! GTK. Entering the formula

(x-"y")^2 + 2*x*1

yields "2x" because the (x-"y") expression is interpreted as (x * (0 * y)). Note that copy/pasting it does not work, as unicode characters need to be used, more on that on following comments. You can use the expression below for pasting:

(x−"y")^2 + 2⋅x⋅1

In input base >10 only numbers work

When input base is set to anything greater than 10 variables, functions and units don’t work. Parser thinks everything is a number.
In all the examples bellow output is in base 12.

$ qalc -s "input base 10"   
> 20 pi

  20 * pi ≈ 52.9B954

> log(20)

  log(20, e) ≈ 2.BB4761

> 20 a + 10 ha

  (20 * are) + (10 * hectoare) = 710 a

$ qalc -s "input base 8"    
> 20 pi

  16 * pi ≈ 42.32291

> log(20)

  log(16, e) ≈ 2.93304A

> 20 a + 10 ha

  (16 * are) + (8 * hectoare) = 580 a

$ qalc -s "input base 12"   
> 20 pi

  error: Character 'p' was ignored in the number "20pi" with base 12.
  24 * i = 20i

> log(20)

  error: Character 'l' was ignored in the number "log" with base 12.
  error: Character 'o' was ignored in the number "log" with base 12.
  error: Character 'g' was ignored in the number "log" with base 12.
  0 * 24 = 0

> 20 a + 10 ha

  error: Character 'h' was ignored in the number "10ha" with base 12.
  298 + 154 = 318

GTK GUI

I'm trying to install the gui but it requires 0.9.11 version, how it is possible ?

Optimal unit conversion may segfault in certain cases

This bug is relevant to optimal unit conversion. The only case I've found to trigger this bug is the input expression 1/u, or 1.0/u with an arbitrary number of zeroes in the fractional part of 1. Using any other number as the numerator, like 2, 0, or even -1, does not trigger this bug. Replacing the atomic mass unit u with its unit representation gram/mole and using 1/(gram/mole) yields the correct result 1 mole/gram.

To reproduce, enable optimal unit conversion and enter 1/u as input within any libqalculate-based application (qalc, qalculate-gtk, krunner, qalculate plasmoid).
Tested with libqalculate versions 0.9.11 and 0.9.9.

Test case, running qalc under valgrind:

$ valgrind qalc
==23361== Memcheck, a memory error detector
==23361== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==23361== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
==23361== Command: qalc
==23361== 
> set autoconversion base
> u

  atomic_mass_unit = 1(g / mol)

> 1/u

  1 / atomic_mass_unit = 1(mol / g)

> 2/u

  2 / atomic_mass_unit = 2(mol / g)

> 1/(g/mol)

  1 / (gram / mole) = 1(mol / g)

> set autoconversion optimal

  1 / (gram / mole) = 1(mol / g)

> 2/u

  2 / atomic_mass_unit = 2(mol / g)

> 1/u
==23361== Thread 3:
==23361== Invalid read of size 8
==23361==    at 0x55AEDBD: Calculator::getBestUnit(Unit*, bool) (Calculator.cc:2742)
==23361==    by 0x55AEF8D: Calculator::getBestUnit(Unit*, bool) (Calculator.cc:2895)
==23361==    by 0x55BE528: Calculator::convertToBestUnit(MathStructure const&, EvaluationOptions const&) (Calculator.cc:2997)
==23361==    by 0x56034F8: Calculator::calculate(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, EvaluationOptions const&, MathStructure*, MathStructure*, bool) (Calculator.cc:2328)
==23361==    by 0x5603CC8: calculate_proc(void*) (Calculator.cc:221)
==23361==    by 0x5FAD453: start_thread (in /usr/lib/libpthread-2.24.so)
==23361==    by 0x6EDB7DE: clone (in /usr/lib/libc-2.24.so)
==23361==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==23361== 
==23361== 
==23361== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==23361==  Access not within mapped region at address 0x0
==23361==    at 0x55AEDBD: Calculator::getBestUnit(Unit*, bool) (Calculator.cc:2742)
==23361==    by 0x55AEF8D: Calculator::getBestUnit(Unit*, bool) (Calculator.cc:2895)
==23361==    by 0x55BE528: Calculator::convertToBestUnit(MathStructure const&, EvaluationOptions const&) (Calculator.cc:2997)
==23361==    by 0x56034F8: Calculator::calculate(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, Evaucture*, MathStructure*, bool) (Calculator.cc:2328)
==23361==    by 0x5603CC8: calculate_proc(void*) (Calculator.cc:221)
==23361==    by 0x5FAD453: start_thread (in /usr/lib/libpthread-2.24.so)
==23361==    by 0x6EDB7DE: clone (in /usr/lib/libc-2.24.so)
==23361==  If you believe this happened as a result of a stack
==23361==  overflow in your program's main thread (unlikely but
==23361==  possible), you can try to increase the size of the
==23361==  main thread stack using the --main-stacksize= flag.
==23361==  The main thread stack size used in this run was 8388608.
==23361== 
==23361== HEAP SUMMARY:
==23361==     in use at exit: 930,443 bytes in 5,830 blocks
==23361==   total heap usage: 160,603 allocs, 154,773 frees, 11,549,528 bytes allocated
==23361== 
==23361== LEAK SUMMARY:
==23361==    definitely lost: 72,602 bytes in 379 blocks
==23361==    indirectly lost: 0 bytes in 0 blocks
==23361==      possibly lost: 576 bytes in 2 blocks
==23361==    still reachable: 857,265 bytes in 5,449 blocks
==23361==         suppressed: 0 bytes in 0 blocks
==23361== Rerun with --leak-check=full to see details of leaked memory
==23361== 
==23361== For counts of detected and suppressed errors, rerun with: -v
==23361== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
Killed

libqalculate-0.9.9 - qalc.cc:3182:11: error: 'historyfile' was not declared in this scope

Hi,

If Readline is disabled, compilation of libqalculate-0.9.9 fails with:

qalc.cc: In function 'void load_preferences()':
qalc.cc:3182:11: error: 'historyfile' was not declared in this scope
    g_free(historyfile);

Here is a patch to ifdef this line, which was missed:
https://gist.github.com/sugudega/99f6f439c05cb9cf1481498830e01ab3

(Thanks for reviving this project :))

Bye.

Feature request :: new currency :: BTC

Hello, it would be great if Qalculate could make Bitcoin calculations. The BTC/USD and BTC/EUR conversion rates can be retrieved at various places such as Coinbase or Kraken. What do you think?

Trashed parser response

Try

set unknowns off
xyz
set base 10
set angle unit rad

The response from a previous error is repeated every time.

Arithmetic with Celsius

On 0.9.7, 1°C+1°C yielded 2°C (obviously), which converted to Kelvin gave 275.15K. In other words, if you have a temperature of 1 °C and raise it by 1 °C you get 2 °C.
(On the other hand, 1K+1°C yielded 275.15K, which doesn't fit with the description I used.)

On newer versions, however, °C is converted at parse time (which is a bit weird IMO). This results in 1°C+1°C being interpreted as 274.15K+274.15K and thus yielding 548.3K (i.e. 275.15 °C).

I'm aware of the headache that must be dealing with °C and °F programmatically (I've been in that situation before), but I'd suggest fixing this so that it makes more sense. A fix I can think of is to only add the offset to the FIRST occurrence of a temperature, but leave the rest without the extra 273.15K. That way only the first occurrence would be interpreted as an absolute temperature, while the rest would be treated as increments. (This breaks the important concept of commutativity of addition though.)

Additionally, it would be nice if arithmetic done solely with °C yielded a result in °C, not K.

---

And now if you're curious, this is how I solved this issue back in the day when I had to do a similar thing:

• Quantities can be interpreted either as absolute or differential. 1°C means either an absolute temperature of 274.15K or an increment (difference) of 1K.
• Quantities may have an "offset" attribute; for example, a quantity in °C has an equivalence of 1°C=1K and an offset of 273.15K. Quantities internally keep this offset attribute during operations, along with their value.
• Adding 2 quantities preserves the padding of the first one: it assumes the first quantity is absolute and the second one represents an increment. Thus, 1°C+2°C = 1°C+2K = 3°C = 276.15K
• Subtracting 2 quantities preserves the padding of the first quantity as well, so it's not suited for calculating a difference between absolute temperatures: it assumes the second quantity is an increment, not an absolute quantity. (Maybe this wasn't a good idea.)
• Any other operation on quantities (multiplication, division, negation...) discards the offset (it assumes it refers to an increment; for example °C/m means the same as K/m, and cal/°C means the same as cal/K).

I'm not sure if this "extra attribute" thing can be easily implemented with the current libqalculate; probably not. But hopefully making the parser behave like this won't be that hard.

Crash in Calculator constructor on strdup

I got this downstream KDE bugreport in the KRunner ("Run Command") calculator plugin which uses libqalculate: https://bugs.kde.org/show_bug.cgi?id=365117

[RFE] Please add the sinc() function

The sinc(x) function (sometimes abbreviated as si(x) function) is defined as follows:

• sinc(0) = 1
• sinc(x) = sin(x)/x ∀ x≠0

This would be a nice function to be added to libqalculate/Qalculate.

I thought adding this code to category "Trigonometry" in data/functions.xml.in:1195 would be enough:

<function>
	<_title>unnormalized sinc function</_title>
	<_names>r:sinc,r:si</_names>
	<expression>if(\x = 0,1,sin(\x))</expression>
</function>

and it works, so I'll add it in a pull request.

Additional info:
This change is backwards-incompatible. I don't know whether you care about that. Currently, running $ qalc "sinc(pi/2)" will interpret this as sin((speed_of_light * (pi / 2)) * radian) and $ qalc "si(pi/2)" will interpret as second * i * (pi / 2).

PS: Thank you for this useful application/library!

Eats all RAM with calculation with huge result

When I try to calculate the following

2^2^2^2^2^2^2

it starts to eat all RAM until the application is killed. (Using libqalculate 0.9.7-9.1)

Downstream bug report: https://bugs.kde.org/show_bug.cgi?id=277011

qalc segfaults upon exit

qalc is segfaulting upon exit if no commands are issued other than 'help'. If qalc is started and a calculation is performed, it seems to exit normally. Backtrace is from version 1.0.0.

Platform:
FreeBSD 11.0 i386 (clang 3.8.0)

Steps to reproduce:

1. start qalc
2. enter help command (optional)
3. enter exit command

Reading symbols from qalc...done.
(gdb) run
Starting program: /usr/local/bin/qalc 
[New LWP 100449 of process 9739]
> exit

Thread 2 received signal SIGSEGV, Segmentation fault.
[Switching to LWP 100449 of process 9739]
MathStructure::type (this=0x0) at MathStructure.cc:9923
9923            return m_type;
(gdb) bt
#0  MathStructure::type (this=0x0) at MathStructure.cc:9923
#1  0x286fde9c in MathStructure::set (this=0xbbbfde88, o=..., merge_precision=false) at MathStructure.cc:273
#2  0x286fdd5b in MathStructure::MathStructure (this=0xbbbfde88, o=...) at MathStructure.cc:206
#3  0x08112a19 in ViewThread::run (this=0x294e9ce0) at qalc.cc:2828
#4  0x28854c3a in Thread::doRun (data=0x294e9ce0) at util.cc:949
#5  0x282caf2c in ?? () from /lib/libthr.so.3
#6  0x00000000 in ?? ()

No scion

No scion in inventory after Tomb of Qualopec.

Proposal for uncertainty propagation feature

The main feature i notice missing in this very useful, expansive tool is the inclusion of uncertainties, which would extend the usefulness of this calculator into territory that it seems very few have tread previously. The inclusion of uncertainty propagation would allow qalculate to be used in a wider range of problems that specifically focus on "real" data where uncertainties are always present. The only other tool i've found that deals with associated uncertainties transparently and correctly is actually a python library which is likely worth looking at for implementation details here: https://pythonhosted.org/uncertainties/

There are several worthwhile syntax choices to choose from, a simple "number+-error" could be used or a new error(value,error,errortype) function or similar could be used to tell qalculate when a value with an error is being considered. Values with errors would then need to be propagated through error propagation rules, and recognize when the same variable is being used to correctly differentiate between the math for dependent and independent errors.

proposal

It could be better if it was possible to have 10 small windows for entry variables easily. Why limit the size of the input data, when I wrote this :

(sqrt(2)/2−sqrt(0.5⋅cos(pi/4+1e−20)/sin(pi/4+1e−20)))⋅(sqrt(2)+2* sqrt(0.5⋅cos(pi/4+1e−20)/sin(pi/4+1e−20))/cos(pi/4+1e−20)⋅sin(pi/4+1e−20))/2/(2⋅(1*1/2+(sqrt(2)/2/cos(pi/4+1e−20))^2/2)/2⋅1e−20)

it is difficult to read. The size of the screen is not use like it could be.

Why don't add the function IN/OUT/CALC like the Fx850P of Casio it is very useful and if it was possible to have more than one input it could be better.

I use a lot of variables, it takes time to add some variables.

my2cents :)

Infinite recursion

Try this:

set approximation approximate
cos(rad)
ans
exact
ans

The application crashed.

Your autogen.sh uses libtool instead of libtoolize

Hi,

I'm using Debian 8 and it seems your autogen.sh uses libtool instead of libtoolize.

Can you please replace libtool with libtoolize at line 34 of autogen.sh ?

Thank you for your comprehension.