qbcore-framework/qb-diving

Diving Script For QB-Core

qb-diving

Diving Script For QB-Core

[VIDEO]

https://youtu.be/pPYsy1tKPVM

License

QBCore Framework
Copyright (C) 2021 Joshua Eger

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <https://www.gnu.org/licenses/>

qb-diving's Issues

[BUG] Job

Describe the bug
Police call is set to leo and not the job police

To Reproduce
Steps to reproduce the behavior:

1. qb-diving/server
2. line 33

RegisterNetEvent('qb-diving:server:CallCops', function(coords)
for _, Player in pairs(QBCore.Functions.GetQBPlayers()) do
if Player then
if Player.PlayerData.job.type == "leo" and Player.PlayerData.job.onduty then ---> if Player.PlayerData.job.type == "police" and Player.PlayerData.job.onduty then
local msg = Lang:t("info.cop_msg")
TriggerClientEvent('qb-diving:client:CallCops', Player.PlayerData.source, coords, msg)
local alertData = {
title = Lang:t("info.cop_title"),
coords = coords,
description = msg
}
TriggerClientEvent("qb-phone:client:addPoliceAlert", -1, alertData)
end
end
end
end)

diving_gear under water

How to determine the number of minutes under water?
Is it possible to add a feature?
To determine the number of minutes the player was under water?

Can't store boats

So I rent a boat, and when i'm finished I can't give it back or store it so it has to be left out
Also when I buy boats from the dockyard , it takes the money from teh account but I can't store them

Glovbox and trunk

glovbox and trunk boats bought from the boat shop are not save in the database.

cant spawn boat after pull

pls check this pls

[BUG] Selling

When selling the "dendrogyra_coral" or "antipatharia_coral" If you sell 1, you get a random price whatever you made it into. It doesn't matter If you have 10 "antipatharia_coral" you get 1 random price for 10 pieces and I don't think that'r right. Should give you more money.

[2] = {
item = "antipatharia_coral",
maxAmount = 100,
price = math.random(100, 150),
}

[SUGGESTION] drawtext question marks

After this resource was updated its impossible to find the location of the coral without scanning the bottom of the ocean for 20min.

I think adding back the small question marks would make this script better again

Thankyou

Boat depot duping

The depot currently dupes boats that are outside of the boat garage ; take out a boat, leave it in the open, go into the depot and it will dupe it instead of removing the other instance like the car depot would do.

Far boats doesn't spawn at first

if I sell a boat far from all the others it does not spawn until I first go close to the group of other boats in the default port.

[SUGGESTION] Misc Improvements

Is your feature request related to a problem? Please describe.

• Tank time too short
• Hard for players to enjoy this script with no markers/prop spawn (as per PR) when scouring large areas with no long tank times
• Update for oxygen tube doesn't really match up

Describe the feature you'd like

• Change the way oxygen works, make it a config so servers can se it above 100, if I set it above the 100 it seems to make my oxygen go away and I can swim for as long as I want under water
• Add back both the prop spawn as per the PR from June (it doesn't seem to spawn now anyways so needs an update) and also add draw marker option (or something visual for users to see.
• Replace the items needed with two things, an oxygen tank that is already filled, then replace the new fill item to diving gear (so thats the mask/harness/tubes/etc. That way to dive you are simply needing an oxygen tank and the gear, the gear can remain with the player and the tank is the consumable instead.

Describe alternatives you've considered
N/A

Additional context
Here is latest script and how it looks to players trying to find where to dig for stuff: https://i.imgur.com/ugBWNg1.jpeg it's almost impossible without debug on.

Boathouse

Can't store boat in boathouse
The mysql database doesn't change

bug . boat owner name

When buying a marine boat, inquire about the owner of the boat
It appears with a random name, not my name, for example

[Placeholder] Polyzone and Target Conversion

Submarines cannot be stored

Seems the native for IsPedInAnySub(Ped) needs to be added to allow for the DLC submarines to be stored when purchased.

I tried adding addittional locals for local inSub = IsPedInAnySub(Ped) and adding it where inBoat was but still cannot store so not too sure why that would be.

I'd also suggest with the qb-garages consolidation that garages be split out of qb-diving to be handled there too.

bullet proof

wearing a Diving Suit is exploitable as it makes you immune to damage by bullets

Player Report

Change cash being an item

LSYMC Boat depot nd Boathouse do not work

I get this error with a brank new qb-diving repo which has not been edited

https://gyazo.com/883410ec3c44ecb85424f55a46383e6a

[BUG] Longer diving tank time?

Describe the bug
Before the most recent version (as ov 17th June) the tank seems to last a longer time, at the moment we can only do one dive for a single coral before it tells us we have no air? Used to be able to at least do one entire zone before it ran out.

To Reproduce
Steps to reproduce the behavior:

1. Go diving
2. Dive to one spot and it should ping pretty quickly that you have 1 min of air left.

Expected behavior
I guess more air? I did read that tank time is limited in gtav so you can't change it potentially?

Questions (please complete the following information):

• When you last updated: 17th June 2022
• Are you using custom resource? which ones? Nothing that affects tank time
• Have you renamed qb- to something custom? Nope

[bug][fix] diving gear has Collision that the player not take damage

i found a bug inside qb-diving, when you wear it you can't take headshot damage and backside

the script owner should fix it by:
SetEntityCollision(MaskObject, false, false)
put under this line MaskObject = CreateObject(maskModel, 1.0, 1.0, 1.0, 1, 1, 0)

and SetEntityCollision(TankObject, false, false)
under this line TankObject = CreateObject(tankModel, 1.0, 1.0, 1.0, 1, 1, 0)

[BUG] Godmode bug

Describe the bug
When a player have a diving suit on the prop blocks bullets from hitting the players hitbox and in return gives the player "godmode" in the head and chest.

To Reproduce
Steps to reproduce the behavior:

1. Put on the diving suit
2. Shoot the player with a gun in the head or upper chest

Expected behavior
The player takes damage

Fix
A possible fix to this would be to use the rebreather mask. This is a clothing item and will not give the player "godmode"

[BUG] Issue with the diving gear

The old diving doesnt work with the update, it just gives the error of "you need an oxygen tube"

[BUG] Pricing config missing?

Describe the bug
Checking if this should be missing.

Just testing a PR and noticed on sell that I was getting an error about comparing the price to nil.

Looking at the config it seems to be missing the min/max on the config, not sure if this is ok to be missing or such?

qb-diving/config.lua

Line 279 in 7392beb

minAmount = 16,

add LocalPlayer.state:set("inv_busy" when sell coral items

add LocalPlayer.state:set("inv_busy" when sell coral items
i can open inv and drop item