qbcore-framework/qb-garbagejob

Garbage Job For QB-Core

Garbage Job V2 For QB-Core

Rework Update

• Job now pays per bag delivered on a configured scale.
• Job Randomises the amount of stops and what stops the user goes to
• Job traks rewards on the server rather than client
• Optional Cryptostick find per stop
• Highly Configurable.

License

QBCore Framework
Copyright (C) 2021 Joshua Eger

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <https://www.gnu.org/licenses/>

qb-garbagejob's Issues

[BUG] Job Blip not clearing when changing job.

Describe the bug
A clear and concise description of what the bug is. A stranger to qbcore should be able to read your bug report and understand how to reproduce it themselves and understand how the feature should work normally.

RegisterNetEvent('QBCore:Client:OnJobUpdate', function(JobInfo)
    playerJob = JobInfo
    if playerJob.name == "garbage" then
        if garbageBlip ~= nil then
            RemoveBlip(garbageBlip)
        end
    end
    setupClient()
    spawnPeds()
end)

should be

RegisterNetEvent('QBCore:Client:OnJobUpdate', function(JobInfo)
    playerJob = JobInfo
  
     if garbageBlip ~= nil then
            RemoveBlip(garbageBlip)
    end
    setupClient()
    spawnPeds()
end)

Coop Garbage Collection and Secondary Objectives

Suggestion:
Make it possible for more players to work on the job simultaneously, so that they work similarly to a real garbage collection crew, with one driver and 1~3 collectors. Complementary, make the bags by the road "grabable" by the players, so that they can do it as a side objective (secondary trash bags) of the main goal (the trashbags on the waypoints), getting a small bonus per bag.

Reasoning:
It could become a good incentive for the players to go clean up the city in small groups, creating more roleplaying opportunities and making the job more dynamic.

How it would work:
Up to 4 players with the garbage collector job should enter the same Trashmaster, synchronizing their objectives for the main and secondary bags collected in the job, with a bonus for the secundary bags calculated by adding a +1 increment to a "bonus payment counter" per bag.

After the crew decides to finish their work for the day, when the truck is returned, the payment will be calculated by multiplying the "bonus payment counter" of the truck (ensuring that the amount of bags is correct, and that none of the other players would lose part of their bonus by being outside of the truck's radius for a few times) by the defined value per bag ($5, for example), and divided by the number of players that participated in the collection.

Potential issues/solutions:
Verifying the work done:
All players should enter the truck as driver/passengers to be validated as part of that crew, with a maximum of 4 players. This would ensure that, if one of the players isn't present while the truck is returned, the remaining players should still get their bonus.

Ensuring that no other player hops on the truck and gets a share from someone else's work:
All the original players would get flagged as "crewmembers" for that truck, so any other player wouldn't get any objectives completed just by being nearby, getting on the truck midway or at the end of the run. This could be done automatically or through commands.

Example of the bags that would be picked up as secondary objectives of the job.

[BUG] When i spawn the trash truck it is locked and we can not get into it ?

Describe the bug
A clear and concise description of what the bug is. A stranger to qbcore should be able to read your bug report and understand how to reproduce it themselves and understand how the feature should work normally.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Use this item '....' (item's name from shared.lua if applicable)
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Questions (please complete the following information):

• When you last updated: [e.g. last week]
• Are you using custom resource? which ones? [e.g. zdiscord, qb-target]
• Have you renamed qb- to something custom? [e.g. yes/no]

Additional context
Add any other context about the problem here.

[Placeholder] Polyzone and Target Conversion

Since latest build you dont teleport into truck after requesting a truck![BUG]

You dont spawn inside truck after requesting a truck! Truck does spawn but you can't enter it! No errors in console nor serverside

ending mid-route

currently you have to finish the route in order to be paid, would it be possible to return it midroute and get paid accordingly

Not getting keys on starting job[BUG]

When you click get a route it spawns truck but does not give you the keys

Do a fresh install of QB-core server from Tx admin in zap hosting

Get in the truck and go to the first stop

Screenshots
***The Doors are locked

Questions (please complete the following information):

• When you last updated: month ago
• Are you using custom resource? which ones? qb-target
• Have you renamed qb- to something custom? no

Additional context
Add any other context about the problem here.

Did not get keys from garbage job [BUG]

Describe the bug
When i try to request route vehicle spawn but i can not get in because i dont get any keys

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Garbage Job'
2. Target and Click on 'Ped and Request Route'
3. See error in console

Expected behavior
Get keys of vehicle.

Screenshots

Questions (please complete the following information):

• When you last updated: this month
• Are you using custom resource? which ones? zdiscord, ps-fuel
• Have you renamed qb- to something custom? No

If you do not have a truck it will spam "You have no truck!"

customs Car's paint isnt saving.

so i have a rmodgtr50 everytime i pull it out it change's the color of the car to what ever color option it has each time. yesterday my car was black and now today its red and black

[BUG] Vehicle spawn with damage

The vehicle spawn with damage
I add this on line 405 in the main.lua (client side) to correct the problem

SetVehicleFixed(veh)

[BUG] Cant change the garbage truck in config.lua

Describe the bug
Config Vehicles will not change the garbage truck

To Reproduce

[SUGGESTION]

please add clothings in the config and into the script , so we can put custom clothes for the job when you go on duty!

[BUG]

Did a fresh install today and testing out this job as it doesn't appear the garbage truck when I request a route. It just takes $250 away from my account and that's it. I'm running the latest version of it as well.

bug: drawtext and notifications stacking

As you do more jobs, the notifications and 3dtext stack.
Notifications: https://i.imgur.com/mLcXh0r.png
3d Text : https://i.imgur.com/ouJ6yjb.png | https://i.imgur.com/Ofzan3G.png | https://i.imgur.com/SJANvPk.png

Props Issue [BUG]

When you get the garbage job, you go to the mark on the map, the trash bag props dont spawn, you have to guess what area to third eye, and when the eye changes colors, you can pick up thrash, would like for the props to spawn so people know what to third eye.