qgears/qgears-review-tool

Simple tool for performing code review on large Java code basis.

qgears-review-tool's Issues

Automating refreshing views

If a new review is created for a file, the following view updates should be performed without user interaction:

• removing the file from the review-related 'Todo list' if status is set to OK by the user
• icon in the review tool main view

Horizontal scroll bars missing in 'Review tool main view' and 'Todo list'

In Eclipse views, horizontal scrolling is generally possible if content is wider than the container - this behaviour must be the same in QGears Review tool views, too.

Stats export and table ordering

'Review source set statistics' table has to support:

• sorting by arbitrary columns
• exporting results

Marker for files in the 'Review tool main view' that are not present in the workspace

Title says it all.

Note: if a file is double-clicked in the 'main view', an class chooser dialog appears with no opcions to choose from.

Another option: there should be a filter that hides the non-present files.

Automatic file opening when clicking on a class in the 'Review tool main view'

In case the source code of a class occurs only once in the workspace, it should be opened without opening the Eclipse class selector window, if the user double-clicks on it in the 'Review tool main view' or in the 'Todo list'.

Bug in synchronization of selection in the 'Review tool main view' and the editor

A file may appear in multiple source sets.

When the editor gets focus, the first hit is selected in the 'Review tool main view', even if the first hit is in a collapsed source set. This is acceptable if all the source sets are collapsed or the edited file is present only in a collapsed source set, but if only one source set is open (i. e. is in a non-collapsed state), containing the file, the file should be selected in that very source set.

There is a workaround indeed: hiding the unneeded source sets.

Confusing naming of configuration option

The value of the property currently called 'review_username' in the root configuration file (also referred to as the 'source folder mapping properties file) is only used for determining the output directory for newly created reviews, so it should be renamed appropriately, such as 'review_output_dir_postfix'.

Resolution of user name to real name in report

Review report should contain real names of reviewers instead of user names or nick names.

Synchronization of selection in the 'Review tool main view' and the editor

There is a 'Link with editor' button on the top of the 'Review tool main view', but the edited file does not become selected on the list even if it the 'Link with editor' button is toggled.

Simplifying setting: annotationsfolder.#

No per-user annotationsfolder entries are required; one name should be present for this purpose. It should also be either implicit or be a per-reviewproject setting.

Automating configuration

create working sets:

• one for the review configuration files
• auto import projects into the workspace, which are subject to review by config. files and file sets
• import the review config folder as eclipse project

more informative error messages required

More informative error messages should be presented to users, such as in the cases below:

• when a file set, declared in the config files, is empty, although it should not be at the intended use
  • pom file set: when a in a pom file is declared, validation should be performed whether it is a valid, existing, resolvable directory or not
  • unresolvable variable: besides including the variable name in the error message, its containing file should be written out, too
• error and warning messages, in general, should be integrated into the approriate Eclipse views instead of loggers and stdout.

Create complete configuration from selection and/or working set

It should be possible for the user to create a review configuration of the selected elements of package explorer or navigator etc. views.

The review tool should explore the covered repositories and file system paths and either add them all to an existing review configuration file or create a new one.

Old review dialog: finish button should be inactivated

If an old review is opened from the main view, the 'Review entry details' dialog appears. The 'Finish' and 'Cancel' buttons are both active. Only the 'Cancel' sould be active, as 'Finish' conventionally refers to applying changes, but in the case of viewing old reviews, no change will be applied.

Source files referred by a <module> element of POM file set will not be listed if referred by pom xml file name instead of module name

If a <module> element of a pom.xml refer directly to another pom XML descriptor by its relative file name, instead of directory name only, the source files of the referred module will not be listed and no warning will appear on this.

Example of currently non-resolvable reference in a POM descriptor:

...
<module>../../projectname/pom_alternate.xml</module> 
...

Being a file or a directory of the referred element should be added.