Giter Site home page Giter Site logo

tuner's Introduction

tuner's People

Contributors

qiuxiang avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

tuner's Issues

Doesn't seem to work on an iPhone in any browser

It seems very close to working in Safari.
It asks for microphone permission and then sits at 440 Hz.

screen shot 2018-03-15 at 2 14 44 pm

Any ideas about how to get it working? I'd love to help out also if you can point me in the right direction.

Notes above the 5th Octave

Hello @qiuxiang I need to measure up to C7, so I tried increasing maxOctave to 7 n note.js (and up to 10) but found that after C#6, D6 through to B6 records as the 5th octave (D5-B5), until I get to C7. Can you suggest something I can try to resolve this issue?

too sensitive

Hello, i have tried with my phone but this tuner is picking so much noise from background it is pretty useless unless you are alone in a quite room. Is there any way to adjust sensibility?

Thanks

Providing themes

This works just fantastic. Thanks!

One suggestion, different apps provide https://github.com/gstraube/cythara/tree/master/app/src/main/java/com/github/cythara/tuning themes. Maybe this can also support a very lightweight instruments' notes frequency definition? This would help on less known/local instruments not aligning perfectly with chromatic notes and western instruments. For example Setar, a Persian local instrument, has a frequency configuration like this per this:

C3: 244
G2: 183
C3: 244
C2: 122

(not sure about the terminology used here)

跑不了

您好,无论是您的网站,还是我的本地/服务器都跑不了. 浏览器:Firefox/Chrome都试过了. 就一直停在440Hz A4 不动了

望早日修复.谢谢:)

Can't run correctly on linux system

It's an awesome project, I love it so, till I got some problem when I tried to put your whole project on my server (linux CentOS 7.6), It's very confused me when I run this project on your github page (https://qiuxiang.github.io/tuner/app/), it's running perfectly and everything is so fine.

The problem is:
I use nginx to locate the 8880 port to "index.html" , but it alert an error message: 'getUserMedia is not implemented in this browser'
and 'TypeError: Cannot read property 'call' of undefined'.

I'm sure that I upload all the files of your project to my server. Could you pls to give me some advice when you are free? thanks!
1
2

A small change In css changes the pitch recognition result

Hi. It's good tuner, but I met 2 problem with adapting it to my site.

  1. When I remove the position property from the class .notes, this element remains in the center of the page, but the A4 base note moves to the left and the letter D5 appears in the center of the element. And all further notes come with an offset.
    image
  2. How to change the frequency-bars scale correctly?
    I changed its width, but apparently now the high and low frequencies are not visible. And where in the code is it better to unlink them if I need to remove them?
    Can you help with this?

lower notes

Hi, really good tuner. It doesn't get accurate under A1 even after setting const minOctave = 0 in notes.js

Standard pitch A'

Hi @qiuxiang, great work with this tuner!

Which standard pitch A' did you use as default setting in this tuner? Usually musicians in an orchestra agree on a standard pitch A' like 443 hz. Others agree on 440 or 442. Is there a possibility to set this before tuning?

想在vue项目上使用aubio.js

你好,我想在我的vue项目里面使用aubio.js,但是出现了一点问题,不知道您是否能帮我解答一下,谢谢
刚开始,我先在普通的html文件里面引入模块进行测试(代码省略了中间的细节)

<script type="module">
    import { Module } from './aubio.js'
    var pitchDetector = new (Module().AubioPitch)('default', bufferSize, 1, audioContext.sampleRate);
</script>

测试成功了

然后我在.vue文件了引入了这个模块(不知道您知否了解vue框架)
刚开始报错这个

Uncaught (in promise) TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them

这个报错是因为babel强制使用了严格模式,所以我在工程里添加了babel-plugin-transform-remove-strict-mode这个包,并且把.babelrc文件修改为下面的代码

{
  "presets": [
    ["env"],
    "stage-3"
  ],
  "plugins": [
    "transform-remove-strict-mode"
  ]
}

这个报错消失了,但是出现了另外一个报错

Uncaught (in promise) TypeError: (0 , _aubio.Module)(...).AubioPitch is not a constructor

我觉得可能是因为我对js模块化编程还不够了解,用法出问题了才导致这种情况
感谢您的解答!

trying to use pitch detect but failing

in index.html

<script src="https://unpkg.com/aubiojs"></script>

I have this in ts (ignore the name, this is not a worklet, it starts one , now that scriptnode is deprecated), using your .d.ts file

class PitchDetectWorklet {
    audioContext!: AudioContext;
    running: boolean = false;
    pitchWorklet!: AudioWorkletNode;
    cb: (note: number, freq: number) => void;
    options: PitchDetectOptions;
    stream!: MediaStream;
    aupitch!: Pitch;  <<<<==
    au!: Aubio; <<<< ====

and then

        this.au = await aubio();
        this.aupitch = new this.au.Pitch('default', 128 * (this.options.buffersize || 10), 1, this.audioContext.sampleRate );

this all works fine.

But then when I get a buffer from my worklet I do

                var buff = ev.data.buff;
                var freq = that.aupitch.do(buff);

I always get

   Uncaught RuntimeError: null function or function signature mismatch
at 00068a0a:0x15c89
at 00068a0a:0xe02b
at Pitch$do [as do] (eval at Gb (aubiojs:38:242), <anonymous>:9:10)
at MessagePort.pitchWorklet.port.onmessage (worklet_caller.js:34:51)

I think I have copied everything from your tuner demo. I have run out of ideas

fails edge and chrome

chrome gives better debug stack

    local.get $var1
    i32.load offset=8
    local.get $var1
    i32.load offset=4
    local.get $var1
    i32.load offset=12
    i32.load offset=40
    call_indirect (param i32 i32 i32) <<<<<===== 15c89
    local.get $var1
    i32.load offset=8
    local.get $var1
    i32.load offset=12
    f32.load offset=52
    call $func92
    i32.const 1
    i32.eq
    if
      local.get $var1
      i32.load offset=4
      i32.load offset=4
      f32.const 0.0

想做一个古筝的调音

想做一个古筝的调音,但好像是需要一个新的aubio.wasm ,请问页面上频率是从哪里算出来的?

Vue 3

Hi,

Really love your guitar tuner.

Would anyone possibly help me embed this in a Vue 3 project?

Doesn't run when I open in local file

Hello. My issue is: I have downloaded your code in a .zip file, I'm trying to test it but it won't work when I open the index.html, it does not even ask for permission to use my microphone. I have other projects in my PC using "getUserMedia"/JavaScript that run normally, I don't understand what the issue is.

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.