qmathe/dropdownmenukit

UIKit drop down menu, simple yet flexible and written in Swift

dropdownmenukit's Issues

Please provide support for Swift Package Manager

The title says it all.

Thank you.

DropDownMenu Title is overlapping

I am using your framework. I have an issue though. My drop down menu title is overlapping with the right bar buttons. How to solve this issue?

Inheritance is forbidden

required public init?(coder aDecoder: NSCoder) {
	    fatalError("init(coder:) has not been implemented")
	}

wtf? I want to create a cell with xib file but I can't because of this useless code

issue when working with MBProgressHUD

on cell.menuAction selector like this:
func choose(_ sender: AnyObject) {
titleView.toggleMenu()
showHud();
hideHud();
}
and the dropMenu animation will be strange.

UIViewAnimationOptions' has been renamed to 'UIView.AnimationOptions'

UIViewAnimationOptions' has been renamed to 'UIView.AnimationOptions'

Centering text + image

Depending on text size the collapse image and text are not centered ...

Pod Build fails with current version of Swift

Integrated the framework via Cocoapods. When I build my project this framework lists 20 or so errors. Would love to use this library, could you guys take a look and build it with the latest Xcode and Swift, and update the pod spec to use the latest version? Thanks. @qmathe @grifas

Use in Objective-C code?

I have a project which combines both swift and objective-c code. How to import it into objective-C code correctly - it can't find the path?

spam on DropDownTitleView

When i quickly multiple tap DropDownTitleView it seem to create a thing. where u need to multiple tap in order to get it to drop down?

DropDown doesn't work on iOS 11 device

The dropdown menu is not clickable and looks much smaller on iOS 11 devices.

Broken cocoapods

You specified "swift 4.2" in podspec but in the same time by default the pod install command ignores master and downloads branch for "4.1"

Translation to Russian

Hello
I've translated the readme into Russian. Could you please add a link to it into readme?
http://gargo.of.by/dropdownmenukit/

The Dropdownmenu won't scroll when too many items

I'm using this array with 19 items on it, some items are then listed outside of the iphone screen and the menu don't scroll so users can't reach the 19th elements of my array ...

["Alimentaire","Artisanat","Bien-être","Décoration","E-commerce","Distribution","Hôtellerie","Immobilier","Informatique","Métallurgie","Médical","Nautisme","Paramédical","Restauration","Sécurité","Textile","Tourisme","Transport","Urbanisme"]

The code I used to dynamically load array into your menu from your demo project

`func prepareNavigationBarMenu(_ currentChoice: String) {
navigationBarMenu = DropDownMenu(frame: view.bounds)
navigationBarMenu.delegate = self

	let toutesCat = ["Alimentaire","Artisanat","Bien-être","Décoration","E-commerce","Distribution","Hôtellerie","Immobilier","Informatique","Métallurgie","Médical","Nautisme","Paramédical","Restauration","Sécurité","Textile","Tourisme","Transport","Urbanisme"]
    var catCells : Array<DropDownMenuCell>
    catCells = []
    
    for string in toutesCat  {
        
        let cell = DropDownMenuCell()
        cell.textLabel!.text = string
        cell.menuAction = #selector(ViewController.choose(_:))
        cell.menuTarget = self
        if currentChoice == cell.textLabel!.text {
            cell.accessoryType = .checkmark
        }
        
        catCells.append(cell)
    }
    
    navigationBarMenu.menuCells = catCells
    navigationBarMenu.selectMenuCell(catCells.first!)
	
	// If we set the container to the controller view, the value must be set
	// on the hidden content offset (not the visible one)
	navigationBarMenu.visibleContentOffset =
		navigationController!.navigationBar.frame.size.height + statusBarHeight()

	// For a simple gray overlay in background
	navigationBarMenu.backgroundView = UIView(frame: navigationBarMenu.bounds)
	navigationBarMenu.backgroundView!.backgroundColor = UIColor.black
	navigationBarMenu.backgroundAlpha = 0.7
}`

Screenshot :

hide when choose a cell

Hi,

Where it's best to close the DropDownMenu when you have selected a item Cell? Now you have to select the titleView or the Menubackground

Swift 3

it'd be cool to have a swift 3 version, if you have any interest to create a branch i would like to help with that.

Check for empty cells is missing from pod install version in DropDownMenu class

Hello,

Thanks for nice lib.
Yesterday I have faced following issue.
In the GitHub version in master branch I have noticed that in DropDownMenu.swift file line 156 there is if statement for checking empty cell case before scrolling tableview:

	contentView.frame.size.height = menuView.frame.height

	// Reset scroll view content offset after rotation
	if menuView.visibleCells.isEmpty {
			return
		}
	menuView.scrollToRow(at: IndexPath(row: 0, section: 0), at: .top, animated: false)

But when I have pod install on my project I notice that this statement is missing from source code and it cause exception at runtime when DropDownMenu does not have any cell.

Could you please help me get last version via pod install?

My podfile is:
pod 'DropDownMenuKit'

Error retrieving icon from bundle

Hi,

in some cases this pod can raise an error (and cause a crash) when retrieving an icon from the xcassets file.

This happens when you subclass DropDownTitleView, therefore the pod can't retrieve the bundle in which the icon is supposed to be and finally crashes trying to unwrap a nil value.

The fix is very easy: DigitalGoal-Ltd@e98532c

Default selecting a row.

Don't know whether this is related to the repository itself, however i believe that this feature would be useful.

i've tried with following code, but does not seem to work.

override func viewWillAppear(_ animated: Bool) {
    super.viewWillAppear(animated)

    let rowToSelect = IndexPath.init(row: 0, section: 0)

    navigationBarMenu.menuView.selectRow(at: rowToSelect, animated: false, scrollPosition: .none)

    // Calling manually to the delegate method
    navigationBarMenu.tableView(navigationBarMenu.menuView, didSelectRowAt: rowToSelect)
}

How can I change the color of drop image or up image?

Hi, I have tried to use "titleView.menuDownImageView.tintColor = UIColor.white" but it didn't work. The color was still black. Any other ideas to change it?

Do you have an example code for the 'sort' drop down you show in the screen shot?

the version where there is up and down arrows and also the segment where you select what you want to sort on? Its spot on what I'm looking for.

Thanks

Creating Sections

Hi

Just wondering if it is possible to create sections with section headers like in a UITableView?

Thanks

Feature request - overlay view in outer view controller

In my case UITabBarController is root. So if I add this control into inner navigation bar then it won't overlay UITabBar and UITabBarController is still clickable

Menu and container not released

Variable 'container' in DropDownMenu.swift (line 23) is strong reference, therefore when container is removed from view hierarhy it maintains referenced by DropDownMenu and can not be destroyed.
Solution: make container weak reference and perform necessary checks in methods show, hide and visibleContentOffset.didSet

Drop Down Menu does not work in a popup

I have a issue when using the drop down menu in pop up and choosing a cell: I get the following error:

Could you please provide a solution for it? Thank you in advance

Title view collapses on the size of the first item.

Hello, I've got an issue with the DropDownTitleView, it seems to fix it's size to the first assigned text.

Even when constructing the view with a way to large frame I run into the same issue:

DropDownTitleView(frame: CGRect(x: 0, y: 0, width: 400, height: 40))

Images say more than words:

Do you have a recommendation how to solve this issue?

And a big thank you for the work you have put into this UI component.

Table view not filled

Hi,
I fetch my data asynchronously and I fill the menuCells once I have it. My issue is the table view is not filled or may be is not displayed.

Have you a solution ?