qonto / activejob-lockable Goto Github PK

View Code? Open in Web Editor NEW

8.0 11.0 5.0 23 KB

Gem to make jobs lockable

License: MIT License

Ruby 98.93% Shell 1.07%

ruby activejob lockable rails

activejob-lockable's People

Contributors

Stargazers

Watchers

Forkers

tzzzoz stackshareio jcleira

activejob-lockable's Issues

`on_locked_action` is not triggered if job is not `locked?` but `lock!` fails

When calling enqueue, locked? will check the existence of the key in Redis, and if it's not present will then call lock!

These two calls (locked? and lock!) are not atomic, so a lock could be acquired in the meantime, and the lock! would fail. However, in this case we're not calling the on_locked_action method

It sounds like we should, but maybe there are some implications that I haven't considered (ex: should we call on_locked_action if Redis is offline?). Thoughts?

CI currently not working (bundler version)

I believe we need to update the bundler version (and possibly others) on Travis:

Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.15)
  Current Bundler version:
    bundler (2.1.4)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

Recommend Projects