qorelanguage/module-xml

Qore XML module with SAX and DOM XML parsing support as well XML-RPC and SOAP support

module-xml's Issues

Tests fail with qore "0.9.0"

Some of the module-xml tests fail. I'm using the latest development qore "0.9.0" version (which I believe is also used by jenkins). I'm not sure whether the problem is in qore or this module or in the tests but I suppose the tests used to work correctly in the past.

QUnit Test "SalesforceTest" v1.0
Skipped: account: 0 assertions
Skip requested at Salesforce.com.qtest:122 [SalesforceTest::accountTests()]
-----
	>> no Salesforce.com connection
-----
ERROR: salesforceSoapConnectionTest: 7 assertions
Unexpected exception: PARSE-ERROR at Salesforce.com.qtest:274
-----
	>> System exception: Salesforce.com.qtest:274: PARSE-ERROR: parsing can only happen once for each Program container
	>> call stack:
	>>   Program::parse() called at Salesforce.com.qtest:274 (builtin function)
	>>   SalesforceTest::checkPreAndPostProcessing() called at Salesforce.com.qtest:258 (user function)
	>>   SalesforceTest::salesforceSoapConnectionTest() called at /usr/share/qore-modules/0.9.0/QUnit.qm:450 (user function)
	>>   call_function_args() called at /usr/share/qore-modules/0.9.0/QUnit.qm:450 (builtin function)
-----
Ran 2 test cases, 1 succeeded, 1 error (7 assertions)

QUnit Test "SoapClientTest" v1.0
ERROR: SoapConnectionTest: 10 assertions
Unexpected exception: PARSE-ERROR at SoapClient.qtest:355
-----
	>> System exception: SoapClient.qtest:355: PARSE-ERROR: parsing can only happen once for each Program container
	>> call stack:
	>>   Program::parse() called at SoapClient.qtest:355 (builtin function)
	>>   SoapClientTest::checkPreAndPostProcessing() called at SoapClient.qtest:339 (user function)
	>>   SoapClientTest::soapConnectionTest() called at /usr/share/qore-modules/0.9.0/QUnit.qm:450 (user function)
	>>   call_function_args() called at /usr/share/qore-modules/0.9.0/QUnit.qm:450 (builtin function)
-----
Ran 4 test cases, 3 succeeded, 1 error (66 assertions)

QUnit Test "XmlTest" v1.0
Segmentation fault (core dumped)

GlobalWeather test always fails

GlobalWeather depends on http://www.webservicex.com/globalweather.asmx which currently returns
{"code":"PAGE_NOT_FOUND","message":"Page not found"}
And thus the test fails.

I suggest disabling the test at least for now and maybe removing it later if the service doesn't get back up. Or maybe we can even remove it completely to get rid of a test dependent on an external resource.

the WSDL module does not implement default namespace handling for unprefixed elements or types

ex:

<schema targetNamespace="N1" xmlns="http://www.w3.org/2001/XMLSchema" xmlns:tns="N1">
      <element name="Root">
        <complexType>
          <sequence maxOccurs="1" minOccurs="1">
            <element name="ELEMENT" maxOccurs="unbounded" minOccurs="1">
              <complexType>
                <sequence>
                  <element name="COMPANY" maxOccurs="1" minOccurs="1" type="string"/>
                  <element name="RDA" maxOccurs="1" minOccurs="1" type="string"/>
                  <element name="STATUSRDA" maxOccurs="1" minOccurs="1" type="string"/>
                </sequence>
              </complexType>

The wsdl module fails to parse the SalesDataInterface_v13.wsdl file.

The error can be reproduced by running the following simple script:

#! /usr/bin/env qore
%requires SoapClient
%new-style

ReadOnlyFile f('<a_path_to>/SalesDataInterface_v13.wsdl');
my string s = f.read(-1);
WebService w(s);

makeXMLString() docs points to a non-existent replacement

makeXMLString(string key, hash h, *string encoding) is deprecated and recommends using get_xml_string() instead. However get_xml_string() does not exist. I believe make_xml() is the proper replacement.

BTW, the other version of makeXMLString(hash h, *string encoding) recommends make_xml() correctly.