Giter Site home page Giter Site logo

qtranslate / qtranslate-xt Goto Github PK

View Code? Open in Web Editor NEW
546.0 546.0 103.0 17.35 MB

qTranslate-XT (eXTended) - reviving qTranslate-X multilingual plugin for WordPress. A new community-driven plugin soon. Built-in modules for WooCommerce, ACF, slugs and others.

License: GNU General Public License v2.0

CSS 0.91% PHP 88.41% JavaScript 10.68%
i18n php qtranslate-x wordpress wordpress-plugin

qtranslate-xt's People

Contributors

alphp avatar benique avatar charroma avatar chsxf avatar dallaslu avatar ddon avatar earthlingdavey avatar erichk4 avatar estim avatar funkjedi avatar herrvigg avatar isoph avatar johnclause avatar juje avatar komarovski avatar kuchenundkakao avatar maurizio-omissoni avatar mweimerskirch avatar nb000 avatar pedro-mendonca avatar picasso avatar pjrobertson avatar sdellenb avatar spleen1981 avatar sviluppomania avatar timidrobot avatar tusko avatar ukasiu avatar vallsargente avatar vincequeiroz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

qtranslate-xt's Issues

Changing navigation menus is broken

Issue by tsparber
Monday Jan 12, 2015 at 21:41 GMT
Originally opened as qTranslate-Team/qtranslate-x#4


Hi,

I noticed, that adding new Pages to a Menu breaks the translation.
Upon saving the now changed menu every old translation gets deleted.

Step 1: Create a new test menu /wp-admin/nav-menus.php
Step 2: Add some pages
https://www.dropbox.com/s/sltppu1khin1btc/Screenshot%202015-01-12%2022.29.12.png?dl=0
Step 3: Add more pages
https://www.dropbox.com/s/kr9uxyze44dtkc8/Screenshot%202015-01-12%2022.29.30.png?dl=0
https://www.dropbox.com/s/gkusl97zj1nmd7n/Screenshot%202015-01-12%2022.36.45.png?dl=0
Step 4: Save Menu
https://www.dropbox.com/s/8idafcrp1zvj39m/Screenshot%202015-01-12%2022.29.40.png?dl=0

As you can see only the default language (and the translations of the last item) are preserved.
I'm fine with the ... tags, but preserving these upon adding new items would be great 👍

RFC: Highlight translatable fields

Issue by mweimerskirch
Monday Feb 23, 2015 at 20:02 GMT
Originally opened as qTranslate-Team/qtranslate-x#30


I really like that qtranslate-x supports translating custom (meta) fields. However, it is not always clear, which fields are translatable, and which are not.
This could be improved upon by visually highlighting the translatable field. For example with a small flag icon in at the top right of each field. Like this maybe (option 1):

image

There are probably better ideas for highlighting the fields, but this is just a first idea. What do you think?

Language .pot file

Issue by pedro-mendonca
Monday Jan 12, 2015 at 15:30 GMT
Originally opened as qTranslate-Team/qtranslate-x#3


qtranslate.pot catalog is too old.
I've started with .pot from the very good mqTranslate and most strings are the same, way more than original qtranslate.pot.
Please update .pot file so that we can keep up with the translations.
Great work by the way, hope this will be the future of qTranslate platform, with all childs merged into one :)
I'm very happy with this joint solution.
Best regards
Pedro Mendonça

Re-Open Issue "Default language can't be chosen" (#33)

Issue by kuchenundkakao
Thursday Feb 26, 2015 at 18:17 GMT
Originally opened as qTranslate-Team/qtranslate-x#49


Hi, i'm pretty new to the higher functions of github, so i'm not sure if commenting to a closed issue reopens them. So to be sure that you see it, i paste my response here.

Please be free to delete this issue if you saw my response in the closed thread.

Hi again!
Sorry, that was a miscommunication. This is really about "Hide URL Information for Default language" and the fact that after going to the secondary language, visiting the site without language path gets you to the secondary language again.

Thank you for the clarification about your reasons to "get" the language in the order that it does. I see many things clearer now and i can understand the reasons.

I think the reason that so many "mqtranslate-to-qtranslate-x-switchers" like me have a problem with this is that its completely opposite to what we were used to from mqtranslate or qtranslate. mqtranslate didn't use cookies or Browser Redirection, so this is new to us and sometimes breaks functionality on existing websites.

Maybe we (you) can implement a compatibility function that uses my "fix" above if activated. It could be called "mqtranslate redirect compatibility" or something like this ;)

Happy Coding,
Kuchenundkakao

problem with search form - qtranxf_convertURL produces wrong URL

Issue by pavelw
Sunday Jan 18, 2015 at 13:13 GMT
Originally opened as qTranslate-Team/qtranslate-x#8


Hello,

current version of plugin makes for me the wrong translation of URL.

I am switched to non-default language and trying to use search form produces wrong URL

the blog is not on home url, but on subpage: http://mypageblog/blog/

typing the query in search box produces wrong URL http://mypageblog/blog/pl/pl/?s=dsa

commenting out in function:

function qtranxf_fixSearchForm($form) {
//$form = preg_replace('#action="[^"]*"#','action="'.trailingslashit(qtranxf_convertURL(get_home_url())).'"',$form);
return $form;
}

fixes the problem, the URL is correct: http://mypageblog/blog/pl/?s=dsa

i guess there is some kind of problem in the qtranxf_convertURL function.

more info available upon request.

best regards,
Pawel

DB Conversion to Brackets / Legacy throws errors because of mysql_real_escape_string, better use $wpdb->prepare

Issue by kuchenundkakao
Tuesday Feb 24, 2015 at 12:11 GMT
Originally opened as qTranslate-Team/qtranslate-x#37


As the title says, if you try to use the "convert database" function, you get a lot of errors because no mysql connection is opened.

Please replace lines 81 and 97 in the admin/admin_utils.php with the following:

$wpdb->query($wpdb->prepare('UPDATE '.$wpdb->posts.' set post_content = %s, post_title=%s, post_excerpt=%s  WHERE ID=%d',$content, $title, $excerpt, $post->ID));

http://codex.wordpress.org/Data_Validation#Database

Throwing a lot of php warnings and notices in debug bar

Issue by 72quadrat
Tuesday Feb 24, 2015 at 11:57 GMT
Originally opened as qTranslate-Team/qtranslate-x#35


I just did a migration from mqtranslate to qtranslatex and get some errors – perhaps the given strings or data are not nice validated? Site seems to work.

WARNING: wp-content/plugins/qtranslate-x/qtranslate_core.php:1199 - get_class() expects parameter 1 to be object, string given

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, Debug_Bar->render, __, translate, apply_filters('gettext'), call_user_func_array, qtranxf_gettext, qtranxf_use, get_class

WARNING: wp-content/plugins/qtranslate-x/qtranslate_core.php:1199 - get_class() expects parameter 1 to be object, integer given

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action_ref_array, call_user_func_array, wp_admin_bar_updates_menu, wp_get_update_data, wp_get_translation_updates, get_site_transient, get_site_option, get_option, apply_filters('option__site_transient_update_themes'), call_user_func_array, qtranxf_useCurrentLanguageIfNotFoundUseDefaultLanguage, qtranxf_use, qtranxf_use, get_class

WARNING: wp-content/plugins/qtranslate-x/qtranslate_core.php:1199 - get_class() expects parameter 1 to be object, boolean given

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action_ref_array, call_user_func_array, wp_admin_bar_updates_menu, wp_get_update_data, wp_get_translation_updates, get_site_transient, get_site_option, get_option, apply_filters('option__site_transient_update_core'), call_user_func_array, qtranxf_useCurrentLanguageIfNotFoundUseDefaultLanguage, qtranxf_use, qtranxf_use, qtranxf_use, qtranxf_use, qtranxf_use, get_class

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:73 - Undefined offset: 5

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:76 - Undefined offset: 6

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:77 - Undefined offset: 7

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:78 - Undefined offset: 8

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:72 - Undefined offset: 1

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:73 - Undefined offset: 4

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:74 - Undefined offset: 2

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

NOTICE: wp-content/plugins/qtranslate-x/qtranslate_utils.php:75 - Undefined offset: 3

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/lucas/front-page.php'), get_footer, locate_template, load_template, require_once('/themes/lucas/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, wp_admin_bar_render, do_action('wp_before_admin_bar_render'), call_user_func_array, wp_customize_support_script, home_url, get_home_url, apply_filters('home_url'), call_user_func_array, qtranxf_home_url, qtranxf_get_url_for_language, qtranxf_parseURL

Use core WordPress methods for the language file updates

Issue by mweimerskirch
Friday Feb 20, 2015 at 18:48 GMT
Originally opened as qTranslate-Team/qtranslate-x#24


Use core WordPress methods for the language file updates instead of probing the SVN directories (which does not always work). Another advantage of this approach is that the "admin" and "network-admin" translations are updated as well.


mweimerskirch included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/24/commits

i18n improvements

Issue by mweimerskirch
Friday Feb 20, 2015 at 17:38 GMT
Originally opened as qTranslate-Team/qtranslate-x#23


I fixed a few translatable strings (the translation domain "qtranslate" was missing).
And I added a shell script that makes it much easier to update the language files. It just needs to be run in the "lang" folder. I noticed that the files in the "admin" directory are not included in the current pot/po files.


mweimerskirch included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/23/commits

qtranslate-x-2.8 + qtranslate-slugs is broken

Issue by beheist
Saturday Jan 10, 2015 at 08:10 GMT
Originally opened as qTranslate-Team/qtranslate-x#1


Good morning John,

I just upgraded my blog to qTranslate-X 2.8. After doing that, none of my posts were reachable anymore - everything resulted in 404s. When I disabled qTranslate-slugs, my posts were reachable again, so there seems something in qTranslate-X 2.8 that breaks if slugs is also used.
This issue has made me rethink the current approach with qTranslate-X and qTranslate slugs. I think we're running into a fundamental issue here - as long as the two plugins are separate and are thus not always tested together, issues like these will keep cropping up. Of course, it'd be possible to try and fix slugs everytime qTX gets upgraded (or the other way round), but that would lead to a lot of uncertainty and frustration for users because it's not ensured that a working combination is installed.
So I'd like to discuss whether you think it makes sense to include the slugs functionality in qTranslate-X itself. If you agree (and also if @LC43 doesn't see a problem with that since it's his code) I would volunteer to include that functionality. What do you think?

Best regards,
Bastian

The shortcodes are not escaped when saving

Issue by mweimerskirch
Monday Feb 23, 2015 at 22:38 GMT
Originally opened as qTranslate-Team/qtranslate-x#31


The following is a minor issue I noticed while digging through the code.
The original qtranslate used HTML comments as separation characters:

<!--:en-->.....<!--:-->

A big advantage of this notation was that if you happened to use this notation in the WYIWYG editor, it would be escaped automatically and saved correctly:

&lt;!--:el--&gt;.....&lt;!--:--&gt;

qtranslate-x uses the shorter versions:

[:en]......

When entered manually in the WYSIWYG editor (e.g. if you want to write an article about qtranslate-x), the codes disappear when saving, because they are not escaped.

On a related note, the original qtranslate codes disappear as well (which didn't happen with the original version). This might be because the "split_regex" handles both separators at the same time.

Option for showing post in default language if translation not available

Issue by spartacus-zeus
Thursday Feb 19, 2015 at 18:31 GMT
Originally opened as qTranslate-Team/qtranslate-x#21


Hi qTranslateTeam,

First, thank you for your great work! Since I found that this plugin is actively developed, I'll try to do a feature request.

I would be very pleased to see an option in the admin panel to also show posts in the default language when a translation is not available. Currently, (if I'm correct) this is only possible for the title of the post.

Something like this would be perfect:

Sorry, this entry is only available in Language

to:

Sorry, this entry is only available in Language:

post in default language here

Thanks!

Tags and Categories not translated after migration

Issue by wocmultimedia
Friday Feb 20, 2015 at 19:06 GMT
Originally opened as qTranslate-Team/qtranslate-x#25


Hi,
I wrote also in wp support. After migrating almost painless from mqTranslate I found out that Tags and Categories are not translated after the migration.
I have a bilingual site (English- Italian) and Italian tags/Categories are not present anymore. Clicking the language button only English version is available of both. Pages and Posts works correctly. If you visit http://www.norwayinteractive.biz/ changing language can see that About Us menu item changes because is a page title while other items not, they are tags and categories.
I wish you can find the fix because there's no error log in the php panel of server site
thanks
I tested with other themes too and tried to deactivate also some plugins but nothing changes and tags/categories are not available in Italian always English is shown.

Allow themes and plugins to add their own custom content hooks

Issue by funkjedi
Wednesday Feb 25, 2015 at 09:00 GMT
Originally opened as qTranslate-Team/qtranslate-x#40


Trigger a custom event when addCustomContentHooks is called to allow themes and plugin developers to add their own custom content hooks.

Usage example:

jQuery(document).on('qTranslateX:addCustomContentHooks', function(event, qtx, form) {

    jQuery('.acf-field-text .acf-input-wrap input').each(function() {
        qtx.addContentHookById(this.id, form);
    });

});

funkjedi included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/40/commits

TypeError: Cannot read property 'getNode' of undefined

Issue by simplicitylab
Thursday Feb 26, 2015 at 11:39 GMT
Originally opened as qTranslate-Team/qtranslate-x#47


Hi,

Platform info:

  • OSX - Chrome 40.0.2214.111 (64-bit)
  • On Firefox I couldn't reproduce it

Problem:

On a clean install + qtranslate-x I get the following error when editing a post (that has the visual tab active on load)

Uncaught TypeError: Cannot read property 'getNode' of undefined

Steps to reproduce:

  1. Install wordpress
  2. Install qtranslate-x and enable it
  3. Post > edit "Hello world" for example

This bug only occurs when "Visual tab" is the active one on load. If for example "Text" and I switch to "Visual" there is no error.

I have the feeling that it is trying to access an element in the DOM that at that point isn't loaded/ready yet. I need to find some time to investigate further.

Sanitize inputs

Issue by adamfranco
Tuesday Feb 24, 2015 at 16:37 GMT
Originally opened as qTranslate-Team/qtranslate-x#38


After doing a security review of this plugin I found that site/blog-admins are able to include javascript tags and other HTML markup in text-fields that could allow the inclusion of malicious javascript on every page, e.g.

Language Name: English <script>alert(document.cookie);</script>

While site-admins might be trusted on single-site installations, on multi-site installations the owners/admins of individual sites cannot necessarily be trusted. This pull-request runs the user-inputs in the configuration screens through WP's built-in input-validation functions. For more information, see: http://codex.wordpress.org/Data_Validation#Input_Validation


adamfranco included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/38/commits

Replaced the custom "xsplit" function with the standard JavaScript split function

Issue by mweimerskirch
Monday Feb 23, 2015 at 23:14 GMT
Originally opened as qTranslate-Team/qtranslate-x#32


I'm still trying to make the code more readable and easier to test and extend. IMHO the "xsplit" function can be removed. The function was necessary for qtranslate to be compatible with older browsers. Newer browser that implement ECMAScript 5 (this includes IE 9 in "standards mode") do not need this any longer. This would make the code a bit more readable, but IE 8 on the other hand would no longer be compatible. However, as WordPress displays a big warning when you use the admin area with IE 8 (or other old browsers), this should not be a problem.


mweimerskirch included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/32/commits

Random <p> and </p> tags in post editor pages

Issue by johnclause
Wednesday Jan 14, 2015 at 02:16 GMT
Originally opened as qTranslate-Team/qtranslate-x#5


Theme: any, "Twenty Fifteen" would do.
Plugins: can be qTranslate-X only, I do not think it is a compatibility problem with other plugins.
At least two languages, for example, en and de, to be specific.

Steps to reproduce the problem:

  • Add New Post
  • Title: any, it is not a subject of the problem
  • Put Editor in "Text" mode
  • Description: type EN for "en" language and DE for "de", just as an example, any text would do.
  • Publish.
  • Go to database and see that 'post_content' field of that post has <!--:en-->EN<!--:--><!--:de-->DE<!--:-->, which is normal.
  • Open that post for editing.
  • Editor comes in "Text" mode, as it was left in "Text" mode before.
  • Switch to "Visual" mode
  • Click on description text, do not even need to do any typing, just press "Update" button right then.
  • Database now has: <!--:en--><p>EN</p><!--:--><!--:de-->DE<!--:-->, where EN was the active language at time of pressing "Update". This part is kind of explainable, TinyMCE embraced active text with <p></p>, although it does not do so, when plugin is deactivated.

But then something really strange happens:

  • click in editor again and then “Update” again, database now has:
    <!--:en--><p>EN</p><p> </p><!--:--><!--:de-->DE<!--:-->
  • And even more striking, do not click anywhere, just press “Update” again. database now has:
    <p><!--:en--><p>EN</p><p> </p><p><!--:--><!--:de-->DE<!--:--></p>
    Pay attention that <p> and </p> do not match anymore.

Further clicking “Update” does not modify this text anymore.

I have been printing various variables on java console, but those <p> did not show up anywhere I looked so far. I have no idea how they get into the database.

If people consistently keep editor at "Visual" mode, they apparently do not notice a problem. Nobody complained about this yet, but we'd better to clear it out before somebody does.

P. S. I first discovered this in the original qTranslate, and I thought that after cleaning the code, it will go away on its own, but it did not so far.

design of function qtranxf_excludeUntranslatedPostComments

Issue by johnclause
Thursday Feb 12, 2015 at 00:02 GMT
Originally opened as qTranslate-Team/qtranslate-x#17


This is a continuation of WP discussion https://wordpress.org/support/topic/the-latest-beta-from-github-is-good-for-testing-thank-you on the topic initiated by side777.

side777: I get a WordPress database error Unknown column 'wp_posts.post_content' in 'where clause' for query SELECT * FROM wp_comments [...] but only on some sites of my multisite network. still investigating.

side777: Unfortunately i could not reproduce the error with a clean 2015 - BUT get_comments() still returns an empty array! The 2015 recent comment widget DOES return the comments, but ALL, also for untranslated posts, though.

johnclause: I guess in some cases this query gets executed without wp_posts table included. What are those cases? Do we abort this function in such cases? Or do we force a reference to wp_posts in somehow?

side777: I think this is not a good approach anyway - in worst case you query 1000s of comments WITH the corresponding posts, PLUS filtering the post content - I wrote my own solution a while ago... I think it's way more effective to save the current language to a comment meta when the comment is saved. this way you can easily query comments by meta.

johnclause: Sure that would be much better. Unfortunately, qTranslate is not designed for big sites with many languages and huge content to begin with. It does have severe performance problems in many places, not just this one. My priority is to make it work in a minimal, but bug free way, so that people can continue to use it. Most of qTranslate* clients, I believe, are small bi-lingual (not multi-) sites and they are ok with this version of free translation framework. I would worry about the performance issues later, when time comes. For now we need to figure out how to fix this query issue as soon as possible, so that I could release 3.0. Then I will be happy to come back and redesign this piece as well as other places in a much more efficient way. And I believe that those missing if statements, which we need to figure out now, will be useful to know when we do optimization.

Visual editors compatibility

Issue by johnclause
Friday Feb 20, 2015 at 23:14 GMT
Originally opened as qTranslate-Team/qtranslate-x#27


Hi Michel (@mweimerskirch), I am wondering, since you seem pretty familiar with both codes, mq- and -x, could you take a look at the problem with WP Editor https://wordpress.org/plugins/wp-editor/? Users report, https://wordpress.org/support/topic/wp-edit-modifying-pages-in-visual-mode-not-working, it working in mq-, while it not working in -x. Would you be able and have time to look for a reason? I would not expect a fix to be easy, but at least understanding the reason why it does not work in -x would be a good start. Thanks a lot in any case for all your help.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.