quan-digital/ftx

Library for connecting to the FTX API.

ftx's Issues

Can't cancel trigger orders with the cancel order function

Can't cancel trigger orders with the cancel_order()
Probably need to have another function with DELETE /conditional_orders/{id}

Get lending info + submit lending offers

Solved

Authentication exception

I can't seem to get the authentication to work successfully. Is anyone else having this problem? I've attached a code example below. The api_key and api_secret I've obviously changed out but they would be copied and pasted from the key generated on my profile page. I've tried generating a new key pair and have given it all permissions but still no luck.

import ftx

api_key = 'my_api_key_pasted'
api_secret = 'my_api_secret_key_pasted'
client = ftx.FtxClient(api_key=api_key, api_secret=api_secret)

acc_info = client.get_account_info()
print(acc_info)

Traceback (most recent call last):
  File "lending_history.py", line 7, in <module>
    acc_info = client.get_account_info()
  File "/mnt/c/Users/Username/PycharmProjects/ftx_lending/src/ftx/ftx/api.py", line 73, in wrapped
    return fn(self, *args, **kwargs)
  File "/mnt/c/Users/Username/PycharmProjects/ftx_lending/src/ftx/ftx/api.py", line 78, in get_account_info
    return self._get(f'account')
  File "/mnt/c/Users/Username/PycharmProjects/ftx_lending/src/ftx/ftx/api.py", line 20, in _get
    return self._request('GET', path, params=params)
  File "/mnt/c/Users/Username/PycharmProjects/ftx_lending/src/ftx/ftx/api.py", line 34, in _request
    return self._process_response(response)
  File "/mnt/c/Users/Username/PycharmProjects/ftx_lending/src/ftx/ftx/api.py", line 59, in _process_response
    raise Exception(data['error'])
Exception: Not logged in

Please archive repo since FTX has filled for bankruptcy and will be liquidated.

It's all over the news, FTX will be liquidated.

https://www.fca.org.uk/news/news-stories/information-ftx-customers

https://www.reuters.com/technology/bahamas-financial-regulators-appoint-liquidators-ftx-unit-2022-11-15/

Doesnt get all the trades.

When I compare the data it gives from get_trades vs the one on the platform it doesnt match. If the trades are rare then everything is fine. As soon as there are more than 2 trades in one second it skips alot of them. Is there another way how to get all trades?

AttributeError: 'NoneType' object has no attribute 'encode'

I cannot login as api and secret key

In [3]: client = ftx.FtxClient("xxx", "xxx")

In [4]: client.get_balances()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-12-84f4855be095> in <module>
----> 1 client.get_balances()

~/opt/anaconda3/lib/python3.7/site-packages/ftx/api.py in wrapped(self, *args, **kwargs)
     69                 raise TypeError("You must be authenticated to use this method")
     70             else:
---> 71                 return fn(self, *args, **kwargs)
     72         return wrapped
     73 

~/opt/anaconda3/lib/python3.7/site-packages/ftx/api.py in get_balances(self)
    164     @authentication_required
    165     def get_balances(self) -> List[dict]:
--> 166         return self._get(f'wallet/balances')
    167 
    168     @authentication_required

~/opt/anaconda3/lib/python3.7/site-packages/ftx/api.py in _get(self, path, params)
     18 
     19     def _get(self, path: str, params: Optional[Dict[str, Any]] = None) -> Any:
---> 20         return self._request('GET', path, params=params)
     21 
     22     def _post(self, path: str, params: Optional[Dict[str, Any]] = None) -> Any:

~/opt/anaconda3/lib/python3.7/site-packages/ftx/api.py in _request(self, method, path, **kwargs)
     29         request = Request(method, self._base_url + path, **kwargs)
     30         if self._api_key:
---> 31             self._sign_request(request)
     32         response = self._session.send(request.prepare())
     33 

~/opt/anaconda3/lib/python3.7/site-packages/ftx/api.py in _sign_request(self, request)
     40         if prepared.body:
     41             signature_payload += prepared.body
---> 42         signature = hmac.new(self._api_secret.encode(), signature_payload, 'sha256').hexdigest()
     43         request.headers['FTX-KEY'] = self._api_key
     44         request.headers['FTX-SIGN'] = signature

AttributeError: 'NoneType' object has no attribute 'encode'

Wrong parameters in `FtxClient.place_trigger_order`

Parameters not up to date with https://docs.ftx.com/#place-trigger-order

• cancelLimitOnTrigger is not a valid parameter
• trailValue is not sent as payload despite being in the function parameter
• retryUntilFilled is missing

`place_order` missing `rejectOnPriceBand` payload

Missing parameter on rejectOnPriceBand as seen in the documentation for POST /orders

https://docs.ftx.com/#place-order

rejectOnPriceBand | boolean | false | optional; if the order should be rejected if its price would instead be adjusted due to price bands

missing ciso8601 in requirements.txt

All is in the title : please add ciso8601 in requirements.txt !
Thanks guys, awesome package.

Bodchange / 24hour change gives wrong data

When I'm printing my percentage change I get to see the wrong data in comparison to the FTX site. I have this problem with other pairings as well. I also have this problem with the 24h change.

Is there anybody who knows what I'm doing wrong?

Appreciate any suggestions. Thanks!

Take Profit and Trailing Stop not working.

"""
To send a Stop Market order, set type='stop' and supply a trigger_price
To send a Stop Limit order, also supply a limit_price
To send a Take Profit Market order, set type='trailing_stop' and supply a trigger_price
To send a Trailing Stop order, set type='trailing_stop' and supply a trail_value
"""

This is commented in the api.py. Every way i try to post a take profit or trailing stop or even a stop (as a take_profit value) i receive an error, usually saying the trigger price is too high, which is not possible when putting a take profit on a long position.

Has anyone else had similar issues with placing orders?

Appreciate any suggestions. Thanks